From: Ali Alnubani <alialnu@nvidia.com>
To: Ferruh Yigit <ferruh.yigit@amd.com>,
Aman Singh <aman.deep.singh@intel.com>,
Yuying Zhang <yuying.zhang@intel.com>,
Anatoly Burakov <anatoly.burakov@intel.com>,
Jie Hai <haijie1@huawei.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"NBU-Contact-Thomas Monjalon (EXTERNAL)" <thomas@monjalon.net>,
David Marchand <david.marchand@redhat.com>,
"stable@dpdk.org" <stable@dpdk.org>,
"songx.jiale@intel.com" <songx.jiale@intel.com>,
"qiming.yang@intel.com" <qiming.yang@intel.com>
Subject: RE: [PATCH] app/testpmd: revert primary process polling all queues fix
Date: Thu, 6 Jul 2023 10:01:10 +0000 [thread overview]
Message-ID: <DM4PR12MB5167655BC40AE530F3A958FADA2CA@DM4PR12MB5167.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20230705143206.268958-1-ferruh.yigit@amd.com>
> -----Original Message-----
> From: Ferruh Yigit <ferruh.yigit@amd.com>
> Sent: Wednesday, July 5, 2023 5:32 PM
> To: Aman Singh <aman.deep.singh@intel.com>; Yuying Zhang
> <yuying.zhang@intel.com>; Anatoly Burakov <anatoly.burakov@intel.com>;
> Jie Hai <haijie1@huawei.com>
> Cc: dev@dpdk.org; NBU-Contact-Thomas Monjalon (EXTERNAL)
> <thomas@monjalon.net>; David Marchand <david.marchand@redhat.com>;
> stable@dpdk.org; songx.jiale@intel.com; qiming.yang@intel.com
> Subject: [PATCH] app/testpmd: revert primary process polling all queues fix
>
> For some drivers [1], testpmd forwarding is broken with commit [2].
>
> This is because with [2] testpmd gets queue state from ethdev and
> forwarding is done only on queues in started state, but some drivers
> don't update queue status properly, and this breaks forwarding for those
> drivers.
>
> Drivers should be fixed but more time is required to verify drivers
> again, instead reverting [2] for now to not break drivers.
> Target is to merge [2] back at the beginning of next release cycle and
> fix drivers accordingly.
>
> [1]
> Bugzilla ID: 1259
>
> [2]
> Fixes: 141a520b35f7 ("app/testpmd: fix primary process not polling all
> queues")
> Cc: stable@dpdk.org
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@amd.com>
> ---
Thanks, Ferruh. Tested on top of latest main (df60837ccd65).
Tested-by: Ali Alnubani <alialnu@nvidia.com>
prev parent reply other threads:[~2023-07-06 10:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-05 14:32 Ferruh Yigit
2023-07-05 16:50 ` Ferruh Yigit
2023-07-06 9:24 ` Jiale, SongX
2023-07-06 10:23 ` Ferruh Yigit
2023-07-06 10:01 ` Ali Alnubani [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM4PR12MB5167655BC40AE530F3A958FADA2CA@DM4PR12MB5167.namprd12.prod.outlook.com \
--to=alialnu@nvidia.com \
--cc=aman.deep.singh@intel.com \
--cc=anatoly.burakov@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=haijie1@huawei.com \
--cc=qiming.yang@intel.com \
--cc=songx.jiale@intel.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
--cc=yuying.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).