From: Ali Alnubani <alialnu@nvidia.com>
To: Dmitry Kozlyuk <dkozlyuk@nvidia.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Xueming(Steven) Li" <xuemingl@nvidia.com>,
NBU-Contact-Thomas Monjalon <thomas@monjalon.net>,
Ferruh Yigit <ferruh.yigit@intel.com>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Subject: Re: [dpdk-dev] [PATCH] ethdev: fix device capability to string translation
Date: Tue, 9 Nov 2021 11:56:25 +0000 [thread overview]
Message-ID: <DM4PR12MB516780653CBDC17367522B25DA929@DM4PR12MB5167.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20211109090058.1879428-1-dkozlyuk@nvidia.com>
> -----Original Message-----
> From: Dmitry Kozlyuk <dkozlyuk@nvidia.com>
> Sent: Tuesday, November 9, 2021 11:01 AM
> To: dev@dpdk.org
> Cc: Ali Alnubani <alialnu@nvidia.com>; Xueming(Steven) Li
> <xuemingl@nvidia.com>; NBU-Contact-Thomas Monjalon
> <thomas@monjalon.net>; Ferruh Yigit <ferruh.yigit@intel.com>; Andrew
> Rybchenko <andrew.rybchenko@oktetlabs.ru>
> Subject: [PATCH] ethdev: fix device capability to string translation
>
> Add support for RTE_ETH_DEV_CAPA_FLOW_{RULE,SHARED_OBJECT}_KEEP
> to rte_eth_dev_capability_name(), missed when adding the capabilities.
>
> Fixes: 1d5a3d68c0f9 ("ethdev: add capability to keep flow rules on restart")
> Fixes: 2c9cd45de7e6 ("ethdev: add capability to keep shared objects on
> restart")
>
> Reported-by: Ali Alnubani <alialnu@nvidia.com>
> Signed-off-by: Dmitry Kozlyuk <dkozlyuk@nvidia.com>
> Acked-by: Xueming Li <xuemingl@nvidia.com>
> ---
> P.S. I don't know a good way to catch such errors in the future
> except by a unit test, but adding a new suite for ethdev
> seems worthy of its own patch (if needed at all).
>
Tested-by: Ali Alnubani <alialnu@nvidia.com>
Thanks,
Ali
next prev parent reply other threads:[~2021-11-09 11:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-09 9:00 Dmitry Kozlyuk
2021-11-09 11:56 ` Ali Alnubani [this message]
2021-11-09 18:43 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM4PR12MB516780653CBDC17367522B25DA929@DM4PR12MB5167.namprd12.prod.outlook.com \
--to=alialnu@nvidia.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=dkozlyuk@nvidia.com \
--cc=ferruh.yigit@intel.com \
--cc=thomas@monjalon.net \
--cc=xuemingl@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).