From: "Xueming(Steven) Li" <xuemingl@nvidia.com>
To: Christian Ehrhardt <christian.ehrhardt@canonical.com>
Cc: dev <dev@dpdk.org>, Luca Boccassi <bluca@debian.org>,
NBU-Contact-Thomas Monjalon <thomas@monjalon.net>,
dpdk stable <stable@dpdk.org>,
Yuanhan Liu <yuanhan.liu@linux.intel.com>
Subject: Re: [dpdk-stable] [PATCH 2/2] devtools: auto detect branch to search fix patches
Date: Tue, 15 Jun 2021 10:56:17 +0000 [thread overview]
Message-ID: <DM4PR12MB5373E56634DDF8F2F9FCF139A1309@DM4PR12MB5373.namprd12.prod.outlook.com> (raw)
In-Reply-To: <CAATJJ0LGNeeo+JQwQ9DHWc5JaiQLsz5Ocs7d5XEi_FYKP5xdwg@mail.gmail.com>
> -----Original Message-----
> From: Christian Ehrhardt <christian.ehrhardt@canonical.com>
> Sent: Monday, June 14, 2021 10:16 PM
> To: Xueming(Steven) Li <xuemingl@nvidia.com>
> Cc: dev <dev@dpdk.org>; Luca Boccassi <bluca@debian.org>; NBU-Contact-Thomas Monjalon <thomas@monjalon.net>; dpdk stable
> <stable@dpdk.org>; Yuanhan Liu <yuanhan.liu@linux.intel.com>
> Subject: Re: [PATCH 2/2] devtools: auto detect branch to search fix patches
>
> On Sat, Jun 12, 2021 at 3:57 PM Xueming Li <xuemingl@nvidia.com> wrote:
> >
> > Current fix scan scripts scanned specified range in current(HEAD)
> > branch. When users run it in a earlier branch, few patches were
>
> ^^ typo missing "an" (if you care)
>
> > scanned.
> >
> > This patch auto etects branch to scan from range.
>
> ^^ typo missing "d" (if you care)
Thanks :)
>
> >
> > Fixes: 752d8e097ec1 ("scripts: show fixes with release version of
> > bug")
> > Cc: Thomas Monjalon <thomas@monjalon.net>
> > Cc: stable@dpdk.org
> > Signed-off-by: Xueming Li <xuemingl@nvidia.com>
> > ---
> > devtools/git-log-fixes.sh | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/devtools/git-log-fixes.sh b/devtools/git-log-fixes.sh
> > index 5fc57da913..9a8a9d6739 100755
> > --- a/devtools/git-log-fixes.sh
> > +++ b/devtools/git-log-fixes.sh
> > @@ -34,13 +34,15 @@ done
> > shift $(($OPTIND - 1))
> > [ $# -ge 1 ] || usage_error 'range argument required'
> > range="$*"
> > +range_last=$(git log --oneline v21.05-rc3..v21.05 |head -n1|cut -d' '
> > +-f1)
>
> Instead of these values that would need to be dynamic to be generally reliable right?
> Everyone might need something different.
>
> I thought about the same and wondered if this script should get a new optional argument.
> If passed it will use this new argument instead of $refbranch
>
> That would allow any user today to be able to continue to use it as-is and anyone else can for reliable behavior define the branch to
> look in.
Looks good. There are two scenarios for this script:
Called from check-git-log.sh: if version not found, default to VERSION file
Standalone running with range: I don't think a default is required.
So the default version only valid when "branch" argument is "HEAD"
>
> > +# use first branch
> > +refbranch=$(git branch --contains $range_last -r --sort=-authordate
> > +|head -n1)
> >
> > # get major release version of a commit commit_version () # <hash>
> > {
> > local VER="v*.*"
> > # use current branch as history reference
> > - local refbranch=$(git rev-parse --abbrev-ref HEAD)
> > local tag=$( (git tag -l $VER --contains $1 --sort=creatordate --merged $refbranch 2>&- ||
> > # tag --merged option has been introduced in git 2.7.0
> > # below is a fallback in case of old git version
> > --
> > 2.25.1
> >
>
>
> --
> Christian Ehrhardt
> Staff Engineer, Ubuntu Server
> Canonical Ltd
next prev parent reply other threads:[~2021-06-15 10:56 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-12 13:56 [dpdk-stable] [PATCH 1/2] devtools: fix version pattern for fix search Xueming Li
2021-06-12 13:56 ` [dpdk-stable] [PATCH 2/2] devtools: auto detect branch to search fix patches Xueming Li
2021-06-14 14:15 ` Christian Ehrhardt
2021-06-15 10:56 ` Xueming(Steven) Li [this message]
2021-06-30 6:46 ` Xueming(Steven) Li
2021-06-14 13:56 ` [dpdk-stable] [PATCH 1/2] devtools: fix version pattern for fix search Christian Ehrhardt
2021-06-16 4:03 ` [dpdk-stable] [PATCH v1 " Xueming Li
2021-06-30 6:34 ` [dpdk-stable] [PATCH v2 " Xueming Li
2021-06-30 6:34 ` [dpdk-stable] [PATCH v2 2/2] devtools: fix patches missing if range newer than HEAD Xueming Li
2021-08-08 11:24 ` Thomas Monjalon
2021-08-09 7:44 ` Xueming(Steven) Li
2021-08-08 11:14 ` [dpdk-stable] [PATCH v2 1/2] devtools: fix version pattern for fix search Thomas Monjalon
2021-08-09 3:32 ` Xueming(Steven) Li
2021-06-16 4:03 ` [dpdk-stable] [PATCH v1 2/2] devtools: auto detect branch to search fix patches Xueming Li
2021-08-11 11:22 ` [dpdk-stable] [PATCH v3 1/2] devtools: fix version pattern for fix search Xueming Li
2021-08-11 11:22 ` [dpdk-stable] [PATCH v3 2/2] devtools: fix patches missing if range newer than HEAD Xueming Li
2022-11-26 21:44 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM4PR12MB5373E56634DDF8F2F9FCF139A1309@DM4PR12MB5373.namprd12.prod.outlook.com \
--to=xuemingl@nvidia.com \
--cc=bluca@debian.org \
--cc=christian.ehrhardt@canonical.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
--cc=yuanhan.liu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).