From: Matan Azrad <matan@nvidia.com>
To: "835703180@qq.com" <835703180@qq.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "maxime.coquelin@redhat.com" <maxime.coquelin@redhat.com>
Subject: RE: [PATCH V2] vdpa/mlx5: return correct error code after rte_intr_instance_alloc failed
Date: Wed, 15 Jun 2022 07:47:00 +0000 [thread overview]
Message-ID: <DM4PR12MB538967B2C164600B8DC2410FDFAD9@DM4PR12MB5389.namprd12.prod.outlook.com> (raw)
In-Reply-To: <tencent_C9831EAD241A58D1BB2540324E2AF3E82609@qq.com>
Hi Shiqi
From: 835703180@qq.com <835703180@qq.com>
> From: Shiqi Liu <835703180@qq.com>
>
> To Maxime,
> I am so sorry too late to reply your comment.My name is Shiqi Liu.
> I got stuck in how to reply the comment before.Now, it seenms to be
> ok!Maybe there will be some mistakes I have taken , when I reply,please tell
> me how to do it correctly!
> Thanks,
> Shiqi Liu
>
> diff --git a/drivers/vdpa/mlx5/mlx5_vdpa_event.c
> b/drivers/vdpa/mlx5/mlx5_vdpa_event.c
> index 7167a98db0..6223afaae8 100644
> --- a/drivers/vdpa/mlx5/mlx5_vdpa_event.c
> +++ b/drivers/vdpa/mlx5/mlx5_vdpa_event.c
> @@ -395,6 +395,7 @@ mlx5_vdpa_err_event_setup(struct mlx5_vdpa_priv
> *priv)
> rte_intr_instance_alloc(RTE_INTR_INSTANCE_F_SHARED);
> if (priv->err_intr_handle == NULL) {
> DRV_LOG(ERR, "Fail to allocate intr_handle");
> + rte_errno = ENOMEM;
Shouldn't rte_intr_instance_alloc set it?
> goto error;
> }
> if (rte_intr_fd_set(priv->err_intr_handle, priv->err_chnl->fd))
> --
next prev parent reply other threads:[~2022-06-15 7:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-12 14:09 [PATCH] " 835703180
2022-06-14 9:43 ` Maxime Coquelin
2022-06-14 13:36 ` [PATCH V2] " 835703180
2022-06-14 13:50 ` Maxime Coquelin
2022-06-14 13:48 ` 835703180
2022-06-15 7:47 ` Matan Azrad [this message]
2022-06-22 8:03 ` [PATCH] " Matan Azrad
2022-06-22 8:11 ` Maxime Coquelin
2022-06-22 8:46 ` Thomas Monjalon
2022-06-22 8:46 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM4PR12MB538967B2C164600B8DC2410FDFAD9@DM4PR12MB5389.namprd12.prod.outlook.com \
--to=matan@nvidia.com \
--cc=835703180@qq.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).