From: Matan Azrad <matan@nvidia.com>
To: Yunjian Wang <wangyunjian@huawei.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: Slava Ovsiienko <viacheslavo@nvidia.com>,
Dmitry Kozlyuk <dkozlyuk@nvidia.com>,
"huangshaozhang@huawei.com" <huangshaozhang@huawei.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: RE: [dpdk-dev] [PATCH 1/1] net/mlx5: fix memory leak when releasing a drop action
Date: Sun, 31 Jul 2022 07:02:27 +0000 [thread overview]
Message-ID: <DM4PR12MB538998F53EAB64AD91D4B26EDF9B9@DM4PR12MB5389.namprd12.prod.outlook.com> (raw)
In-Reply-To: <004c86e8ddf05bb9d3df77580357c4eca852c013.1659177063.git.wangyunjian@huawei.com>
Hi Yunjian
From: Yunjian Wang
> When the memory for hrxq->action is allocated in mlx5_devx_hrxq_new().
Memory -> resources .. are
> But it was not being freed when the drop action was released in
> mlx5_devx_drop_action_destroy(). These cause a memory leak.
>
> Fixes: bc5bee028ebc ("net/mlx5: create drop queue using DevX")
> Cc: stable@dpdk.org
>
> Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
> ---
> drivers/net/mlx5/mlx5_devx.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/net/mlx5/mlx5_devx.c b/drivers/net/mlx5/mlx5_devx.c
> index 6886ae1f22..171ce5c08a 100644
> --- a/drivers/net/mlx5/mlx5_devx.c
> +++ b/drivers/net/mlx5/mlx5_devx.c
> @@ -1097,6 +1097,12 @@ mlx5_devx_drop_action_destroy(struct
> rte_eth_dev *dev)
> mlx5_devx_ind_table_destroy(hrxq->ind_table);
> if (priv->drop_queue.rxq->devx_rq.rq != NULL)
> mlx5_rxq_devx_obj_drop_release(dev);
> +#ifdef HAVE_IBV_FLOW_DV_SUPPORT
> + if (hrxq->action != NULL) {
> + mlx5_glue->destroy_flow_action(hrxq->action);
> + hrxq->action = NULL;
> + }
> +#endif
Good catch for the leak.
I think the issue is in mlx5_devx_tir_destroy and not related only to the drop queue management.
So the fix should be for the mlx5_devx_tir_destroy. What do you think?
> }
>
> /**
> --
> 2.27.0
next prev parent reply other threads:[~2022-07-31 7:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-30 10:40 Yunjian Wang
2022-07-31 7:02 ` Matan Azrad [this message]
2022-08-03 13:23 ` wangyunjian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM4PR12MB538998F53EAB64AD91D4B26EDF9B9@DM4PR12MB5389.namprd12.prod.outlook.com \
--to=matan@nvidia.com \
--cc=dev@dpdk.org \
--cc=dkozlyuk@nvidia.com \
--cc=huangshaozhang@huawei.com \
--cc=stable@dpdk.org \
--cc=viacheslavo@nvidia.com \
--cc=wangyunjian@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).