From: Tomasz Duszynski <tduszynski@marvell.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
Jakub Palider <jpalider@marvell.com>,
Jerin Jacob <jerinj@marvell.com>,
"david.marchand@redhat.com" <david.marchand@redhat.com>,
"stephen@networkplumber.org" <stephen@networkplumber.org>,
Jerin Jacob <jerinjacobk@gmail.com>
Subject: RE: [EXT] Re: [PATCH v2] raw/cnxk_bphy: switch to dynamic logging
Date: Wed, 21 Feb 2024 08:43:49 +0000 [thread overview]
Message-ID: <DM4PR18MB43682625E2B3E6443899291DD2572@DM4PR18MB4368.namprd18.prod.outlook.com> (raw)
In-Reply-To: <5588023.3daJWjYHZt@thomas>
>-----Original Message-----
>From: Thomas Monjalon <thomas@monjalon.net>
>Sent: Wednesday, February 21, 2024 3:00 AM
>To: Tomasz Duszynski <tduszynski@marvell.com>
>Cc: dev@dpdk.org; Jakub Palider <jpalider@marvell.com>; Jerin Jacob <jerinj@marvell.com>;
>david.marchand@redhat.com; stephen@networkplumber.org; Jerin Jacob <jerinjacobk@gmail.com>
>Subject: [EXT] Re: [PATCH v2] raw/cnxk_bphy: switch to dynamic logging
>
>External Email
>
>----------------------------------------------------------------------
>06/12/2023 15:09, Jerin Jacob:
>> On Mon, Nov 27, 2023 at 11:42 PM Tomasz Duszynski
>> <tduszynski@marvell.com> wrote:
>> >
>> > Dynamically allocated log type is a standard approach among all drivers.
>> > Switch to it.
>> >
>> > Signed-off-by: Tomasz Duszynski <tduszynski@marvell.com>
>> > ---
>> > v2:
>> > - cleanup remaining plt_ log calls
>>
>> Applied to dpdk-next-net-mrvl/for-main. Thanks
>
>Sorry, a patch from Stephen has been merged first in the main tree.
>
>The main difference is on log registration:
>Stephen's patch:
> RTE_LOG_REGISTER_SUFFIX(cnxk_logtype_bphy, bphy, INFO); Tomasz' patch:
> RTE_LOG_REGISTER_DEFAULT(bphy_rawdev_logtype, WARNING);
> RTE_LOG_REGISTER_DEFAULT(bphy_cgx_rawdev_logtype, INFO);
>
>There are also many leftovers that were missed in Stephen's patch (plt_err, plt_warn).
>
>Please could you send a rebased patch to fix what was merged?
>
Okay, I'll clean it up.
prev parent reply other threads:[~2024-02-21 8:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-14 8:04 [PATCH] " Tomasz Duszynski
2023-11-15 0:15 ` Stephen Hemminger
2023-11-23 20:36 ` [EXT] " Tomasz Duszynski
2023-11-24 7:56 ` David Marchand
2023-11-27 18:11 ` [PATCH v2] " Tomasz Duszynski
2023-12-06 14:09 ` Jerin Jacob
2024-02-21 1:59 ` Thomas Monjalon
2024-02-21 8:43 ` Tomasz Duszynski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM4PR18MB43682625E2B3E6443899291DD2572@DM4PR18MB4368.namprd18.prod.outlook.com \
--to=tduszynski@marvell.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=jerinjacobk@gmail.com \
--cc=jpalider@marvell.com \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).