From: "Pei, Andy" <andy.pei@intel.com>
To: "Wang, Xiao W" <xiao.w.wang@intel.com>,
"Maheshwari, Abhishek" <abhishek.maheshwari@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"stable@dpdk.org" <stable@dpdk.org>,
"Xia, Chenbo" <chenbo.xia@intel.com>,
"Mandal, Purna Chandra" <purna.chandra.mandal@intel.com>
Subject: RE: [PATCH v2] vdpa/ifc: Match ANY subsystem IDs for modern virtio devices
Date: Fri, 9 Dec 2022 02:37:14 +0000 [thread overview]
Message-ID: <DM5PR11MB17392C4BC12B17BD99BBA8928F1C9@DM5PR11MB1739.namprd11.prod.outlook.com> (raw)
In-Reply-To: <DM8PR11MB575174C7691EB50EB122F448B81D9@DM8PR11MB5751.namprd11.prod.outlook.com>
Hi Abhishek,
I agree with Xiao.
I think it will be better you just add subvendor and subdevice you want to be take care of by this vdpa driver.
> -----Original Message-----
> From: Wang, Xiao W <xiao.w.wang@intel.com>
> Sent: Thursday, December 8, 2022 9:09 PM
> To: Maheshwari, Abhishek <Abhishek.Maheshwari@intel.com>
> Cc: dev@dpdk.org; stable@dpdk.org; Xia, Chenbo <Chenbo.Xia@intel.com>;
> Mandal, Purna Chandra <Purna.Chandra.Mandal@intel.com>; Pei, Andy
> <andy.pei@intel.com>
> Subject: RE: [PATCH v2] vdpa/ifc: Match ANY subsystem IDs for modern virtio
> devices
>
> Hi Abhishek,
>
> Please see comments inline.
>
> BRs,
> Xiao
>
> > -----Original Message-----
> > From: Maheshwari, Abhishek <abhishek.maheshwari@intel.com>
> > Sent: Tuesday, December 6, 2022 8:55 PM
> > To: Wang, Xiao W <xiao.w.wang@intel.com>
> > Cc: dev@dpdk.org; stable@dpdk.org; Xia, Chenbo <chenbo.xia@intel.com>;
> > Mandal, Purna Chandra <purna.chandra.mandal@intel.com>; Maheshwari,
> > Abhishek <abhishek.maheshwari@intel.com>
> > Subject: [PATCH v2] vdpa/ifc: Match ANY subsystem IDs for modern
> > virtio devices
> >
> > Fixing the match table for vdpa/ifcvf driver because as per the Virtio
> > device specification, for modern virtio devices, drivers MAY match any
> > PCI Subsystem Vendor ID and any PCI Subsystem Device ID value.
>
> Here the "drivers" refers to virtio driver, not vdpa driver.
> With below change, this vdpa/ifc driver would hit the standard virtio device
> which can't 100% match this driver.
>
> >
> > Fixes: a60b747d0ad ("vdpa/ifc: support virtio block device")
> > Fixes: 5c806b94785 ("vdpa/ifc: add PCI ID for legacy network device")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Abhishek Maheshwari <abhishek.maheshwari@intel.com>
> > ---
> > drivers/vdpa/ifc/ifcvf_vdpa.c | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c
> > b/drivers/vdpa/ifc/ifcvf_vdpa.c index 49d68ad1b1..214d6e1f60 100644
> > --- a/drivers/vdpa/ifc/ifcvf_vdpa.c
> > +++ b/drivers/vdpa/ifc/ifcvf_vdpa.c
> > @@ -1824,8 +1824,8 @@ static const struct rte_pci_id pci_id_ifcvf_map[] = {
> > { .class_id = RTE_CLASS_ANY_ID,
> > .vendor_id = IFCVF_VENDOR_ID,
> > .device_id = IFCVF_NET_MODERN_DEVICE_ID,
> > - .subsystem_vendor_id = IFCVF_SUBSYS_VENDOR_ID,
> > - .subsystem_device_id = IFCVF_SUBSYS_DEVICE_ID,
> > + .subsystem_vendor_id = RTE_PCI_ANY_ID,
> > + .subsystem_device_id = RTE_PCI_ANY_ID,
> > },
> >
> > { .class_id = RTE_CLASS_ANY_ID,
> > @@ -1845,8 +1845,8 @@ static const struct rte_pci_id pci_id_ifcvf_map[] = {
> > { .class_id = RTE_CLASS_ANY_ID,
> > .vendor_id = IFCVF_VENDOR_ID,
> > .device_id = IFCVF_BLK_MODERN_DEVICE_ID,
> > - .subsystem_vendor_id = IFCVF_SUBSYS_VENDOR_ID,
> > - .subsystem_device_id = IFCVF_SUBSYS_BLK_DEVICE_ID,
> > + .subsystem_vendor_id = RTE_PCI_ANY_ID,
> > + .subsystem_device_id = RTE_PCI_ANY_ID,
> > },
> >
> > { .vendor_id = 0, /* sentinel */
> > --
> > 2.31.1
next prev parent reply other threads:[~2022-12-09 2:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-06 12:50 [PATCH] " Abhishek Maheshwari
2022-12-06 12:55 ` [PATCH v2] " Abhishek Maheshwari
2022-12-08 13:08 ` Wang, Xiao W
2022-12-09 2:37 ` Pei, Andy [this message]
2022-12-15 3:42 ` [PATCH v3] vdpa/ifc: Match default subsystem IDs for modern virtio-blk devices Abhishek Maheshwari
2022-12-15 3:48 ` [PATCH v4] " Abhishek Maheshwari
2022-12-16 1:58 ` Pei, Andy
2023-01-19 14:09 ` Maxime Coquelin
2023-02-03 14:57 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM5PR11MB17392C4BC12B17BD99BBA8928F1C9@DM5PR11MB1739.namprd11.prod.outlook.com \
--to=andy.pei@intel.com \
--cc=abhishek.maheshwari@intel.com \
--cc=chenbo.xia@intel.com \
--cc=dev@dpdk.org \
--cc=purna.chandra.mandal@intel.com \
--cc=stable@dpdk.org \
--cc=xiao.w.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).