From: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>
To: "Yigit, Ferruh" <ferruh.yigit@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/iavf: fix performance drop
Date: Thu, 29 Apr 2021 01:08:50 +0000 [thread overview]
Message-ID: <DM5PR11MB1787F3A13A2901EEE2B198FE8C5F9@DM5PR11MB1787.namprd11.prod.outlook.com> (raw)
In-Reply-To: <341c212e-e6d0-b0d5-da29-51862fe35348@intel.com>
> The fix by not changing Rx implementation, but making sure correct Rx path
> selected, right? Can you please clarify this in the commit log?
>
> So the performance drop fixed for whoever have the vector path supported and
> offloads enabled, can be good to highlight in the patch title, otherwise it is too
> generic.
Yes, the implementation is not changed. It's only about the path selection. I'll clarify it.
>
> >
> > Fixes: eff56a7b9f97 ("net/iavf: add offload path for Rx AVX512")
> >
>
> I am not clear what caused the performance drop.
> Before above patch, vector path was not supporting the offloads and scalar
> path should be selected. After above patch, still scalar path selected, although
> vector path supports offloads, but for both before and after scalar path is
> selected, so why/when the performance drop happens?
> Can you please clarify in the commit log, how to reproduce performance drop?
Sure. I'll describe more about what's the issue.
next prev parent reply other threads:[~2021-04-29 1:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-26 5:29 Wenzhuo Lu
2021-04-26 9:04 ` Zhang, Qi Z
2021-04-27 1:51 ` Lu, Wenzhuo
2021-04-27 2:57 ` Zhang, Qi Z
2021-04-27 5:09 ` Lu, Wenzhuo
2021-04-28 11:32 ` Ferruh Yigit
2021-04-28 12:06 ` Zhang, Qi Z
2021-04-27 5:19 ` Zhang, Qi Z
2021-04-28 11:32 ` Ferruh Yigit
2021-04-29 1:08 ` Lu, Wenzhuo [this message]
2021-04-29 1:33 ` Wenzhuo Lu
2021-04-29 3:20 ` Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM5PR11MB1787F3A13A2901EEE2B198FE8C5F9@DM5PR11MB1787.namprd11.prod.outlook.com \
--to=wenzhuo.lu@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).