From: Asaf Penso <asafp@nvidia.com>
To: Stephen Hemminger <stephen@networkplumber.org>,
"NBU-Contact-Thomas Monjalon (EXTERNAL)" <thomas@monjalon.net>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
Slava Ovsiienko <viacheslavo@nvidia.com>,
Matan Azrad <matan@nvidia.com>,
Raslan Darawsheh <rasland@nvidia.com>,
Michael Baum <michaelba@nvidia.com>
Subject: RE: [PATCH 1/1] doc: add steps to configure VF interface as trusted
Date: Mon, 28 Feb 2022 08:13:34 +0000 [thread overview]
Message-ID: <DM5PR1201MB2555BACCAAA4B23D6FF2FE6ECD019@DM5PR1201MB2555.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20220227102435.4275f945@hermes.local>
Thank you for the comment, Stephen.
I also saw you update the tool, which is why I didn't see the missing line.
I uploaded v3: http://patches.dpdk.org/project/dpdk/patch/20220228081117.3013452-1-asafp@nvidia.com/
Regards,
Asaf Penso
>-----Original Message-----
>From: Stephen Hemminger <stephen@networkplumber.org>
>Sent: Sunday, February 27, 2022 8:25 PM
>To: NBU-Contact-Thomas Monjalon (EXTERNAL) <thomas@monjalon.net>
>Cc: Asaf Penso <asafp@nvidia.com>; dev@dpdk.org; Slava Ovsiienko
><viacheslavo@nvidia.com>; Matan Azrad <matan@nvidia.com>; Raslan
>Darawsheh <rasland@nvidia.com>; Michael Baum <michaelba@nvidia.com>
>Subject: Re: [PATCH 1/1] doc: add steps to configure VF interface as trusted
>
>On Sun, 27 Feb 2022 18:24:42 +0100
>Thomas Monjalon <thomas@monjalon.net> wrote:
>
>> 27/02/2022 17:44, Stephen Hemminger:
>> > On Sun, 27 Feb 2022 17:46:17 +0200
>> > Asaf Penso <asafp@nvidia.com> wrote:
>> >
>> > > +#. For each VF PCIe, using the following command to bind the driver::
>> > > +
>> > > + $ echo "0000:82:00.2" >> /sys/bus/pci/drivers/mlx5_core/bind
>> > > \ No newline at end of file
>> >
>> > Please change your editor and/or git settings so there is a new line
>> > at the end of all text files.
>>
>> Isn't it a problem with Eclipse editor?
>
>It is a configuration option in almost all editors:
>
>Eclipse:
>https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww
>.newt.com%2Fjava%2Feclipse%2F&data=04%7C01%7Casafp%40nvidia.co
>m%7Cbd5c204df1c9488605ae08d9fa1e6adf%7C43083d15727340c1b7db39efd9
>ccc17a%7C0%7C0%7C637815831547239436%7CUnknown%7CTWFpbGZsb3d8e
>yJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D
>%7C2000&sdata=sutVpcYtoUmUX2TJmK8bWqTss4kefKYcu%2BLYTt%2B%
>2FrDk%3D&reserved=0
>
>Customize code formatting
>Go to Windows > Preferences > Java > Code Style > Code Formatter and click
>on the Edit button.
>
>Check New Lines > Insert new line at end of file
>
>https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fthou
>ghtbot.com%2Fblog%2Fno-newline-at-end-of-
>file&data=04%7C01%7Casafp%40nvidia.com%7Cbd5c204df1c9488605ae0
>8d9fa1e6adf%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0%7C63781583
>1547239436%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIj
>oiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C2000&sdata=dJuXju04
>tJauNDNRmj%2BXwcXykJQq2MgRbLNNtSaMgM4%3D&reserved=0
>
>Following the rules in your editor
>You can make sure you follow this rule easily:
>
>For Vim users, you're all set out of the box! Just don't change your eol setting.
>For Emacs users, add (setq require-final-newline t) to your .emacs or
>.emacs.d/init.el file.
>For Android Studio, RubyMine, PyCharm, and other IntelliJ, set "Ensure line
>feed at file end on Save" under "Editor."
>For Atom, you're also all set out of the box. Keep that via the Whitespace
>plugin.
>For VS Code, set "files.insertFinalNewline": true.
>For Sublime, set the ensure_newline_at_eof_on_save option to true.
>For TextMate, you can install the Avian Missing Bundle and add
>TM_STRIP_WHITESPACE_ON_SAVE = true to your .tm_properties file.
next prev parent reply other threads:[~2022-02-28 8:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-27 15:46 Asaf Penso
2022-02-27 16:44 ` Stephen Hemminger
2022-02-27 17:24 ` Thomas Monjalon
2022-02-27 18:24 ` Stephen Hemminger
2022-02-28 8:13 ` Asaf Penso [this message]
2022-02-28 7:39 ` [PATCH v2] " Asaf Penso
2022-02-28 8:09 ` Asaf Penso
2022-02-28 8:11 ` [PATCH v3] " Asaf Penso
2022-03-07 12:10 ` Raslan Darawsheh
2022-03-07 10:42 ` [PATCH v2] " Raslan Darawsheh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM5PR1201MB2555BACCAAA4B23D6FF2FE6ECD019@DM5PR1201MB2555.namprd12.prod.outlook.com \
--to=asafp@nvidia.com \
--cc=dev@dpdk.org \
--cc=matan@nvidia.com \
--cc=michaelba@nvidia.com \
--cc=rasland@nvidia.com \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).