From: Asaf Penso <asafp@nvidia.com>
To: "nipun.gupta@nxp.com" <nipun.gupta@nxp.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: NBU-Contact-Thomas Monjalon <thomas@monjalon.net>,
"ferruh.yigit@intel.com" <ferruh.yigit@intel.com>,
"arybchenko@solarflare.com" <arybchenko@solarflare.com>,
"hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>,
"sachin.saxena@nxp.com" <sachin.saxena@nxp.com>,
"rohit.raj@nxp.com" <rohit.raj@nxp.com>
Subject: Re: [dpdk-dev] [PATCH 3/3 v2] testpmd: support hardware offload to drop error packets
Date: Thu, 8 Oct 2020 15:06:23 +0000 [thread overview]
Message-ID: <DM5PR12MB24062C2D99223C0064931B2ECD0B0@DM5PR12MB2406.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20201005071506.28861-3-nipun.gupta@nxp.com>
>-----Original Message-----
>From: dev <dev-bounces@dpdk.org> On Behalf Of nipun.gupta@nxp.com
>Sent: Monday, October 5, 2020 10:15 AM
>To: dev@dpdk.org
>Cc: NBU-Contact-Thomas Monjalon <thomas@monjalon.net>;
>ferruh.yigit@intel.com; arybchenko@solarflare.com;
>hemant.agrawal@nxp.com; sachin.saxena@nxp.com; rohit.raj@nxp.com;
>Nipun Gupta <nipun.gupta@nxp.com>
>Subject: [dpdk-dev] [PATCH 3/3 v2] testpmd: support hardware offload to
>drop error packets
>
>From: Nipun Gupta <nipun.gupta@nxp.com>
>
>With DEV_RX_OFFLOAD_ERR_PKT_DROP now defined as an offload
>capability, testpmd showcases this with a new added configuration option
>'enable-hw-drop-err'.
>
>Signed-off-by: Nipun Gupta <nipun.gupta@nxp.com>
>---
> app/test-pmd/parameters.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
>diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c index
>1ead59579..ada870e2d 100644
>--- a/app/test-pmd/parameters.c
>+++ b/app/test-pmd/parameters.c
>@@ -142,6 +142,7 @@ usage(char* progname)
> printf(" --enable-hw-vlan-strip: enable hardware vlan strip.\n");
> printf(" --enable-hw-vlan-extend: enable hardware vlan extend.\n");
> printf(" --enable-hw-qinq-strip: enable hardware qinq strip.\n");
>+ printf(" --enable-hw-drop-err: enable hardware packet drop for error
>+packets.\n");
> printf(" --enable-drop-en: enable per queue packet drop.\n");
> printf(" --disable-rss: disable rss.\n");
> printf(" --port-topology=<paired|chained|loop>: set port topology
>(paired "
>@@ -631,6 +632,7 @@ launch_args_parse(int argc, char** argv)
> { "enable-hw-vlan-strip", 0, 0, 0 },
> { "enable-hw-vlan-extend", 0, 0, 0 },
> { "enable-hw-qinq-strip", 0, 0, 0 },
>+ { "enable-hw-drop-err", 0, 0, 0 },
> { "enable-drop-en", 0, 0, 0 },
> { "disable-rss", 0, 0, 0 },
> { "port-topology", 1, 0, 0 },
>@@ -1037,6 +1039,9 @@ launch_args_parse(int argc, char** argv)
> "enable-hw-qinq-strip"))
> rx_offloads |=
>DEV_RX_OFFLOAD_QINQ_STRIP;
>
>+ if (!strcmp(lgopts[opt_idx].name, "enable-hw-drop-
>err"))
>+ rx_offloads |=
>DEV_RX_OFFLOAD_ERR_PKT_DROP;
>+
> if (!strcmp(lgopts[opt_idx].name, "enable-drop-en"))
> rx_drop_en = 1;
>
>--
>2.17.1
I think it would be good also to update testpmd run_app.rst with this new option.
next prev parent reply other threads:[~2020-10-08 15:06 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-31 7:53 [dpdk-dev] [PATCH] ethdev: add rx " Nipun Gupta
2020-08-31 12:58 ` Ferruh Yigit
2020-08-31 16:04 ` Nipun Gupta
2020-08-31 17:00 ` Stephen Hemminger
2020-09-01 8:09 ` Thomas Monjalon
2020-09-01 10:56 ` Nipun Gupta
2020-09-21 7:29 ` Ori Kam
2020-10-05 7:15 ` [dpdk-dev] [PATCH 1/3 v2] " nipun.gupta
2020-10-05 7:15 ` [dpdk-dev] [PATCH 2/3 v2] net/dpaa: support RX offload for error packet drop nipun.gupta
2020-10-05 7:15 ` [dpdk-dev] [PATCH 3/3 v2] testpmd: support hardware offload to drop error packets nipun.gupta
2020-10-08 15:06 ` Asaf Penso [this message]
2020-10-08 15:45 ` Nipun Gupta
2020-10-05 15:34 ` [dpdk-dev] [PATCH 1/3 v2] ethdev: add rx " Stephen Hemminger
2020-10-05 16:10 ` Jerin Jacob
2020-10-06 10:37 ` Nipun Gupta
2020-10-06 12:01 ` Jerin Jacob
2020-10-06 13:10 ` Nipun Gupta
2020-10-06 13:13 ` Jerin Jacob
2020-10-08 8:53 ` Nipun Gupta
2020-10-08 8:55 ` Jerin Jacob
2020-10-08 15:13 ` Asaf Penso
2020-10-09 13:13 ` [dpdk-dev] [PATCH 1/3 v3] " nipun.gupta
2020-10-09 13:13 ` [dpdk-dev] [PATCH 2/3 v3] net/dpaa: support RX offload for error packet drop nipun.gupta
2020-10-09 13:13 ` [dpdk-dev] [PATCH 3/3 v3] app/testpmd: support hardware offload to drop error packets nipun.gupta
2020-10-11 7:22 ` Asaf Penso
2020-10-11 10:13 ` [dpdk-dev] [PATCH 1/3 v3] ethdev: add rx " Jerin Jacob
2020-10-11 21:41 ` Thomas Monjalon
2020-10-12 5:40 ` Nipun Gupta
2020-10-13 7:22 ` Nipun Gupta
2020-10-12 8:01 ` Andrew Rybchenko
2020-10-12 11:30 ` Nipun Gupta
2020-10-12 12:22 ` Andrew Rybchenko
2020-10-12 12:53 ` Nipun Gupta
2020-10-13 7:21 ` Andrew Rybchenko
2020-10-13 7:36 ` Nipun Gupta
2020-10-13 7:51 ` Andrew Rybchenko
2020-10-13 8:12 ` Nipun Gupta
2020-10-15 13:23 ` [dpdk-dev] [PATCH 1/3 v4] ethdev: add Rx " nipun.gupta
2020-10-15 13:23 ` [dpdk-dev] [PATCH 2/3 v4] net/dpaa: support Rx offload for error packet drop nipun.gupta
2020-10-15 13:23 ` [dpdk-dev] [PATCH 3/3 v4] app/testpmd: support hardware offload to drop error packets nipun.gupta
2020-10-29 17:22 ` Dharmik Thakkar
2020-10-31 18:16 ` Nipun Gupta
2020-10-19 3:30 ` [dpdk-dev] [PATCH 1/3 v4] ethdev: add Rx " Ajit Khaparde
2021-02-18 20:32 ` Ferruh Yigit
2021-02-18 20:37 ` Thomas Monjalon
2021-04-20 1:11 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM5PR12MB24062C2D99223C0064931B2ECD0B0@DM5PR12MB2406.namprd12.prod.outlook.com \
--to=asafp@nvidia.com \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=hemant.agrawal@nxp.com \
--cc=nipun.gupta@nxp.com \
--cc=rohit.raj@nxp.com \
--cc=sachin.saxena@nxp.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).