From: Liron Himi <lironh@marvell.com>
To: Li Zhang <lizh@nvidia.com>,
"dekelp@nvidia.com" <dekelp@nvidia.com>,
"orika@nvidia.com" <orika@nvidia.com>,
"viacheslavo@nvidia.com" <viacheslavo@nvidia.com>,
"matan@nvidia.com" <matan@nvidia.com>,
"shahafs@nvidia.com" <shahafs@nvidia.com>,
"cristian.dumitrescu@intel.com" <cristian.dumitrescu@intel.com>,
Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
"ferruh.yigit@intel.com" <ferruh.yigit@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"thomas@monjalon.net" <thomas@monjalon.net>,
"rasland@nvidia.com" <rasland@nvidia.com>,
"roniba@nvidia.com" <roniba@nvidia.com>,
Liron Himi <lironh@marvell.com>
Subject: Re: [dpdk-dev] [EXT] [PATCH v4 4/4] net/mvpp2: check meter packet mode
Date: Tue, 13 Apr 2021 05:42:47 +0000 [thread overview]
Message-ID: <DM5PR18MB22143288E0011655F572C91FC64F9@DM5PR18MB2214.namprd18.prod.outlook.com> (raw)
In-Reply-To: <20210413035046.28578-5-lizh@nvidia.com>
Acked-by: Liron Himi <lironh@marvell.com>
-----Original Message-----
From: Li Zhang <lizh@nvidia.com>
Sent: Tuesday, 13 April 2021 06:51
To: dekelp@nvidia.com; orika@nvidia.com; viacheslavo@nvidia.com; matan@nvidia.com; shahafs@nvidia.com; cristian.dumitrescu@intel.com; Liron Himi <lironh@marvell.com>; Jerin Jacob Kollanukkaran <jerinj@marvell.com>; ferruh.yigit@intel.com
Cc: dev@dpdk.org; thomas@monjalon.net; rasland@nvidia.com; roniba@nvidia.com
Subject: [EXT] [PATCH v4 4/4] net/mvpp2: check meter packet mode
External Email
----------------------------------------------------------------------
Currently meter algorithms only supports bytes per second(BPS).
Check packet_mode set to TRUE are rejected.
Signed-off-by: Li Zhang <lizh@nvidia.com>
Acked-by: Matan Azrad <matan@nvidia.com>
---
drivers/net/mvpp2/mrvl_mtr.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/net/mvpp2/mrvl_mtr.c b/drivers/net/mvpp2/mrvl_mtr.c index 2fa5cb43ad..c07ac95ddc 100644
--- a/drivers/net/mvpp2/mrvl_mtr.c
+++ b/drivers/net/mvpp2/mrvl_mtr.c
@@ -88,6 +88,12 @@ mrvl_meter_profile_add(struct rte_eth_dev *dev, uint32_t meter_profile_id,
NULL,
"Only srTCM RFC 2697 is supported\n");
+ if (profile->packet_mode)
+ return -rte_mtr_error_set(error, EINVAL,
+ RTE_MTR_ERROR_TYPE_METER_PROFILE_PACKET_MODE,
+ NULL,
+ "Packet mode is not supported\n");
+
prof = mrvl_mtr_profile_from_id(priv, meter_profile_id);
if (prof)
return -rte_mtr_error_set(error, EEXIST,
--
2.27.0
next prev parent reply other threads:[~2021-04-13 5:42 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-31 8:54 [dpdk-dev] [PATCH 0/2] Support PPS(packet per second) on meter Li Zhang
2021-03-31 8:54 ` [dpdk-dev] [PATCH 1/2] ethdev: add packet mode in meter profile structure Li Zhang
2021-03-31 16:26 ` Dumitrescu, Cristian
2021-04-01 1:41 ` Li Zhang
2021-04-01 6:19 ` Li Zhang
2021-04-07 20:20 ` Dumitrescu, Cristian
2021-04-08 4:06 ` Li Zhang
2021-03-31 8:54 ` [dpdk-dev] [PATCH 2/2] app/testpmd: add meter profile packet mode option Li Zhang
2021-04-07 20:17 ` Dumitrescu, Cristian
2021-04-08 2:34 ` Li Zhang
2021-04-07 20:21 ` Dumitrescu, Cristian
2021-04-08 3:58 ` [dpdk-dev] [PATCH v2 0/4] Support PPS(packet per second) on meter Li Zhang
2021-04-08 3:58 ` [dpdk-dev] [PATCH v2 1/4] ethdev: add packet mode in meter profile structure Li Zhang
2021-04-08 3:58 ` [dpdk-dev] [PATCH v2 2/4] app/testpmd: add meter profile packet mode option Li Zhang
2021-04-08 3:58 ` [dpdk-dev] [PATCH v2 3/4] net/softnic: check meter packet mode Li Zhang
2021-04-08 3:58 ` [dpdk-dev] [PATCH v2 4/4] net/mvpp2: " Li Zhang
2021-04-10 7:24 ` [dpdk-dev] [PATCH v3 0/4] Support PPS(packet per second) on meter Li Zhang
2021-04-10 7:24 ` [dpdk-dev] [PATCH v3 1/4] ethdev: add packet mode in meter profile structure Li Zhang
2021-04-12 19:23 ` Dumitrescu, Cristian
2021-04-12 19:28 ` Jerin Jacob
2021-04-13 3:48 ` Ajit Khaparde
2021-04-10 7:24 ` [dpdk-dev] [PATCH v3 2/4] app/testpmd: add meter profile packet mode option Li Zhang
2021-04-12 23:51 ` Ferruh Yigit
2021-04-13 2:57 ` Li Zhang
2021-04-10 7:24 ` [dpdk-dev] [PATCH v3 3/4] net/softnic: check meter packet mode Li Zhang
2021-04-12 19:24 ` Dumitrescu, Cristian
2021-04-10 7:24 ` [dpdk-dev] [PATCH v3 4/4] net/mvpp2: " Li Zhang
2021-04-12 23:54 ` [dpdk-dev] [PATCH v3 0/4] Support PPS(packet per second) on meter Ferruh Yigit
2021-04-13 2:53 ` Li Zhang
2021-04-13 3:50 ` [dpdk-dev] [PATCH v4 " Li Zhang
2021-04-13 3:50 ` [dpdk-dev] [PATCH v4 1/4] ethdev: add packet mode in meter profile structure Li Zhang
2021-04-13 3:50 ` [dpdk-dev] [PATCH v4 2/4] app/testpmd: add meter profile packet mode option Li Zhang
2021-04-13 3:50 ` [dpdk-dev] [PATCH v4 3/4] net/softnic: check meter packet mode Li Zhang
2021-04-13 3:50 ` [dpdk-dev] [PATCH v4 4/4] net/mvpp2: " Li Zhang
2021-04-13 5:42 ` Liron Himi [this message]
2021-04-13 10:24 ` [dpdk-dev] [PATCH v4 0/4] Support PPS(packet per second) on meter Ferruh Yigit
2021-04-13 11:02 ` Li Zhang
2021-04-13 11:05 ` Ferruh Yigit
2021-04-13 15:46 ` Li Zhang
2021-04-13 15:59 ` [dpdk-dev] [PATCH v5 " Li Zhang
2021-04-13 15:59 ` [dpdk-dev] [PATCH v5 1/4] ethdev: add packet mode in meter profile structure Li Zhang
2021-04-17 22:35 ` Thomas Monjalon
2021-04-13 15:59 ` [dpdk-dev] [PATCH v5 2/4] app/testpmd: add meter profile packet mode option Li Zhang
2021-04-13 16:09 ` Ajit Khaparde
2021-04-13 15:59 ` [dpdk-dev] [PATCH v5 3/4] net/softnic: check meter packet mode Li Zhang
2021-04-13 15:59 ` [dpdk-dev] [PATCH v5 4/4] net/mvpp2: " Li Zhang
2021-04-13 18:39 ` [dpdk-dev] [PATCH v5 0/4] Support PPS(packet per second) on meter Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM5PR18MB22143288E0011655F572C91FC64F9@DM5PR18MB2214.namprd18.prod.outlook.com \
--to=lironh@marvell.com \
--cc=cristian.dumitrescu@intel.com \
--cc=dekelp@nvidia.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jerinj@marvell.com \
--cc=lizh@nvidia.com \
--cc=matan@nvidia.com \
--cc=orika@nvidia.com \
--cc=rasland@nvidia.com \
--cc=roniba@nvidia.com \
--cc=shahafs@nvidia.com \
--cc=thomas@monjalon.net \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).