From: Vipin P R <vipinp@vmware.com>
To: "Zhang, Qi Z" <qi.z.zhang@intel.com>,
"Wu, Jingjing" <jingjing.wu@intel.com>,
"Xing, Beilei" <beilei.xing@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [PATCH] Intel iavf: Return in the case of ADD/DEL ETH address
Date: Tue, 7 Feb 2023 10:42:54 +0000 [thread overview]
Message-ID: <DM6PR05MB5577F9DF1A03D0E4722097A1B7DB9@DM6PR05MB5577.namprd05.prod.outlook.com> (raw)
In-Reply-To: <DM4PR11MB59946CDC0C56EC817CBA259FD7C69@DM4PR11MB5994.namprd11.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 2837 bytes --]
________________________________
From: Zhang, Qi Z <qi.z.zhang@intel.com>
Sent: 17 January 2023 07:24
To: Vipin P R <vipinp@vmware.com>; Wu, Jingjing <jingjing.wu@intel.com>; Xing, Beilei <beilei.xing@intel.com>
Cc: dev@dpdk.org <dev@dpdk.org>; stable@dpdk.org <stable@dpdk.org>
Subject: RE: [PATCH] Intel iavf: Return in the case of ADD/DEL ETH address
!! External Email
> -----Original Message-----
> From: Vipin P R <vipinp@vmware.com>
> Sent: Friday, January 13, 2023 9:19 PM
> To: Wu, Jingjing <jingjing.wu@intel.com>; Xing, Beilei <beilei.xing@intel.com>
> Cc: dev@dpdk.org; Vipin P R <vipinp@vmware.com>; stable@dpdk.org
> Subject: [PATCH] Intel iavf: Return in the case of ADD/DEL ETH address
>
> In case of i40vf, VIRTCHNL_OP_DEL_ETH_ADDR and
> VIRTCHNL_OP_ADD_ETH_ADDR are unsupported.
> i40evf_execute_vf_cmd is invoked with these operations as part of
> i40evf_set_mc_addr_list()
>
> The cases are not handled in i40evf_execute_vf_cmd() thus hitting the
> default case.
> There is a retry logic of upto 200 times (2000 in iavf) with a delay of 10ms (1ms
> in iavf).
> This results in a needless delay of 2s in the init phase for each VNIC.
>
Sorry I didn't get this, why this is related with i40evf? I40evf PMD has been replaced by iavf PMD.
The iavf PMD works with both i40e and ice, does this will break ice's usage?
Hi, this is problem was discovered while using i40vf (which was deprecated and replaced by iavf). Upon inspecting the code, this problem would also be hit in iavf, if the VIRTCHNL_OP_DEL_ETH_ADDR and VIRTCHNL_OP_ADD_ETH_ADDR are not supported.
> The patch aims to rectify that delay.
> In fe2a571c70cc397f2ad4e280f8d084148fea5d62, i40e_ethdev_vf.c was
> deleted. Hence adding this in iavf_vchnl.c.
>
> Cc: stable@dpdk.org
>
> Signed-off-by: Vipin P R <vipinp@vmware.com>
> ---
> drivers/net/iavf/iavf_vchnl.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/net/iavf/iavf_vchnl.c b/drivers/net/iavf/iavf_vchnl.c index
> f92daf9..e2f65f5 100644
> --- a/drivers/net/iavf/iavf_vchnl.c
> +++ b/drivers/net/iavf/iavf_vchnl.c
> @@ -367,6 +367,14 @@ iavf_execute_vf_cmd(struct iavf_adapter *adapter,
> struct iavf_cmd_info *args,
> }
> _clear_cmd(vf);
> break;
> +
> + case VIRTCHNL_OP_ADD_ETH_ADDR:
> + case VIRTCHNL_OP_DEL_ETH_ADDR:
> + PMD_DRV_LOG(WARNING, "OP_{ADD/DEL}_ETH_ADDR
> unsupported");
> + err = 0;
> + _clear_cmd(vf);
> + break;
> +
> default:
> /* For other virtchnl ops in running time,
> * wait for the cmd done flag.
> --
> 2.7.4
!! External Email: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender.
[-- Attachment #2: Type: text/html, Size: 6137 bytes --]
next prev parent reply other threads:[~2023-02-13 14:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1673615963-21216-1-git-send-email-vipinp@vmware.com>
[not found] ` <1673615963-21216-2-git-send-email-vipinp@vmware.com>
2023-01-16 17:55 ` Stephen Hemminger
2023-01-17 1:54 ` Zhang, Qi Z
2023-02-07 10:42 ` Vipin P R [this message]
2023-02-13 1:31 ` Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR05MB5577F9DF1A03D0E4722097A1B7DB9@DM6PR05MB5577.namprd05.prod.outlook.com \
--to=vipinp@vmware.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).