From: "Hyong Youb Kim (hyonkim)" <hyonkim@cisco.com>
To: dirk <dirk.lenz@ng4t.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 1/1] net/enic: enic driver doesn't work with 2nd process
Date: Mon, 2 Sep 2019 06:40:18 +0000 [thread overview]
Message-ID: <DM6PR11MB27458DCEE47F47798309EC0DBFBE0@DM6PR11MB2745.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20190827090248.6185-2-dirk.lenz@ng4t.com>
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of dirk
> Sent: Tuesday, August 27, 2019 6:03 PM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH 1/1] net/enic: enic driver doesn't work with 2nd
> process
>
> net/enic: enic driver doesn't work with 2nd process. the problem is that the
> private data structure enic uses pointers to rte_eth_dev and rte_pci_device
> which are overwritten when a 2nd process starts using this device.
> given patch removes these two pointers from the private data and uses the
> correct pointers. For us the given patch works fine on a cisco rack.
> (we used three processes working concurrently)
>
> Signed-off-by: dirk <dirk.lenz@ng4t.com>
> ---
> drivers/net/enic/enic.h | 36 ++++---
> drivers/net/enic/enic_clsf.c | 5 +-
> drivers/net/enic/enic_ethdev.c | 79 ++++++---------
> drivers/net/enic/enic_main.c | 177 +++++++++++++++++++--------------
> -
> drivers/net/enic/enic_res.c | 7 +-
> drivers/net/enic/enic_res.h | 6 +-
> drivers/net/enic/enic_rxtx_vec_avx2.c | 5 +-
> 7 files changed, 156 insertions(+), 159 deletions(-)
>
Hi,
Thanks for the patch and reporting the bug!
Yes, enic->rte_dev and enic->pdev are supposed to be set and used only
by the primary. I can reproduce the crash by running two different
executables as primary and secondary. Using different executables so
that primary and secondary processes load rte_eth_devices at different
addresses.
I see other related issues including...
- eth_enicpmd_dev_init overwriting primary's fields in struct enic,
other than rte_dev and pdev.
- Secondary not setting optimal rx/tx handlers.
- RSS update handlers (e.g. rss_hash_update) not checking for primary
I will send a patch series with Reported-by: Dirk Lenz. And you can
try it out and add Tested-by on that series. Are you okay with this
plan? Did I get your name right?
Thanks a lot.
-Hyong
next prev parent reply other threads:[~2019-09-02 6:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-27 9:02 [dpdk-dev] [PATCH 0/1] " dirk
2019-08-27 9:02 ` [dpdk-dev] [PATCH 1/1] " dirk
2019-09-02 6:40 ` Hyong Youb Kim (hyonkim) [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-08-27 8:33 [dpdk-dev] [PATCH 0/1] " dirk
2019-08-27 8:33 ` [dpdk-dev] [PATCH 1/1] " dirk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR11MB27458DCEE47F47798309EC0DBFBE0@DM6PR11MB2745.namprd11.prod.outlook.com \
--to=hyonkim@cisco.com \
--cc=dev@dpdk.org \
--cc=dirk.lenz@ng4t.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).