From: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>,
"Khangar, Churchill" <churchill.khangar@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"P, Venkata Suresh Kumar" <venkata.suresh.kumar.p@intel.com>,
"Jangra, Yogesh" <yogesh.jangra@intel.com>
Subject: Re: [dpdk-dev] [PATCH] examples/pipeline: fix strtoul base
Date: Wed, 24 Mar 2021 10:41:15 +0000 [thread overview]
Message-ID: <DM6PR11MB279661E447BE3B643A6F7101EB639@DM6PR11MB2796.namprd11.prod.outlook.com> (raw)
In-Reply-To: <5778056.E573L7TWGz@thomas>
> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Wednesday, March 24, 2021 9:05 AM
> To: Khangar, Churchill <churchill.khangar@intel.com>
> Cc: dev@dpdk.org; Dumitrescu, Cristian <cristian.dumitrescu@intel.com>; P,
> Venkata Suresh Kumar <venkata.suresh.kumar.p@intel.com>; Jangra,
> Yogesh <yogesh.jangra@intel.com>
> Subject: Re: [dpdk-dev] [PATCH] examples/pipeline: fix strtoul base
>
> 05/03/2021 16:15, Churchill Khangar:
> > This patch addresses the issue with strtoul base
>
> Which issue?
> Please explain what is broken and how it is fixed.
>
>
Nothing is broken here, this is incorrectly labeled as a fix. This is simply an small improvement to allow specification of integer arguments for the CLI commands in hexadecimal ( and octal :) ) as well as decimal, as opposed to just decimal.
Churchill, it would be great if you could update the title and description to reflect this as opposed to claiming a fix, and send v2, thanks!
Regards,
Cristian
next prev parent reply other threads:[~2021-03-24 10:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-05 15:15 Churchill Khangar
2021-03-24 9:05 ` Thomas Monjalon
2021-03-24 10:41 ` Dumitrescu, Cristian [this message]
2021-03-24 12:22 ` [dpdk-dev] [PATCH v2] examples/pipeline: support CLI hex args Churchill Khangar
2021-03-24 12:31 ` David Marchand
2021-03-24 12:52 ` Dumitrescu, Cristian
2021-03-24 17:25 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR11MB279661E447BE3B643A6F7101EB639@DM6PR11MB2796.namprd11.prod.outlook.com \
--to=cristian.dumitrescu@intel.com \
--cc=churchill.khangar@intel.com \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
--cc=venkata.suresh.kumar.p@intel.com \
--cc=yogesh.jangra@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).