From: "Iremonger, Bernard" <bernard.iremonger@intel.com>
To: Kevin Traynor <ktraynor@redhat.com>,
"Kinsella, Ray" <ray.kinsella@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] flow_classify: remove eperimental tag from the API
Date: Wed, 22 Sep 2021 16:12:41 +0000 [thread overview]
Message-ID: <DM6PR11MB2890AC98116FEE129600F4A9EFA29@DM6PR11MB2890.namprd11.prod.outlook.com> (raw)
In-Reply-To: <a5e74b88-9821-a05a-5c56-6aa3054abbe6@redhat.com>
Hi Kevin,
> -----Original Message-----
> From: Kevin Traynor <ktraynor@redhat.com>
> Sent: Wednesday, September 22, 2021 3:48 PM
> To: Iremonger, Bernard <bernard.iremonger@intel.com>; Kinsella, Ray
> <ray.kinsella@intel.com>; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] flow_classify: remove eperimental tag from
> the API
>
> s/eperimental/experimental/
>
> On 15/09/2021 16:16, Bernard Iremonger wrote:
> > This API was introduced in 17.11, removing experimental tag to promote
> > to stable state.
> >
> > Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com>
> > ---
> > lib/flow_classify/rte_flow_classify.h | 7 -------
> > lib/flow_classify/version.map | 2 +-
> > 2 files changed, 1 insertion(+), 8 deletions(-)
> >
>
> The library is still listed as experimental
> https://git.dpdk.org/dpdk/tree/lib/flow_classify/rte_flow_classify.h#n13
>
> and you can remove the allow_experimental_apis from the example app
> now.
Good catch.
I will remove allow_experimental_apis from the flow_classify/meson.build file.
> > diff --git a/lib/flow_classify/rte_flow_classify.h
> > b/lib/flow_classify/rte_flow_classify.h
> > index 82ea92b6a6..3759cd32af 100644
> > --- a/lib/flow_classify/rte_flow_classify.h
> > +++ b/lib/flow_classify/rte_flow_classify.h
> > @@ -157,7 +157,6 @@ struct rte_flow_classify_ipv4_5tuple_stats {
> > * @return
> > * Handle to flow classifier instance on success or NULL otherwise
> > */
> > -__rte_experimental
> > struct rte_flow_classifier *
> > rte_flow_classifier_create(struct rte_flow_classifier_params
> > *params);
> >
> > @@ -169,7 +168,6 @@ rte_flow_classifier_create(struct
> rte_flow_classifier_params *params);
> > * @return
> > * 0 on success, error code otherwise
> > */
> > -__rte_experimental
> > int
> > rte_flow_classifier_free(struct rte_flow_classifier *cls);
> >
> > @@ -183,7 +181,6 @@ rte_flow_classifier_free(struct rte_flow_classifier
> *cls);
> > * @return
> > * 0 on success, error code otherwise
> > */
> > -__rte_experimental
> > int
> > rte_flow_classify_table_create(struct rte_flow_classifier *cls,
> > struct rte_flow_classify_table_params *params); @@ -205,7
> +202,6
> > @@ rte_flow_classify_table_create(struct rte_flow_classifier *cls,
> > * @return
> > * 0 on success, error code otherwise
> > */
> > -__rte_experimental
> > int
> > rte_flow_classify_validate(struct rte_flow_classifier *cls,
> > const struct rte_flow_attr *attr,
> > @@ -232,7 +228,6 @@ rte_flow_classify_validate(struct rte_flow_classifier
> *cls,
> > * @return
> > * A valid handle in case of success, NULL otherwise.
> > */
> > -__rte_experimental
> > struct rte_flow_classify_rule *
> > rte_flow_classify_table_entry_add(struct rte_flow_classifier *cls,
> > const struct rte_flow_attr *attr,
> > @@ -251,7 +246,6 @@ rte_flow_classify_table_entry_add(struct
> rte_flow_classifier *cls,
> > * @return
> > * 0 on success, error code otherwise.
> > */
> > -__rte_experimental
> > int
> > rte_flow_classify_table_entry_delete(struct rte_flow_classifier *cls,
> > struct rte_flow_classify_rule *rule); @@ -273,7 +267,6 @@
> > rte_flow_classify_table_entry_delete(struct rte_flow_classifier *cls,
> > * @return
> > * 0 on success, error code otherwise.
> > */
> > -__rte_experimental
> > int
> > rte_flow_classifier_query(struct rte_flow_classifier *cls,
> > struct rte_mbuf **pkts,
> > diff --git a/lib/flow_classify/version.map
> > b/lib/flow_classify/version.map index 49bc25c6a0..b7a888053b 100644
> > --- a/lib/flow_classify/version.map
> > +++ b/lib/flow_classify/version.map
> > @@ -1,4 +1,4 @@
> > -EXPERIMENTAL {
> > +DPDK_22 {
> > global:
> >
> > rte_flow_classifier_create;
> >
Regards,
Bernard.
next prev parent reply other threads:[~2021-09-22 16:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-15 15:16 Bernard Iremonger
2021-09-22 14:47 ` Kevin Traynor
2021-09-22 16:12 ` Iremonger, Bernard [this message]
2021-09-22 16:48 ` [dpdk-dev] [PATCH v2] " Bernard Iremonger
2021-09-23 10:09 ` Kevin Traynor
2023-06-30 21:56 ` [dpdk-dev] [PATCH] " Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR11MB2890AC98116FEE129600F4A9EFA29@DM6PR11MB2890.namprd11.prod.outlook.com \
--to=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=ktraynor@redhat.com \
--cc=ray.kinsella@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).