test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Chen, BoX C" <box.c.chen@intel.com>
To: "Pattan, Reshma" <reshma.pattan@intel.com>,
	"Tu, Lijuan" <lijuan.tu@intel.com>
Cc: "Sikora, ZbigniewX" <zbigniewx.sikora@intel.com>,
	"dts@dpdk.org" <dts@dpdk.org>
Subject: Re: [dts] [PATCH] framework: enhance regex for DPDK apps build
Date: Fri, 16 Apr 2021 01:48:23 +0000	[thread overview]
Message-ID: <DM6PR11MB30991B8E4047A0894E1B7096D94C9@DM6PR11MB3099.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20210415120424.17800-1-reshma.pattan@intel.com>

Hi Pattan,

Regards,
Chen Bo

> -----Original Message-----
> From: Pattan, Reshma <reshma.pattan@intel.com>
> Sent: April 15, 2021 20:04
> To: dts@dpdk.org
> Cc: Pattan, Reshma <reshma.pattan@intel.com>; Chen, BoX C
> <box.c.chen@intel.com>; Sikora, ZbigniewX <zbigniewx.sikora@intel.com>
> Subject: [dts][PATCH] framework: enhance regex for DPDK apps build
> 
> The below patch added regex enhancements to match latest DPDK build
> output which contains '#'. But the patch missed to make same change at
> another place.
> https://git.dpdk.org/tools/dts/commit/?id=18c537316341ed2ec440b659835f4
> 0143ceba8b7
> 
> So, this patch extended the same fix to another place in "build_dpdk_apps"
> method.
> 

The fix patch has been submited, thank you very much for your attention.
http://mails.dpdk.org/archives/dts/2021-April/013219.html


> CC: BoX.C.Chen@intel.com
> CC: ZbigniewX.Sikora@intel.com
> 
> Signed-off-by: Sikora ZbigniewX <ZbigniewX.Sikora@intel.com>
> Signed-off-by: Reshma Pattan <reshma.pattan@intel.com>
> ---
>  framework/project_dpdk.py | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/framework/project_dpdk.py b/framework/project_dpdk.py
> index 0edb38a6..95efad64 100644
> --- a/framework/project_dpdk.py
> +++ b/framework/project_dpdk.py
> @@ -576,9 +576,9 @@ class DPDKdut(Dut):
>              example = 'all'
>          else:
>              example = '/'.join(folder_info[folder_info.index('examples')+1:])
> -        out = self.send_expect("meson configure -Dexamples=%s %s" %
> (example, self.target), "# ")
> +        out = self.send_expect("meson configure -Dexamples=%s %s" %
> + (example, self.target), "[~|~\]]# ")
>          assert ("FAILED" not in out), "Compilation error..."
> -        out = self.send_expect("ninja -C %s" % self.target, "# ", timeout)
> +        out = self.send_expect("ninja -C %s" % self.target, "[~|~\]]#
> + ", timeout)
>          assert ("FAILED" not in out), "Compilation error..."
> 
>          # verify the app build in the config path
> --
> 2.17.1


  reply	other threads:[~2021-04-16  1:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-15 12:04 Reshma Pattan
2021-04-16  1:48 ` Chen, BoX C [this message]
2021-04-20 11:54   ` Pattan, Reshma

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM6PR11MB30991B8E4047A0894E1B7096D94C9@DM6PR11MB3099.namprd11.prod.outlook.com \
    --to=box.c.chen@intel.com \
    --cc=dts@dpdk.org \
    --cc=lijuan.tu@intel.com \
    --cc=reshma.pattan@intel.com \
    --cc=zbigniewx.sikora@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).