From: "Naga Harish K, S V" <s.v.naga.harish.k@intel.com>
To: "Kundapura, Ganapati" <ganapati.kundapura@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"jerinj@marvell.com" <jerinj@marvell.com>,
"Jayatheerthan, Jay" <jay.jayatheerthan@intel.com>
Subject: RE: [PATCH v8 2/7] eventdev/eth_rx: add telemetry callback for instance get
Date: Wed, 22 Jun 2022 17:29:38 +0000 [thread overview]
Message-ID: <DM6PR11MB38687B389E955347132D44BCA1B29@DM6PR11MB3868.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20220622165405.533042-2-ganapati.kundapura@intel.com>
Reviewed-by: Naga Harish K S V <s.v.naga.harish.k@intel.com>
> -----Original Message-----
> From: Kundapura, Ganapati <ganapati.kundapura@intel.com>
> Sent: Wednesday, June 22, 2022 10:24 PM
> To: dev@dpdk.org; jerinj@marvell.com; Jayatheerthan, Jay
> <jay.jayatheerthan@intel.com>; Naga Harish K, S V
> <s.v.naga.harish.k@intel.com>
> Subject: [PATCH v8 2/7] eventdev/eth_rx: add telemetry callback for
> instance get
>
> Added telemetry handler for rte_event_eth_rx_adapter_instance_get()
> to retrieve adapter instance id for specified ethernet device id and rx queue
> index.
>
> Signed-off-by: Ganapati Kundapura <ganapati.kundapura@intel.com>
> ---
> lib/eventdev/rte_event_eth_rx_adapter.c | 66
> +++++++++++++++++++++++++++++++++
> 1 file changed, 66 insertions(+)
>
> diff --git a/lib/eventdev/rte_event_eth_rx_adapter.c
> b/lib/eventdev/rte_event_eth_rx_adapter.c
> index ababe13..64a6add 100644
> --- a/lib/eventdev/rte_event_eth_rx_adapter.c
> +++ b/lib/eventdev/rte_event_eth_rx_adapter.c
> @@ -3674,6 +3674,68 @@ handle_rxa_queue_stats_reset(const char *cmd
> __rte_unused,
> return ret;
> }
>
> +static int
> +handle_rxa_instance_get(const char *cmd __rte_unused,
> + const char *params,
> + struct rte_tel_data *d)
> +{
> + uint8_t instance_id;
> + uint16_t rx_queue_id;
> + int eth_dev_id, ret = -1;
> + char *token, *l_params;
> +
> + if (params == NULL || strlen(params) == 0 || !isdigit(*params))
> + return -1;
> +
> + l_params = strdup(params);
> + if (l_params == NULL)
> + return -ENOMEM;
> + token = strtok(l_params, ",");
> +
> RTE_EVENT_ETH_RX_ADAPTER_TOKEN_VALID_OR_GOTO_ERR_RET(
> token, -1);
> +
> + /* Get device ID from parameter string */
> + eth_dev_id = strtoul(token, NULL, 10);
> + RTE_ETH_VALID_PORTID_OR_GOTO_ERR_RET(eth_dev_id, -
> EINVAL);
> +
> + token = strtok(NULL, ",");
> +
> RTE_EVENT_ETH_RX_ADAPTER_TOKEN_VALID_OR_GOTO_ERR_RET(
> token, -1);
> +
> + /* Get Rx queue ID from parameter string */
> + rx_queue_id = strtoul(token, NULL, 10);
> + if (rx_queue_id >= rte_eth_devices[eth_dev_id].data-
> >nb_rx_queues) {
> + RTE_EDEV_LOG_ERR("Invalid rx queue_id %u",
> rx_queue_id);
> + ret = -EINVAL;
> + goto error;
> + }
> +
> + token = strtok(NULL, "\0");
> + if (token != NULL)
> + RTE_EDEV_LOG_ERR("Extra parameters passed to eventdev"
> + " telemetry command, ignoring");
> +
> + /* Parsing parameter finished */
> + free(l_params);
> +
> + if (rte_event_eth_rx_adapter_instance_get(eth_dev_id,
> + rx_queue_id,
> + &instance_id)) {
> + RTE_EDEV_LOG_ERR("Failed to get RX adapter instance ID "
> + " for rx_queue_id = %d", rx_queue_id);
> + return -1;
> + }
> +
> + rte_tel_data_start_dict(d);
> + rte_tel_data_add_dict_u64(d, "eth_dev_id", eth_dev_id);
> + rte_tel_data_add_dict_u64(d, "rx_queue_id", rx_queue_id);
> + rte_tel_data_add_dict_u64(d, "rxa_instance_id", instance_id);
> +
> + return 0;
> +
> +error:
> + free(l_params);
> + return ret;
> +}
> +
> RTE_INIT(rxa_init_telemetry)
> {
> rte_telemetry_register_cmd("/eventdev/rxa_stats",
> @@ -3695,4 +3757,8 @@ RTE_INIT(rxa_init_telemetry)
> rte_telemetry_register_cmd("/eventdev/rxa_queue_stats_reset",
> handle_rxa_queue_stats_reset,
> "Reset Rx queue stats. Parameter: rxa_id, dev_id,
> queue_id");
> +
> + rte_telemetry_register_cmd("/eventdev/rxa_rxq_instance_get",
> + handle_rxa_instance_get,
> + "Returns Rx adapter instance id. Parameter: dev_id,
> queue_id");
> }
> --
> 2.6.4
next prev parent reply other threads:[~2022-06-22 17:30 UTC|newest]
Thread overview: 81+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-06 17:25 [PATCH v1] eventdev: add adapter instance get API Ganapati Kundapura
2022-06-07 8:07 ` [PATCH v2] " Ganapati Kundapura
2022-06-07 8:21 ` [PATCH v3] " Ganapati Kundapura
2022-06-07 13:18 ` Jayatheerthan, Jay
2022-06-08 11:23 ` Kundapura, Ganapati
2022-06-07 15:13 ` [PATCH v4] " Ganapati Kundapura
2022-06-08 4:26 ` Naga Harish K, S V
2022-06-08 11:22 ` Kundapura, Ganapati
2022-06-08 11:16 ` [PATCH v5 1/7] eventdev/eth_rx: " Ganapati Kundapura
2022-06-08 11:16 ` [PATCH v5 2/7] eventdev/eth_rx: add telemetry callback for instance get Ganapati Kundapura
2022-06-08 11:16 ` [PATCH v5 3/7] test/eth_rx: add test case for instance get API Ganapati Kundapura
2022-06-08 11:16 ` [PATCH v5 4/7] eventdev/eth_tx: add " Ganapati Kundapura
2022-06-08 11:16 ` [PATCH v5 5/7] test/eth_tx: add testcase for " Ganapati Kundapura
2022-06-08 11:16 ` [PATCH v5 6/7] doc/eth_rx: update " Ganapati Kundapura
2022-06-08 11:16 ` [PATCH v5 7/7] doc/eth_tx: " Ganapati Kundapura
2022-06-08 12:13 ` [PATCH v6 1/7] eventdev/eth_rx: add adapter " Ganapati Kundapura
2022-06-08 12:13 ` [PATCH v6 2/7] eventdev/eth_rx: add telemetry callback for instance get Ganapati Kundapura
2022-06-08 12:13 ` [PATCH v6 3/7] test/eth_rx: add test case for instance get API Ganapati Kundapura
2022-06-08 12:13 ` [PATCH v6 4/7] eventdev/eth_tx: add " Ganapati Kundapura
2022-06-10 4:14 ` Naga Harish K, S V
2022-06-08 12:13 ` [PATCH v6 5/7] test/eth_tx: add testcase for " Ganapati Kundapura
2022-06-08 12:13 ` [PATCH v6 6/7] doc/eth_rx: update " Ganapati Kundapura
2022-06-08 12:14 ` [PATCH v6 7/7] doc/eth_tx: " Ganapati Kundapura
2022-06-10 4:12 ` [PATCH v6 1/7] eventdev/eth_rx: add adapter " Naga Harish K, S V
2022-06-22 10:37 ` [PATCH v7 " Ganapati Kundapura
2022-06-22 10:37 ` [PATCH v7 2/7] eventdev/eth_rx: add telemetry callback for instance get Ganapati Kundapura
2022-06-22 10:37 ` [PATCH v7 3/7] test/eth_rx: add test case for instance get API Ganapati Kundapura
2022-06-22 10:37 ` [PATCH v7 4/7] eventdev/eth_tx: add " Ganapati Kundapura
2022-06-22 10:37 ` [PATCH v7 5/7] test/eth_tx: add testcase for " Ganapati Kundapura
2022-06-22 10:37 ` [PATCH v7 6/7] doc/eth_rx: update " Ganapati Kundapura
2022-06-22 10:37 ` [PATCH v7 7/7] doc/eth_tx: " Ganapati Kundapura
2022-06-22 16:53 ` [PATCH v8 1/7] eventdev/eth_rx: add adapter " Ganapati Kundapura
2022-06-22 16:54 ` [PATCH v8 2/7] eventdev/eth_rx: add telemetry callback for instance get Ganapati Kundapura
2022-06-22 17:29 ` Naga Harish K, S V [this message]
2022-06-22 16:54 ` [PATCH v8 3/7] test/eth_rx: add test case for instance get API Ganapati Kundapura
2022-06-22 17:29 ` Naga Harish K, S V
2022-06-22 16:54 ` [PATCH v8 4/7] eventdev/eth_tx: add " Ganapati Kundapura
2022-06-22 17:30 ` Naga Harish K, S V
2022-06-22 16:54 ` [PATCH v8 5/7] test/eth_tx: add testcase for " Ganapati Kundapura
2022-06-22 17:30 ` Naga Harish K, S V
2022-06-22 16:54 ` [PATCH v8 6/7] doc/eth_rx: update " Ganapati Kundapura
2022-06-22 17:30 ` Naga Harish K, S V
2022-06-22 16:54 ` [PATCH v8 7/7] doc/eth_tx: " Ganapati Kundapura
2022-06-22 17:30 ` Naga Harish K, S V
2022-06-22 17:41 ` Jayatheerthan, Jay
2022-06-22 17:29 ` [PATCH v8 1/7] eventdev/eth_rx: add adapter " Naga Harish K, S V
2022-06-22 17:44 ` Jayatheerthan, Jay
2022-06-23 6:24 ` [PATCH v9 " Ganapati Kundapura
2022-06-23 6:24 ` [PATCH v9 2/7] eventdev/eth_rx: add telemetry callback for instance get Ganapati Kundapura
2022-06-23 6:24 ` [PATCH v9 3/7] test/eth_rx: add test case for instance get API Ganapati Kundapura
2022-06-23 6:24 ` [PATCH v9 4/7] eventdev/eth_tx: add " Ganapati Kundapura
2022-06-23 6:24 ` [PATCH v9 5/7] test/eth_tx: add testcase for " Ganapati Kundapura
2022-06-23 6:24 ` [PATCH v9 6/7] doc/eth_rx: update " Ganapati Kundapura
2022-06-23 6:24 ` [PATCH v9 7/7] doc/eth_tx: " Ganapati Kundapura
2022-06-23 9:30 ` [PATCH v10 1/7] eventdev/eth_rx: add adapter " Ganapati Kundapura
2022-06-23 9:30 ` [PATCH v10 2/7] eventdev/eth_rx: add telemetry callback for instance get Ganapati Kundapura
2022-06-23 9:30 ` [PATCH v10 3/7] test/eth_rx: add test case for instance get API Ganapati Kundapura
2022-06-23 9:30 ` [PATCH v10 4/7] eventdev/eth_tx: add " Ganapati Kundapura
2022-06-23 9:30 ` [PATCH v10 5/7] test/eth_tx: add testcase for " Ganapati Kundapura
2022-06-23 9:30 ` [PATCH v10 6/7] doc/eth_rx: update " Ganapati Kundapura
2022-06-23 9:30 ` [PATCH v10 7/7] doc/eth_tx: " Ganapati Kundapura
2022-07-19 8:25 ` [PATCH v11 1/7] eventdev/eth_rx: add adapter " Ganapati Kundapura
2022-07-19 8:25 ` [PATCH v11 2/7] eventdev/eth_rx: add telemetry callback for instance get Ganapati Kundapura
2022-07-19 8:25 ` [PATCH v11 3/7] test/eth_rx: add test case for instance get API Ganapati Kundapura
2022-07-19 8:25 ` [PATCH v11 4/7] eventdev/eth_tx: add " Ganapati Kundapura
2022-07-19 8:25 ` [PATCH v11 5/7] test/eth_tx: add testcase for " Ganapati Kundapura
2022-07-19 8:25 ` [PATCH v11 6/7] doc/eth_rx: update " Ganapati Kundapura
2022-07-19 8:25 ` [PATCH v11 7/7] doc/eth_tx: " Ganapati Kundapura
2022-08-11 13:28 ` [PATCH v11 1/7] eventdev/eth_rx: add adapter " Kundapura, Ganapati
2022-08-27 12:14 ` Jerin Jacob
2022-08-29 8:20 ` Kundapura, Ganapati
2022-08-29 8:14 ` [PATCH v12 1/6] " Ganapati Kundapura
2022-08-29 8:14 ` [PATCH v12 2/6] eventdev/eth_rx: add telemetry callback for instance get Ganapati Kundapura
2022-08-29 8:14 ` [PATCH v12 3/6] test/eth_rx: add test case for instance get API Ganapati Kundapura
2022-08-29 8:14 ` [PATCH v12 4/6] eventdev/eth_tx: add " Ganapati Kundapura
2022-09-02 13:10 ` Jerin Jacob
2022-08-29 8:14 ` [PATCH v12 5/6] test/eth_tx: add testcase for " Ganapati Kundapura
2022-08-29 8:14 ` [PATCH v12 6/6] doc: Added adapter " Ganapati Kundapura
2022-08-29 8:14 ` [PATCH v12 6/6] doc: added " Ganapati Kundapura
2022-09-02 13:11 ` Jerin Jacob
2022-09-02 13:09 ` [PATCH v12 1/6] eventdev/eth_rx: add " Jerin Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR11MB38687B389E955347132D44BCA1B29@DM6PR11MB3868.namprd11.prod.outlook.com \
--to=s.v.naga.harish.k@intel.com \
--cc=dev@dpdk.org \
--cc=ganapati.kundapura@intel.com \
--cc=jay.jayatheerthan@intel.com \
--cc=jerinj@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).