From: "Jayatheerthan, Jay" <jay.jayatheerthan@intel.com>
To: "Naga Harish K, S V" <s.v.naga.harish.k@intel.com>,
"jerinj@marvell.com" <jerinj@marvell.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Subject: RE: [PATCH 2/2] eventdev/eth_tx: fix adapter stop
Date: Mon, 1 Aug 2022 06:54:10 +0000 [thread overview]
Message-ID: <DM6PR11MB4348127142306B9030DAF643FD9A9@DM6PR11MB4348.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20220726042211.1018326-2-s.v.naga.harish.k@intel.com>
> -----Original Message-----
> From: Naga Harish K, S V <s.v.naga.harish.k@intel.com>
> Sent: Tuesday, July 26, 2022 9:52 AM
> To: Jayatheerthan, Jay <jay.jayatheerthan@intel.com>; jerinj@marvell.com
> Cc: dev@dpdk.org; stable@dpdk.org
> Subject: [PATCH 2/2] eventdev/eth_tx: fix adapter stop
>
> adapter_stop function is stopping the adapter service using
> rte_service_runstate_set() api and waiting until
> rte_service_may_be_active() api returns stopped state in an
> infinite loop.
>
> This results in hang issues if application calls
> rte_service_lcore_stop() before adapter stop.
>
> remove the state check after setting the service state which
> avoids running into hang issues. This also makes tx adapter stop
> inline with remaining adapters.
>
> Fixes: a3bbf2e09756 ("eventdev: add eth Tx adapter implementation")
> Cc: stable@dpdk.org
>
> Signed-off-by: Naga Harish K S V <s.v.naga.harish.k@intel.com>
> ---
> lib/eventdev/rte_event_eth_tx_adapter.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/lib/eventdev/rte_event_eth_tx_adapter.c b/lib/eventdev/rte_event_eth_tx_adapter.c
> index 3251dad61f..41509ba750 100644
> --- a/lib/eventdev/rte_event_eth_tx_adapter.c
> +++ b/lib/eventdev/rte_event_eth_tx_adapter.c
> @@ -475,10 +475,6 @@ txa_service_ctrl(uint8_t id, int start)
> ret = rte_service_runstate_set(txa->service_id, start);
> rte_spinlock_unlock(&txa->tx_lock);
>
> - if (ret == 0 && !start) {
> - while (rte_service_may_be_active(txa->service_id))
> - rte_pause();
> - }
> return ret;
> }
>
> --
> 2.23.0
Acked-by: Jay Jayatheerthan <jay.jayatheerthan@intel.com>
next prev parent reply other threads:[~2022-08-01 6:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-26 4:22 [PATCH 1/2] eventdev/eth_tx: add spinlock for adapter start/stop Naga Harish K S V
2022-07-26 4:22 ` [PATCH 2/2] eventdev/eth_tx: fix adapter stop Naga Harish K S V
2022-08-01 6:54 ` Jayatheerthan, Jay [this message]
2022-08-01 6:53 ` [PATCH 1/2] eventdev/eth_tx: add spinlock for adapter start/stop Jayatheerthan, Jay
2022-09-09 5:38 ` Naga Harish K, S V
2022-09-13 16:04 ` Jerin Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR11MB4348127142306B9030DAF643FD9A9@DM6PR11MB4348.namprd11.prod.outlook.com \
--to=jay.jayatheerthan@intel.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=s.v.naga.harish.k@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).