From: "Jayatheerthan, Jay" <jay.jayatheerthan@intel.com>
To: "Naga Harish K, S V" <s.v.naga.harish.k@intel.com>,
mattias.ronnblom <mattias.ronnblom@ericsson.com>,
"Carrillo, Erik G" <erik.g.carrillo@intel.com>,
"Gujjar, Abhinandan S" <abhinandan.gujjar@intel.com>,
Jerin Jacob <jerinj@marvell.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Van Haaren, Harry" <harry.van.haaren@intel.com>,
"hofors@lysator.liu.se" <hofors@lysator.liu.se>,
mattias.ronnblom <mattias.ronnblom@ericsson.com>
Subject: RE: [PATCH 3/4] eventdev: have ethernet Tx adapter appropriately report idle
Date: Tue, 18 Oct 2022 09:19:34 +0000 [thread overview]
Message-ID: <DM6PR11MB43486B63A0C85A67A116EE60FD289@DM6PR11MB4348.namprd11.prod.outlook.com> (raw)
In-Reply-To: <DM6PR11MB3868B458EBCB8ABC8F32BC09A1259@DM6PR11MB3868.namprd11.prod.outlook.com>
Looks good to me. Thanks for submitting this!
Acked by: Jay Jayatheerthan <jay.jayatheerthan@intel.com>
-Jay
> -----Original Message-----
> From: Naga Harish K, S V <s.v.naga.harish.k@intel.com>
> Sent: Thursday, October 13, 2022 7:00 AM
> To: Jayatheerthan, Jay <jay.jayatheerthan@intel.com>; mattias.ronnblom <mattias.ronnblom@ericsson.com>; Carrillo, Erik G
> <erik.g.carrillo@intel.com>; Gujjar, Abhinandan S <abhinandan.gujjar@intel.com>; Jerin Jacob <jerinj@marvell.com>
> Cc: dev@dpdk.org; Van Haaren, Harry <harry.van.haaren@intel.com>; hofors@lysator.liu.se; mattias.ronnblom
> <mattias.ronnblom@ericsson.com>
> Subject: RE: [PATCH 3/4] eventdev: have ethernet Tx adapter appropriately report idle
>
>
>
> > -----Original Message-----
> > From: Jayatheerthan, Jay <jay.jayatheerthan@intel.com>
> > Sent: Tuesday, October 11, 2022 12:41 PM
> > To: mattias.ronnblom <mattias.ronnblom@ericsson.com>; Carrillo, Erik G
> > <erik.g.carrillo@intel.com>; Gujjar, Abhinandan S
> > <abhinandan.gujjar@intel.com>; Jerin Jacob <jerinj@marvell.com>; Naga
> > Harish K, S V <s.v.naga.harish.k@intel.com>
> > Cc: dev@dpdk.org; Van Haaren, Harry <harry.van.haaren@intel.com>;
> > hofors@lysator.liu.se; mattias.ronnblom <mattias.ronnblom@ericsson.com>
> > Subject: RE: [PATCH 3/4] eventdev: have ethernet Tx adapter appropriately
> > report idle
> >
> > @Harish, could you review the patch ?
> >
> > -Jay
> >
> >
> >
> > > -----Original Message-----
> > > From: Mattias Rönnblom <mattias.ronnblom@ericsson.com>
> > > Sent: Monday, October 10, 2022 8:24 PM
> > > To: Jayatheerthan, Jay <jay.jayatheerthan@intel.com>; Carrillo, Erik G
> > > <erik.g.carrillo@intel.com>; Gujjar, Abhinandan S
> > > <abhinandan.gujjar@intel.com>; Jerin Jacob <jerinj@marvell.com>
> > > Cc: dev@dpdk.org; Van Haaren, Harry <harry.van.haaren@intel.com>;
> > > hofors@lysator.liu.se; mattias.ronnblom
> > > <mattias.ronnblom@ericsson.com>
> > > Subject: [PATCH 3/4] eventdev: have ethernet Tx adapter appropriately
> > > report idle
> > >
> > > Update the Event Ethernet Tx Adapter's service function to report as
> > > idle (i.e., return -EAGAIN) in case no events were dequeued from the
> > > event device and no Ethernet frames were sent out on the wire.
> > >
> > > Signed-off-by: Mattias Rönnblom <mattias.ronnblom@ericsson.com>
> > > ---
> > > lib/eventdev/rte_event_eth_tx_adapter.c | 13 +++++++++----
> > > 1 file changed, 9 insertions(+), 4 deletions(-)
> > >
> > > diff --git a/lib/eventdev/rte_event_eth_tx_adapter.c
> > > b/lib/eventdev/rte_event_eth_tx_adapter.c
> > > index 7f7d86f683..c2a848103b 100644
> > > --- a/lib/eventdev/rte_event_eth_tx_adapter.c
> > > +++ b/lib/eventdev/rte_event_eth_tx_adapter.c
> > > @@ -639,6 +639,7 @@ txa_service_func(void *args)
> > > struct txa_service_data *txa = args;
> > > uint8_t dev_id;
> > > uint8_t port;
> > > + int ret = -EAGAIN;
> > > uint16_t n;
> > > uint32_t nb_tx, max_nb_tx;
> > > struct rte_event ev[TXA_BATCH_SIZE]; @@ -648,10 +649,10 @@
> > > txa_service_func(void *args)
> > > port = txa->port_id;
> > >
> > > if (txa->nb_queues == 0)
> > > - return 0;
> > > + return ret;
> > >
> > > if (!rte_spinlock_trylock(&txa->tx_lock))
> > > - return 0;
> > > + return ret;
> > >
> > > for (nb_tx = 0; nb_tx < max_nb_tx; nb_tx += n) {
> > >
> > > @@ -659,6 +660,7 @@ txa_service_func(void *args)
> > > if (!n)
> > > break;
> > > txa_service_tx(txa, ev, n);
> > > + ret = 0;
> > > }
> > >
> > > if ((txa->loop_cnt++ & (TXA_FLUSH_THRESHOLD - 1)) == 0) { @@ -
> > 692,10
> > > +694,13 @@ txa_service_func(void *args)
> > > }
> > > }
> > >
> > > - txa->stats.tx_packets += nb_tx;
> > > + if (likely(nb_tx > 0)) {
>
> How are the performance numbers before and after this patch?
> Trying to understand the performance impact, as new condition is added to the service function Datapath.
>
> > > + txa->stats.tx_packets += nb_tx;
> > > + ret = 0;
> > > + }
> > > }
> > > rte_spinlock_unlock(&txa->tx_lock);
> > > - return 0;
> > > + return ret;
> > > }
> > >
> > > static int
> > > --
> > > 2.34.1
next prev parent reply other threads:[~2022-10-18 9:19 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-10 14:54 [PATCH 0/4] Have event adapters report idle status Mattias Rönnblom
2022-10-10 14:54 ` [PATCH 1/4] eventdev: have crypto adapter appropriately report idle Mattias Rönnblom
2022-10-17 5:47 ` Gujjar, Abhinandan S
2022-10-10 14:54 ` [PATCH 2/4] eventdev: have ethernet Rx " Mattias Rönnblom
2022-10-11 7:10 ` Jayatheerthan, Jay
2022-10-13 1:32 ` Naga Harish K, S V
2022-10-13 9:53 ` Mattias Rönnblom
2022-10-14 17:36 ` Jerin Jacob
2022-10-17 12:36 ` Naga Harish K, S V
2022-10-18 9:19 ` Jayatheerthan, Jay
2022-10-10 14:54 ` [PATCH 3/4] eventdev: have ethernet Tx " Mattias Rönnblom
2022-10-11 7:10 ` Jayatheerthan, Jay
2022-10-13 1:30 ` Naga Harish K, S V
2022-10-18 9:19 ` Jayatheerthan, Jay [this message]
2022-10-19 11:32 ` Jerin Jacob
2022-10-10 14:54 ` [PATCH 4/4] eventdev: have timer " Mattias Rönnblom
2022-10-17 21:42 ` Carrillo, Erik G
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR11MB43486B63A0C85A67A116EE60FD289@DM6PR11MB4348.namprd11.prod.outlook.com \
--to=jay.jayatheerthan@intel.com \
--cc=abhinandan.gujjar@intel.com \
--cc=dev@dpdk.org \
--cc=erik.g.carrillo@intel.com \
--cc=harry.van.haaren@intel.com \
--cc=hofors@lysator.liu.se \
--cc=jerinj@marvell.com \
--cc=mattias.ronnblom@ericsson.com \
--cc=s.v.naga.harish.k@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).