From: "Jayatheerthan, Jay" <jay.jayatheerthan@intel.com>
To: mattias.ronnblom <mattias.ronnblom@ericsson.com>,
"jerinjacobk@gmail.com" <jerinjacobk@gmail.com>,
"Kundapura, Ganapati" <ganapati.kundapura@intel.com>,
"jerinj@marvell.com" <jerinj@marvell.com>
Cc: "dev @ dpdk . org" <dev@dpdk.org>,
mattias.ronnblom <mattias.ronnblom@ericsson.com>
Subject: Re: [dpdk-dev] [PATCH v2] eventdev: fix Rx adapter stalls on event device backpressure
Date: Wed, 10 Nov 2021 11:23:37 +0000 [thread overview]
Message-ID: <DM6PR11MB43487EFC61699F46D13D7F78FD939@DM6PR11MB4348.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20211110111400.21475-1-mattias.ronnblom@ericsson.com>
Looks good. Thanks for posting this change!
Acked-by: Jay Jayatheerthan <jay.jayatheerthan@intel.com>
> -----Original Message-----
> From: Mattias Rönnblom <mattias.ronnblom@ericsson.com>
> Sent: Wednesday, November 10, 2021 4:44 PM
> To: jerinjacobk@gmail.com; Jayatheerthan, Jay <jay.jayatheerthan@intel.com>; Kundapura, Ganapati
> <ganapati.kundapura@intel.com>; jerinj@marvell.com
> Cc: dev @ dpdk . org <dev@dpdk.org>; mattias.ronnblom <mattias.ronnblom@ericsson.com>
> Subject: [PATCH v2] eventdev: fix Rx adapter stalls on event device backpressure
>
> In the Eventdev Ethernet RX Adapter, correctly handle the case where
> the circular enqueue buffer head and last index point to the same
> element.
>
> This bug may be triggered in case there is backpressure from the event
> device to the RX adapter.
>
> v2:
> * Corrected bug description
>
> Fixes: 8113fd15e229 ("eventdev/eth_rx: make enqueue buffer circular")
> Cc: ganapati.kundapura@intel.com
>
> Signed-off-by: Mattias Rönnblom <mattias.ronnblom@ericsson.com>
> ---
> lib/eventdev/rte_event_eth_rx_adapter.c | 22 ++++++++++++++--------
> 1 file changed, 14 insertions(+), 8 deletions(-)
>
> diff --git a/lib/eventdev/rte_event_eth_rx_adapter.c b/lib/eventdev/rte_event_eth_rx_adapter.c
> index 56318b5a6f..809416d9b7 100644
> --- a/lib/eventdev/rte_event_eth_rx_adapter.c
> +++ b/lib/eventdev/rte_event_eth_rx_adapter.c
> @@ -777,19 +777,25 @@ rxa_flush_event_buffer(struct event_eth_rx_adapter *rx_adapter,
> struct eth_event_enqueue_buffer *buf,
> struct rte_event_eth_rx_adapter_stats *stats)
> {
> - uint16_t count = buf->last ? buf->last - buf->head : buf->count;
> + uint16_t count = buf->count;
> + uint16_t n = 0;
>
> if (!count)
> return 0;
>
> - uint16_t n = rte_event_enqueue_new_burst(rx_adapter->eventdev_id,
> - rx_adapter->event_port_id,
> - &buf->events[buf->head],
> - count);
> - if (n != count)
> - stats->rx_enq_retry++;
> + if (buf->last)
> + count = buf->last - buf->head;
> +
> + if (count) {
> + n = rte_event_enqueue_new_burst(rx_adapter->eventdev_id,
> + rx_adapter->event_port_id,
> + &buf->events[buf->head],
> + count);
> + if (n != count)
> + stats->rx_enq_retry++;
>
> - buf->head += n;
> + buf->head += n;
> + }
>
> if (buf->last && n == count) {
> uint16_t n1;
> --
> 2.25.1
next prev parent reply other threads:[~2021-11-10 11:23 UTC|newest]
Thread overview: 86+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-07 11:12 [dpdk-dev] [PATCH 1/3] doc: add skeleton for eventdevs feature metrices Sunil Kumar Kori
2019-11-07 11:12 ` [dpdk-dev] [PATCH 2/3] doc: update eventdev feature matrix for octeontx2 Sunil Kumar Kori
2019-11-07 11:12 ` [dpdk-dev] [PATCH 3/3] doc: update eventdev feature matrix for octeontx Sunil Kumar Kori
2019-11-15 7:38 ` [dpdk-dev] [PATCH 1/3] doc: add skeleton for eventdevs feature metrices Jerin Jacob
2019-11-21 7:44 ` [dpdk-dev] [PATCH v2 1/3] doc: add skeleton for eventdevs feature matrices Sunil Kumar Kori
2019-11-21 7:44 ` [dpdk-dev] [PATCH v2 2/3] doc: update eventdev feature matrix for octeontx2 Sunil Kumar Kori
2019-11-21 7:44 ` [dpdk-dev] [PATCH v2 3/3] doc: update eventdev feature matrix for octeontx Sunil Kumar Kori
2019-11-28 15:49 ` [dpdk-dev] [PATCH v2 1/3] doc: add skeleton for eventdevs feature matrices Thomas Monjalon
2019-12-03 6:27 ` [dpdk-dev] [PATCH v3 " Sunil Kumar Kori
2019-12-03 6:27 ` [dpdk-dev] [PATCH v3 2/3] doc: update eventdev feature matrix for octeontx2 Sunil Kumar Kori
2019-12-03 6:27 ` [dpdk-dev] [PATCH v3 3/3] doc: update eventdev feature matrix for octeontx Sunil Kumar Kori
2020-02-27 7:02 ` [dpdk-dev] [PATCH v4 1/3] doc: add skeleton for eventdevs feature matrices Sunil Kumar Kori
2020-02-27 7:03 ` [dpdk-dev] [PATCH v4 2/3] doc: update eventdev feature matrix for octeontx2 Sunil Kumar Kori
2020-02-27 7:03 ` [dpdk-dev] [PATCH v4 3/3] doc: update eventdev feature matrix for octeontx Sunil Kumar Kori
2021-10-22 7:48 ` [dpdk-dev] [PATCH v5 1/4] doc: add skeleton for eventdevs feature matrices skori
2021-10-22 7:48 ` [dpdk-dev] [PATCH v5 2/4] doc: update eventdev feature matrix for octeontx2 skori
2021-10-22 7:48 ` [dpdk-dev] [PATCH v5 3/4] doc: update eventdev feature matrix for octeontx skori
2021-10-22 7:48 ` [dpdk-dev] [PATCH v5 4/4] doc: update eventdev feature matrix for cnxk skori
2021-11-09 10:11 ` [dpdk-dev] [PATCH v5 1/4] doc: add skeleton for eventdevs feature matrices Jerin Jacob
2021-11-09 11:34 ` Thomas Monjalon
2021-11-11 6:40 ` [EXT] " Sunil Kumar Kori
2021-11-10 8:42 ` Mattias Rönnblom
2021-11-10 8:50 ` [dpdk-dev] [EXT] " Jerin Jacob Kollanukkaran
2021-11-10 9:29 ` [dpdk-dev] [PATCH] eventdev: negate maintenance capability flag Mattias Rönnblom
2021-11-10 9:55 ` Van Haaren, Harry
2021-11-10 10:06 ` [dpdk-dev] [PATCH v2] " Mattias Rönnblom
2021-11-10 10:07 ` [dpdk-dev] [PATCH] " Mattias Rönnblom
2021-11-10 10:43 ` Jerin Jacob
2021-11-10 11:32 ` [dpdk-dev] [PATCH v3] " Mattias Rönnblom
2021-11-10 18:55 ` Jerin Jacob
2021-11-10 11:14 ` [dpdk-dev] [PATCH v2] eventdev: fix Rx adapter stalls on event device backpressure Mattias Rönnblom
2021-11-10 11:23 ` Jayatheerthan, Jay [this message]
2021-11-10 18:56 ` Jerin Jacob
2021-11-15 13:15 ` [PATCH v6 01/11] doc: add skeleton for eventdevs feature matrices skori
2021-11-15 13:15 ` [PATCH v6 02/11] doc: update eventdev feature matrix for octeontx skori
2021-11-15 13:15 ` [PATCH v6 03/11] doc: update eventdev feature matrix for octeontx2 skori
2021-11-15 13:15 ` [PATCH v6 04/11] doc: update eventdev feature matrix for cn9k skori
2021-11-15 13:15 ` [PATCH v6 05/11] doc: update eventdev feature matrix for cn10k skori
2021-11-15 13:15 ` [PATCH v6 06/11] doc: update eventdev feature matrix for dpaa skori
2021-11-15 13:15 ` [PATCH v6 07/11] doc: update eventdev feature matrix for dpaa2 skori
2021-11-15 13:15 ` [PATCH v6 08/11] doc: update eventdev feature matrix for SW skori
2021-11-15 13:15 ` [PATCH v6 09/11] doc: update eventdev feature matrix for opdl skori
2021-11-15 13:15 ` [PATCH v6 10/11] doc: update eventdev feature matrix for dsw skori
2021-11-15 13:15 ` [PATCH v6 11/11] devtools: check event device doc tables skori
2021-11-22 7:54 ` [PATCH v7 01/11] doc: add skeleton for eventdevs feature matrices skori
2021-11-22 7:54 ` [PATCH v7 02/11] doc: update eventdev feature matrix for octeontx skori
2021-11-22 7:54 ` [PATCH v7 03/11] doc: update eventdev feature matrix for octeontx2 skori
2021-11-22 7:54 ` [PATCH v7 04/11] doc: update eventdev feature matrix for cn9k skori
2021-11-22 7:54 ` [PATCH v7 05/11] doc: update eventdev feature matrix for cn10k skori
2021-11-22 18:25 ` Jerin Jacob
2021-11-22 7:54 ` [PATCH v7 06/11] doc: update eventdev feature matrix for dpaa skori
2021-11-22 7:54 ` [PATCH v7 07/11] doc: update eventdev feature matrix for dpaa2 skori
2021-11-22 7:54 ` [PATCH v7 08/11] doc: update eventdev feature matrix for SW skori
2021-11-22 7:54 ` [PATCH v7 09/11] doc: update eventdev feature matrix for opdl skori
2021-11-22 7:54 ` [PATCH v7 10/11] doc: update eventdev feature matrix for dsw skori
2021-11-22 7:54 ` [PATCH v7 11/11] devtools: check event device doc tables skori
2021-11-22 18:35 ` Jerin Jacob
2021-11-23 11:07 ` [PATCH v8 01/10] doc: add skeleton for eventdevs feature matrices skori
2021-11-23 11:07 ` [PATCH v8 02/10] doc: update eventdev feature matrix for octeontx skori
2021-11-23 11:07 ` [PATCH v8 03/10] doc: update eventdev feature matrix for octeontx2 skori
2021-11-23 11:07 ` [PATCH v8 04/10] doc: update eventdev feature matrix for cnxk skori
2021-11-23 11:07 ` [PATCH v8 05/10] doc: update eventdev feature matrix for dpaa skori
2021-11-23 11:07 ` [PATCH v8 06/10] doc: update eventdev feature matrix for dpaa2 skori
2021-11-23 11:07 ` [PATCH v8 07/10] doc: update eventdev feature matrix for SW skori
2021-11-23 11:07 ` [PATCH v8 08/10] doc: update eventdev feature matrix for opdl skori
2021-11-23 11:07 ` [PATCH v8 09/10] doc: update eventdev feature matrix for dsw skori
2021-11-23 11:07 ` [PATCH v8 10/10] devtools: check event device doc tables skori
2021-11-24 10:52 ` Thomas Monjalon
2021-11-24 11:16 ` [EXT] " Sunil Kumar Kori
2021-11-24 11:21 ` Thomas Monjalon
2021-11-24 10:03 ` [PATCH v8 01/10] doc: add skeleton for eventdevs feature matrices Thomas Monjalon
2021-11-24 10:30 ` [EXT] " Sunil Kumar Kori
2021-11-24 10:43 ` Thomas Monjalon
2021-11-24 12:35 ` Sunil Kumar Kori
2021-11-24 12:41 ` Thomas Monjalon
2021-11-24 12:46 ` Sunil Kumar Kori
2021-11-24 13:05 ` Sunil Kumar Kori
2021-11-24 10:48 ` Thomas Monjalon
2021-11-24 11:12 ` [EXT] " Sunil Kumar Kori
2021-11-24 12:14 ` [PATCH v1 1/1] doc: update eventdev feature matrix for dlb2 skori
2021-11-24 13:03 ` [PATCH v9 1/1] doc: add eventdevs feature matrices skori
2021-11-26 14:55 ` Thomas Monjalon
2021-11-15 18:08 ` [dpdk-dev] [PATCH v5 1/4] doc: add skeleton for " Jerin Jacob
2021-11-23 16:44 ` Jerin Jacob
2021-11-24 8:06 ` Thomas Monjalon
2021-11-24 8:14 ` Jerin Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR11MB43487EFC61699F46D13D7F78FD939@DM6PR11MB4348.namprd11.prod.outlook.com \
--to=jay.jayatheerthan@intel.com \
--cc=dev@dpdk.org \
--cc=ganapati.kundapura@intel.com \
--cc=jerinj@marvell.com \
--cc=jerinjacobk@gmail.com \
--cc=mattias.ronnblom@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).