From: "Jayatheerthan, Jay" <jay.jayatheerthan@intel.com>
To: "Naga Harish K, S V" <s.v.naga.harish.k@intel.com>,
"jerinj@marvell.com" <jerinj@marvell.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Subject: RE: [PATCH] eventdev/eth_tx: fix queue delete
Date: Thu, 23 Jun 2022 14:59:13 +0000 [thread overview]
Message-ID: <DM6PR11MB4348CFF7E93C3CE25212D0BBFDB59@DM6PR11MB4348.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20220623100511.2388739-1-s.v.naga.harish.k@intel.com>
Looks good to me.
Acked-by: Jay Jayatheerthan <jay.jayatheerthan@intel.com>
-Jay
> -----Original Message-----
> From: Naga Harish K, S V <s.v.naga.harish.k@intel.com>
> Sent: Thursday, June 23, 2022 3:35 PM
> To: Jayatheerthan, Jay <jay.jayatheerthan@intel.com>; jerinj@marvell.com
> Cc: dev@dpdk.org; stable@dpdk.org
> Subject: [PATCH] eventdev/eth_tx: fix queue delete
>
> Add spinlock protection in queue delete function.
> This protects the data path while the queue delete operation
> is in progress.
>
> Fixes: a3bbf2e09756 ("eventdev: add eth Tx adapter implementation")
> Cc: stable@dpdk.org
>
> Signed-off-by: Naga Harish K S V <s.v.naga.harish.k@intel.com>
> ---
> lib/eventdev/rte_event_eth_tx_adapter.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/lib/eventdev/rte_event_eth_tx_adapter.c b/lib/eventdev/rte_event_eth_tx_adapter.c
> index c700fb7b1f..b4b37f1cae 100644
> --- a/lib/eventdev/rte_event_eth_tx_adapter.c
> +++ b/lib/eventdev/rte_event_eth_tx_adapter.c
> @@ -891,9 +891,10 @@ txa_service_queue_del(uint8_t id,
>
> txa = txa_service_id_to_data(id);
>
> + rte_spinlock_lock(&txa->tx_lock);
> tqi = txa_service_queue(txa, port_id, tx_queue_id);
> if (tqi == NULL || !tqi->added)
> - return 0;
> + goto ret_unlock;
>
> tb = tqi->tx_buf;
> tqi->added = 0;
> @@ -903,6 +904,9 @@ txa_service_queue_del(uint8_t id,
> txa->txa_ethdev[port_id].nb_queues--;
>
> txa_service_queue_array_free(txa, port_id);
> +
> +ret_unlock:
> + rte_spinlock_unlock(&txa->tx_lock);
> return 0;
> }
>
> --
> 2.25.1
next prev parent reply other threads:[~2022-06-23 14:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-23 10:05 Naga Harish K S V
2022-06-23 14:59 ` Jayatheerthan, Jay [this message]
2022-07-04 16:08 ` Jerin Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR11MB4348CFF7E93C3CE25212D0BBFDB59@DM6PR11MB4348.namprd11.prod.outlook.com \
--to=jay.jayatheerthan@intel.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=s.v.naga.harish.k@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).