From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: Akhil Goyal <gakhil@marvell.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "anoobj@marvell.com" <anoobj@marvell.com>,
"Nicolau, Radu" <radu.nicolau@intel.com>,
"Doherty, Declan" <declan.doherty@intel.com>,
"hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>,
"matan@nvidia.com" <matan@nvidia.com>,
"thomas@monjalon.net" <thomas@monjalon.net>,
"Yigit, Ferruh" <ferruh.yigit@intel.com>,
"andrew.rybchenko@oktetlabs.ru" <andrew.rybchenko@oktetlabs.ru>,
"olivier.matz@6wind.com" <olivier.matz@6wind.com>,
"Xu, Rosen" <rosen.xu@intel.com>
Subject: RE: [PATCH 3/8] ethdev: add mbuf dynfield for incomplete IP reassembly
Date: Tue, 11 Jan 2022 17:04:03 +0000 [thread overview]
Message-ID: <DM6PR11MB449187429CFDF5E1ADDACAD59A519@DM6PR11MB4491.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20220103150813.1694888-4-gakhil@marvell.com>
> Hardware IP reassembly may be incomplete for multiple reasons like
> reassembly timeout reached, duplicate fragments, etc.
> To save application cycles to process these packets again, a new
> mbuf ol_flag (RTE_MBUF_F_RX_IPREASSEMBLY_INCOMPLETE) is added to
> show that the mbuf received is not reassembled properly.
If we use dynfiled for data, why not use dynflag for RTE_MBUF_F_RX_IPREASSEMBLY_INCOMPLETE?
That way we can avoid introduced hardcoded (always defined) flags for that case.
>
> Now if this flag is set, application can retreive corresponding chain of
> mbufs using mbuf dynfield set by the PMD. Now, it will be upto
> application to either drop those fragments or wait for more time.
>
> Signed-off-by: Akhil Goyal <gakhil@marvell.com>
> ---
> lib/ethdev/ethdev_driver.h | 8 ++++++
> lib/ethdev/rte_ethdev.c | 16 +++++++++++
> lib/ethdev/rte_ethdev.h | 57 ++++++++++++++++++++++++++++++++++++++
> lib/ethdev/version.map | 2 ++
> lib/mbuf/rte_mbuf_core.h | 3 +-
> 5 files changed, 85 insertions(+), 1 deletion(-)
>
> diff --git a/lib/ethdev/ethdev_driver.h b/lib/ethdev/ethdev_driver.h
> index 0ed53c14f3..9a0bab9a61 100644
> --- a/lib/ethdev/ethdev_driver.h
> +++ b/lib/ethdev/ethdev_driver.h
> @@ -1671,6 +1671,14 @@ int
> rte_eth_hairpin_queue_peer_unbind(uint16_t cur_port, uint16_t cur_queue,
> uint32_t direction);
>
> +/**
> + * @internal
> + * Register mbuf dynamic field for IP reassembly incomplete case.
> + */
> +__rte_internal
> +int
> +rte_eth_ip_reass_dynfield_register(void);
> +
>
> /*
> * Legacy ethdev API used internally by drivers.
> diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c
> index ecc6c1fe37..d53ce4eaca 100644
> --- a/lib/ethdev/rte_ethdev.c
> +++ b/lib/ethdev/rte_ethdev.c
> @@ -6503,6 +6503,22 @@ rte_eth_ip_reassembly_conf_set(uint16_t port_id,
> (*dev->dev_ops->ip_reassembly_conf_set)(dev, conf));
> }
>
> +#define RTE_ETH_IP_REASS_DYNFIELD_NAME "rte_eth_ip_reass_dynfield"
> +int rte_eth_ip_reass_dynfield_offset = -1;
> +
> +int
> +rte_eth_ip_reass_dynfield_register(void)
> +{
> + static const struct rte_mbuf_dynfield dynfield_desc = {
> + .name = RTE_ETH_IP_REASS_DYNFIELD_NAME,
> + .size = sizeof(rte_eth_ip_reass_dynfield_t),
> + .align = __alignof__(rte_eth_ip_reass_dynfield_t),
> + };
> + rte_eth_ip_reass_dynfield_offset =
> + rte_mbuf_dynfield_register(&dynfield_desc);
> + return rte_eth_ip_reass_dynfield_offset;
> +}
> +
> RTE_LOG_REGISTER_DEFAULT(rte_eth_dev_logtype, INFO);
>
> RTE_INIT(ethdev_init_telemetry)
> diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h
> index 891f9a6e06..c4024d2265 100644
> --- a/lib/ethdev/rte_ethdev.h
> +++ b/lib/ethdev/rte_ethdev.h
> @@ -5245,6 +5245,63 @@ __rte_experimental
> int rte_eth_ip_reassembly_conf_set(uint16_t port_id,
> struct rte_eth_ip_reass_params *conf);
>
> +/**
> + * In case of IP reassembly offload failure, ol_flags in mbuf will be set
> + * with RTE_MBUF_F_RX_IPREASSEMBLY_INCOMPLETE and packets will be returned
> + * without alteration. The application can retrieve the attached fragments
> + * using mbuf dynamic field.
> + */
> +typedef struct {
> + /**
> + * Next fragment packet. Application should fetch dynamic field of
> + * each fragment until a NULL is received and nb_frags is 0.
> + */
> + struct rte_mbuf *next_frag;
> + /** Time spent(in ms) by HW in waiting for further fragments. */
> + uint16_t time_spent;
> + /** Number of more fragments attached in mbuf dynamic fields. */
> + uint16_t nb_frags;
> +} rte_eth_ip_reass_dynfield_t;
Looks like a bit of overkill to me:
We do already have 'next' and 'nb_frags' fields inside mbuf,
why can't they be used here? Why a separate ones are necessary?
> +
> +extern int rte_eth_ip_reass_dynfield_offset;
> +
next prev parent reply other threads:[~2022-01-11 17:04 UTC|newest]
Thread overview: 184+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-23 10:02 [dpdk-dev] [PATCH] RFC: ethdev: add reassembly offload Akhil Goyal
2021-08-23 10:18 ` Andrew Rybchenko
2021-08-29 13:14 ` [dpdk-dev] [EXT] " Akhil Goyal
2021-09-21 19:59 ` Thomas Monjalon
2021-09-07 8:47 ` [dpdk-dev] " Ferruh Yigit
2021-09-08 10:29 ` [dpdk-dev] [EXT] " Anoob Joseph
2021-09-13 6:56 ` Xu, Rosen
2021-09-13 7:22 ` Andrew Rybchenko
2021-09-14 5:14 ` Anoob Joseph
2021-09-08 6:34 ` [dpdk-dev] " Xu, Rosen
2021-09-08 6:36 ` Xu, Rosen
2022-01-03 15:08 ` [PATCH 0/8] ethdev: introduce IP " Akhil Goyal
2022-01-03 15:08 ` [PATCH 1/8] " Akhil Goyal
2022-01-11 16:03 ` Ananyev, Konstantin
2022-01-22 7:38 ` Andrew Rybchenko
2022-01-30 16:53 ` [EXT] " Akhil Goyal
2022-01-03 15:08 ` [PATCH 2/8] ethdev: add dev op for IP reassembly configuration Akhil Goyal
2022-01-11 16:09 ` Ananyev, Konstantin
2022-01-11 18:54 ` Akhil Goyal
2022-01-12 10:22 ` Ananyev, Konstantin
2022-01-12 10:32 ` Akhil Goyal
2022-01-12 10:48 ` Ananyev, Konstantin
2022-01-12 11:06 ` Akhil Goyal
2022-01-13 13:31 ` Akhil Goyal
2022-01-13 14:41 ` Ananyev, Konstantin
2022-01-03 15:08 ` [PATCH 3/8] ethdev: add mbuf dynfield for incomplete IP reassembly Akhil Goyal
2022-01-11 17:04 ` Ananyev, Konstantin [this message]
2022-01-11 18:44 ` Akhil Goyal
2022-01-12 10:30 ` Ananyev, Konstantin
2022-01-12 10:59 ` Akhil Goyal
2022-01-13 22:29 ` Ananyev, Konstantin
2022-01-13 13:18 ` Akhil Goyal
2022-01-13 14:36 ` Ananyev, Konstantin
2022-01-13 15:04 ` Akhil Goyal
2022-01-03 15:08 ` [PATCH 4/8] security: add IPsec option for " Akhil Goyal
2022-01-03 15:08 ` [PATCH 5/8] app/test: add unit cases for inline IPsec offload Akhil Goyal
2022-01-20 16:48 ` [PATCH v2 0/4] app/test: add inline IPsec and reassembly cases Akhil Goyal
2022-01-20 16:48 ` [PATCH v2 1/4] app/test: add unit cases for inline IPsec offload Akhil Goyal
2022-01-20 16:48 ` [PATCH v2 2/4] app/test: add IP reassembly case with no frags Akhil Goyal
2022-01-20 16:48 ` [PATCH v2 3/4] app/test: add IP reassembly cases with multiple fragments Akhil Goyal
2022-01-20 16:48 ` [PATCH v2 4/4] app/test: add IP reassembly negative cases Akhil Goyal
2022-02-17 17:23 ` [PATCH v3 0/4] app/test: add inline IPsec and reassembly cases Akhil Goyal
2022-02-17 17:23 ` [PATCH v3 1/4] app/test: add unit cases for inline IPsec offload Akhil Goyal
2022-02-17 17:23 ` [PATCH v3 2/4] app/test: add IP reassembly case with no frags Akhil Goyal
2022-02-17 17:23 ` [PATCH v3 3/4] app/test: add IP reassembly cases with multiple fragments Akhil Goyal
2022-02-17 17:23 ` [PATCH v3 4/4] app/test: add IP reassembly negative cases Akhil Goyal
2022-04-16 19:25 ` [PATCH v4 00/10] app/test: add inline IPsec and reassembly cases Akhil Goyal
2022-04-16 19:25 ` [PATCH v4 01/10] app/test: add unit cases for inline IPsec offload Akhil Goyal
2022-04-16 19:25 ` [PATCH v4 02/10] test/security: add inline inbound IPsec cases Akhil Goyal
2022-04-16 19:25 ` [PATCH v4 03/10] test/security: add combined mode inline " Akhil Goyal
2022-04-16 19:25 ` [PATCH v4 04/10] test/security: add inline IPsec reassembly cases Akhil Goyal
2022-04-16 19:25 ` [PATCH v4 05/10] test/security: add more inline IPsec functional cases Akhil Goyal
2022-04-16 19:25 ` [PATCH v4 06/10] test/security: add ESN and anti-replay cases for inline Akhil Goyal
2022-04-16 19:25 ` [PATCH v4 07/10] ethdev: add IPsec SA expiry event subtypes Akhil Goyal
2022-04-19 8:58 ` Thomas Monjalon
2022-04-19 10:14 ` [EXT] " Akhil Goyal
2022-04-19 10:19 ` Anoob Joseph
2022-04-19 10:37 ` Thomas Monjalon
2022-04-19 10:39 ` Anoob Joseph
2022-04-19 10:47 ` Thomas Monjalon
2022-04-19 12:27 ` Akhil Goyal
2022-04-19 15:41 ` Ray Kinsella
2022-04-20 13:51 ` Akhil Goyal
2022-09-24 13:57 ` [PATCH v5 0/3] Add and test IPsec SA expiry events Akhil Goyal
2022-09-24 13:57 ` [PATCH v5 1/3] ethdev: add IPsec SA expiry event subtypes Akhil Goyal
2022-09-24 14:02 ` Akhil Goyal
2022-09-26 14:02 ` Thomas Monjalon
2022-09-27 18:44 ` [EXT] " Akhil Goyal
2022-09-24 13:57 ` [PATCH v5 2/3] test/security: add inline IPsec SA soft expiry cases Akhil Goyal
2022-09-24 13:57 ` [PATCH v5 3/3] test/security: add inline IPsec SA hard " Akhil Goyal
2022-09-26 17:07 ` [PATCH v6 0/3] Add and test IPsec SA expiry events Akhil Goyal
2022-09-26 17:07 ` [PATCH v6 1/3] ethdev: add IPsec SA expiry event subtypes Akhil Goyal
2022-09-26 17:07 ` [PATCH v6 2/3] test/security: add inline IPsec SA soft expiry cases Akhil Goyal
2022-09-26 17:07 ` [PATCH v6 3/3] test/security: add inline IPsec SA hard " Akhil Goyal
2022-04-16 19:25 ` [PATCH v4 08/10] test/security: add inline IPsec SA soft " Akhil Goyal
2022-04-16 19:25 ` [PATCH v4 09/10] test/security: add inline IPsec SA hard " Akhil Goyal
2022-04-16 19:25 ` [PATCH v4 10/10] test/security: add inline IPsec IPv6 flow label cases Akhil Goyal
2022-04-18 3:44 ` Anoob Joseph
2022-04-18 3:55 ` Akhil Goyal
2022-04-25 12:38 ` [PATCH v4 00/10] app/test: add inline IPsec and reassembly cases Poczatek, Jakub
2022-04-27 15:10 ` [PATCH v5 0/7] " Akhil Goyal
2022-04-27 15:10 ` [PATCH v5 1/7] app/test: add unit cases for inline IPsec offload Akhil Goyal
2022-04-27 15:44 ` Zhang, Roy Fan
2022-04-27 15:10 ` [PATCH v5 2/7] test/security: add inline inbound IPsec cases Akhil Goyal
2022-04-27 15:44 ` Zhang, Roy Fan
2022-04-27 15:10 ` [PATCH v5 3/7] test/security: add combined mode inline " Akhil Goyal
2022-04-27 15:45 ` Zhang, Roy Fan
2022-04-27 15:10 ` [PATCH v5 4/7] test/security: add inline IPsec reassembly cases Akhil Goyal
2022-04-27 15:45 ` Zhang, Roy Fan
2022-04-27 15:10 ` [PATCH v5 5/7] test/security: add more inline IPsec functional cases Akhil Goyal
2022-04-27 15:46 ` Zhang, Roy Fan
2022-04-27 15:10 ` [PATCH v5 6/7] test/security: add ESN and anti-replay cases for inline Akhil Goyal
2022-04-27 15:46 ` Zhang, Roy Fan
2022-04-28 5:25 ` Anoob Joseph
2022-04-27 15:10 ` [PATCH v5 7/7] test/security: add inline IPsec IPv6 flow label cases Akhil Goyal
2022-04-27 15:46 ` Zhang, Roy Fan
2022-04-27 15:42 ` [PATCH v5 0/7] app/test: add inline IPsec and reassembly cases Zhang, Roy Fan
2022-05-13 7:31 ` [PATCH v6 " Akhil Goyal
2022-05-13 7:31 ` [PATCH v6 1/7] app/test: add unit cases for inline IPsec offload Akhil Goyal
2022-05-13 7:31 ` [PATCH v6 2/7] test/security: add inline inbound IPsec cases Akhil Goyal
2022-05-13 7:31 ` [PATCH v6 3/7] test/security: add combined mode inline " Akhil Goyal
2022-05-13 7:31 ` [PATCH v6 4/7] test/security: add inline IPsec reassembly cases Akhil Goyal
2022-05-13 7:31 ` [PATCH v6 5/7] test/security: add more inline IPsec functional cases Akhil Goyal
2022-05-13 7:32 ` [PATCH v6 6/7] test/security: add ESN and anti-replay cases for inline Akhil Goyal
2022-05-13 7:32 ` [PATCH v6 7/7] test/security: add inline IPsec IPv6 flow label cases Akhil Goyal
2022-05-24 7:22 ` [PATCH v7 0/7] app/test: add inline IPsec and reassembly cases Akhil Goyal
2022-05-24 7:22 ` [PATCH v7 1/7] app/test: add unit cases for inline IPsec offload Akhil Goyal
2022-05-24 7:22 ` [PATCH v7 2/7] test/security: add inline inbound IPsec cases Akhil Goyal
2022-05-24 7:22 ` [PATCH v7 3/7] test/security: add combined mode inline " Akhil Goyal
2022-05-24 7:22 ` [PATCH v7 4/7] test/security: add inline IPsec reassembly cases Akhil Goyal
2022-05-24 7:22 ` [PATCH v7 5/7] test/security: add more inline IPsec functional cases Akhil Goyal
2022-05-24 7:22 ` [PATCH v7 6/7] test/security: add ESN and anti-replay cases for inline Akhil Goyal
2022-05-24 7:22 ` [PATCH v7 7/7] test/security: add inline IPsec IPv6 flow label cases Akhil Goyal
2022-05-24 8:05 ` [PATCH v7 0/7] app/test: add inline IPsec and reassembly cases Anoob Joseph
2022-05-24 9:38 ` Akhil Goyal
2022-01-03 15:08 ` [PATCH 6/8] app/test: add IP reassembly case with no frags Akhil Goyal
2022-01-03 15:08 ` [PATCH 7/8] app/test: add IP reassembly cases with multiple fragments Akhil Goyal
2022-01-03 15:08 ` [PATCH 8/8] app/test: add IP reassembly negative cases Akhil Goyal
2022-01-06 9:51 ` [PATCH 0/8] ethdev: introduce IP reassembly offload David Marchand
2022-01-06 9:54 ` [EXT] " Akhil Goyal
2022-01-20 16:26 ` [PATCH v2 0/4] " Akhil Goyal
2022-01-20 16:26 ` [PATCH v2 1/4] " Akhil Goyal
2022-01-20 16:45 ` Stephen Hemminger
2022-01-20 17:11 ` [EXT] " Akhil Goyal
2022-01-20 16:26 ` [PATCH v2 2/4] ethdev: add dev op to set/get IP reassembly configuration Akhil Goyal
2022-01-22 8:17 ` Andrew Rybchenko
2022-01-30 16:30 ` [EXT] " Akhil Goyal
2022-01-20 16:26 ` [PATCH v2 3/4] ethdev: add mbuf dynfield for incomplete IP reassembly Akhil Goyal
2022-01-20 16:26 ` [PATCH v2 4/4] security: add IPsec option for " Akhil Goyal
2022-01-30 17:59 ` [PATCH v3 0/4] ethdev: introduce IP reassembly offload Akhil Goyal
2022-01-30 17:59 ` [PATCH v3 1/4] " Akhil Goyal
2022-02-01 14:11 ` Ferruh Yigit
2022-02-02 10:57 ` [EXT] " Akhil Goyal
2022-02-02 14:05 ` Ferruh Yigit
2022-01-30 17:59 ` [PATCH v3 2/4] ethdev: add dev op to set/get IP reassembly configuration Akhil Goyal
2022-01-30 17:59 ` [PATCH v3 3/4] ethdev: add mbuf dynfield for incomplete IP reassembly Akhil Goyal
2022-02-01 14:11 ` Ferruh Yigit
2022-02-02 9:13 ` [EXT] " Akhil Goyal
2022-01-30 17:59 ` [PATCH v3 4/4] security: add IPsec option for " Akhil Goyal
2022-02-01 14:12 ` Ferruh Yigit
2022-02-02 9:15 ` [EXT] " Akhil Goyal
2022-02-02 14:04 ` Ferruh Yigit
2022-02-01 14:10 ` [PATCH v3 0/4] ethdev: introduce IP reassembly offload Ferruh Yigit
2022-02-02 9:05 ` [EXT] " Akhil Goyal
2022-02-04 22:13 ` [PATCH v4 0/3] " Akhil Goyal
2022-02-04 22:13 ` [PATCH v4 1/3] " Akhil Goyal
2022-02-04 22:20 ` Akhil Goyal
2022-02-07 13:53 ` Ferruh Yigit
2022-02-07 14:36 ` [EXT] " Akhil Goyal
2022-02-04 22:13 ` [PATCH v4 2/3] ethdev: add mbuf dynfield for incomplete IP reassembly Akhil Goyal
2022-02-07 13:58 ` Ferruh Yigit
2022-02-07 14:20 ` [EXT] " Akhil Goyal
2022-02-07 14:56 ` Ferruh Yigit
2022-02-07 16:20 ` Akhil Goyal
2022-02-07 16:41 ` Ferruh Yigit
2022-02-07 17:17 ` Akhil Goyal
2022-02-07 17:23 ` Stephen Hemminger
2022-02-07 17:28 ` Ferruh Yigit
2022-02-07 18:01 ` Stephen Hemminger
2022-02-07 18:28 ` [EXT] " Akhil Goyal
2022-02-07 19:08 ` Stephen Hemminger
2022-02-07 17:29 ` Akhil Goyal
2022-02-04 22:13 ` [PATCH v4 3/3] security: add IPsec option for " Akhil Goyal
2022-02-08 9:01 ` David Marchand
2022-02-08 9:18 ` [EXT] " Akhil Goyal
2022-02-08 9:27 ` David Marchand
2022-02-08 10:45 ` Akhil Goyal
2022-02-08 13:19 ` Akhil Goyal
2022-02-08 19:55 ` David Marchand
2022-02-08 20:01 ` Akhil Goyal
2022-02-08 20:11 ` [PATCH v5 0/3] ethdev: introduce IP reassembly offload Akhil Goyal
2022-02-08 20:11 ` [PATCH v5 1/3] " Akhil Goyal
2022-02-08 20:11 ` [PATCH v5 2/3] ethdev: add mbuf dynfield for incomplete IP reassembly Akhil Goyal
2022-02-08 20:11 ` [PATCH v5 3/3] security: add IPsec option for " Akhil Goyal
2022-02-08 22:20 ` [PATCH v6 0/3] ethdev: introduce IP reassembly offload Akhil Goyal
2022-02-08 22:20 ` [PATCH v6 1/3] " Akhil Goyal
2022-02-10 8:54 ` Ferruh Yigit
2022-02-10 10:08 ` Andrew Rybchenko
2022-02-10 10:20 ` Ferruh Yigit
2022-02-10 10:30 ` Ferruh Yigit
2022-02-08 22:20 ` [PATCH v6 2/3] ethdev: add mbuf dynfield for incomplete IP reassembly Akhil Goyal
2022-02-10 8:54 ` Ferruh Yigit
2022-02-08 22:20 ` [PATCH v6 3/3] security: add IPsec option for " Akhil Goyal
2022-02-10 8:54 ` [PATCH v6 0/3] ethdev: introduce IP reassembly offload Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR11MB449187429CFDF5E1ADDACAD59A519@DM6PR11MB4491.namprd11.prod.outlook.com \
--to=konstantin.ananyev@intel.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=anoobj@marvell.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=gakhil@marvell.com \
--cc=hemant.agrawal@nxp.com \
--cc=matan@nvidia.com \
--cc=olivier.matz@6wind.com \
--cc=radu.nicolau@intel.com \
--cc=rosen.xu@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).