From: Raslan Darawsheh <rasland@nvidia.com>
To: Dekel Peled <dekelp@nvidia.com>,
Slava Ovsiienko <viacheslavo@nvidia.com>,
Shahaf Shuler <shahafs@nvidia.com>,
Matan Azrad <matan@nvidia.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix aging queue doorbell ringing
Date: Sun, 8 Nov 2020 09:11:07 +0000 [thread overview]
Message-ID: <DM6PR12MB2748A57D49B48AC2496E1EBBCFEB0@DM6PR12MB2748.namprd12.prod.outlook.com> (raw)
In-Reply-To: <b69e3eebf09c80a032e8f2c5a97aed468d8c0976.1604399810.git.dekelp@nvidia.com>
Hi,
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Dekel Peled
> Sent: Tuesday, November 3, 2020 12:38 PM
> To: Slava Ovsiienko <viacheslavo@nvidia.com>; Shahaf Shuler
> <shahafs@nvidia.com>; Matan Azrad <matan@nvidia.com>
> Cc: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] net/mlx5: fix aging queue doorbell ringing
>
> Recent patch introduced a new SQ for ASO flow hit management.
> This SQ uses two WQEBB's for each WQE.
> The SQ producer index is 16 bits wide.
>
> The enqueue loop posts new WQEs to the ASO SQ, using WQE index for
> the SQ management.
> This 16 bits index multiplied by 2 was wrongly used also for SQ
> doorbell ringing.
> The multiplication caused the SW index overlapping to be out of sync
> with the hardware index, causing it to get stuck.
>
> This patch separates the WQE index management from the doorbell index
> management.
> So, for each WQE index incrementation by 1, the doorbell index is
> incremented by 2.
>
> Fixes: 18c88cf29c29 ("net/mlx5: support flow hit action for aging")
>
> Signed-off-by: Dekel Peled <dekelp@nvidia.com>
> Acked-by: Matan Azrad <matan@nvidia.com>
> ---
> drivers/common/mlx5/mlx5_prm.h | 21 +++++++++++++------
> drivers/net/mlx5/mlx5.h | 3 ++-
> drivers/net/mlx5/mlx5_flow_age.c | 36 ++++++++++++++++++--------------
> 3 files changed, 37 insertions(+), 23 deletions(-)
>
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
prev parent reply other threads:[~2020-11-08 9:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-03 10:38 Dekel Peled
2020-11-08 9:11 ` Raslan Darawsheh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR12MB2748A57D49B48AC2496E1EBBCFEB0@DM6PR12MB2748.namprd12.prod.outlook.com \
--to=rasland@nvidia.com \
--cc=dekelp@nvidia.com \
--cc=dev@dpdk.org \
--cc=matan@nvidia.com \
--cc=shahafs@nvidia.com \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).