From: Slava Ovsiienko <viacheslavo@nvidia.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>,
Gregory Etelson <getelson@nvidia.com>, Ori Kam <orika@nvidia.com>
Cc: Matan Azrad <matan@nvidia.com>,
Raslan Darawsheh <rasland@nvidia.com>,
Xiaoyun Li <xiaoyun.li@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix flex item flush
Date: Fri, 5 Nov 2021 17:03:15 +0000 [thread overview]
Message-ID: <DM6PR12MB37531081C92A74F16A94A9F2DF8E9@DM6PR12MB3753.namprd12.prod.outlook.com> (raw)
In-Reply-To: <489cf220-720f-985e-5982-78db17b2845d@intel.com>
> -----Original Message-----
> From: Ferruh Yigit <ferruh.yigit@intel.com>
> Sent: Friday, November 5, 2021 17:57
> To: Gregory Etelson <getelson@nvidia.com>; Slava Ovsiienko
> <viacheslavo@nvidia.com>; Ori Kam <orika@nvidia.com>
> Cc: Matan Azrad <matan@nvidia.com>; Raslan Darawsheh
> <rasland@nvidia.com>; Xiaoyun Li <xiaoyun.li@intel.com>; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix flex item flush
>
> On 10/26/2021 4:20 PM, Gregory Etelson wrote:
> > Testpmd provides 2 sets of flex item create and destroy functions One
> > for hosts with JSON library. These functions parse flex item
> > configuration stored in JSON file and create or destroy flex item
> > object. The second functions set is for hosts without JSON library for
> > compilation compatibility.
> >
> > On hosts without JSON library, current implementation issues "no JSON
> > library" notification on port close.
> > The notification was triggered by port destructors that include flex
> > items flush routine.
> >
> > The patch introduces single implementation for testpmd flex item
> > destroy.
> >
> > Fixes: 59f3a8acbcdb ("app/testpmd: add flex item commands")
> > Signed-off-by: Gregory Etelson<getelson@nvidia.com>
>
> Hi Viacheslav, Ori,
>
> Can you please help on reviewing this patch?
Reviewed-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
I've already reviewed this one internally, so just posting the confirmation.
As for maintainership of cmd_flex_item.c - we talked with Ori, he don't
mind if I would take the responsibility for this. What should we do for that? Send patch
to update MAINTAINERS ?
With best regards,
Slava
next prev parent reply other threads:[~2021-11-05 17:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-26 15:20 Gregory Etelson
2021-11-03 19:12 ` Ferruh Yigit
2021-11-05 15:56 ` Ferruh Yigit
2021-11-05 17:03 ` Slava Ovsiienko [this message]
2021-11-05 18:56 ` Ferruh Yigit
2021-11-05 21:21 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR12MB37531081C92A74F16A94A9F2DF8E9@DM6PR12MB3753.namprd12.prod.outlook.com \
--to=viacheslavo@nvidia.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=getelson@nvidia.com \
--cc=matan@nvidia.com \
--cc=orika@nvidia.com \
--cc=rasland@nvidia.com \
--cc=xiaoyun.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).