From: Slava Ovsiienko <viacheslavo@nvidia.com>
To: Dmitry Kozlyuk <dkozlyuk@nvidia.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: Matan Azrad <matan@nvidia.com>, "stable@dpdk.org" <stable@dpdk.org>
Subject: RE: [PATCH 2/2] common/mlx5: fix multi-process mempool registration
Date: Sun, 28 Aug 2022 18:34:47 +0000 [thread overview]
Message-ID: <DM6PR12MB3753B55035F21CFBD1543B6CDF779@DM6PR12MB3753.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20220808094236.3395516-3-dkozlyuk@nvidia.com>
> -----Original Message-----
> From: Dmitry Kozlyuk <dkozlyuk@nvidia.com>
> Sent: Monday, August 8, 2022 12:43
> To: dev@dpdk.org
> Cc: Matan Azrad <matan@nvidia.com>; Slava Ovsiienko
> <viacheslavo@nvidia.com>; stable@dpdk.org
> Subject: [PATCH 2/2] common/mlx5: fix multi-process mempool registration
>
> The `mp_cb_registered` flag shared between all processes was used to ensure
> that for any IB device (MLX5 common device) mempool event callback was
> registered only once and mempools that had been existing before the device
> start were traversed only once to register them.
> Since mempool callback registrations have become process-private, callback
> registration must be done by every process.
> The flag can no longer reflect the state for any single process.
> Replace it with a registration counter to track when no more callbacks are
> registered for the device in any process.
> It is sufficient to only register pre-existing mempools in the primary
> process because it is the one that starts the device.
>
> Fixes: 690b2a88c2f7 ("common/mlx5: add mempool registration facilities")
> Cc: stable@dpdk.org
>
> Signed-off-by: Dmitry Kozlyuk <dkozlyuk@nvidia.com>
Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
prev parent reply other threads:[~2022-08-28 18:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220808094236.3395516-1-dkozlyuk@nvidia.com>
2022-08-08 9:42 ` [PATCH 1/2] mempool: make event callbacks process-private Dmitry Kozlyuk
2022-08-28 18:33 ` Slava Ovsiienko
2022-10-10 8:02 ` Andrew Rybchenko
2022-09-22 7:31 ` Dmitry Kozlyuk
2022-08-08 9:42 ` [PATCH 2/2] common/mlx5: fix multi-process mempool registration Dmitry Kozlyuk
2022-08-28 18:34 ` Slava Ovsiienko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR12MB3753B55035F21CFBD1543B6CDF779@DM6PR12MB3753.namprd12.prod.outlook.com \
--to=viacheslavo@nvidia.com \
--cc=dev@dpdk.org \
--cc=dkozlyuk@nvidia.com \
--cc=matan@nvidia.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).