DPDK patches and discussions
 help / color / mirror / Atom feed
From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: Vidya Sagar Velumuri <vvelumuri@marvell.com>,
	"adwivedi@marvell.com" <adwivedi@marvell.com>,
	"anoobj@marvell.com" <anoobj@marvell.com>,
	"ktejasree@marvell.com" <ktejasree@marvell.com>,
	"ndabilpuram@marvell.com" <ndabilpuram@marvell.com>,
	"gakhil@marvell.com" <gakhil@marvell.com>,
	"Zhang,  Roy Fan" <roy.fan.zhang@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] test/crypto: fix: test vectors for zuc 256 bit key
Date: Wed, 3 Nov 2021 09:28:12 +0000	[thread overview]
Message-ID: <DM8PR11MB55914266CDF9028881F53E7A848C9@DM8PR11MB5591.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20211103065506.2690-1-vvelumuri@marvell.com>

Hi Sagar,

> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Vidya Sagar Velumuri
> Sent: Wednesday, November 3, 2021 6:55 AM
> To: adwivedi@marvell.com; anoobj@marvell.com; ktejasree@marvell.com;
> ndabilpuram@marvell.com; gakhil@marvell.com; Zhang, Roy Fan
> <roy.fan.zhang@intel.com>
> Cc: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH v2] test/crypto: fix: test vectors for zuc 256 bit key
> 
> Fix the test vectors added for zuc 256-bit key Add known vectores form ZUC 256
> RFC.
> 
> Fixes: fa5bf9345d4e (test/crypto: add ZUC cases with 256-bit keys)
> 
> Signed-off-by: Vidya Sagar Velumuri <vvelumuri@marvell.com>

Thanks for these new vectors. Looks like they pass for us. However, I notice that your driver still has 24-byte IV capability for ZUC,
instead of 25 bytes. Is this OK for you? I added some code to check if the IV of a test vector is supported by a device.

Thanks,
Pablo


  reply	other threads:[~2021-11-03  9:28 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-27  8:40 [dpdk-dev] [PATCH v1] " Vidya Sagar Velumuri
2021-10-28  7:10 ` Akhil Goyal
2021-10-29 12:37 ` De Lara Guarch, Pablo
2021-10-30 12:25   ` Vidya Sagar Velumuri
2021-10-31 22:06     ` De Lara Guarch, Pablo
2021-11-01 10:23       ` Vidya Sagar Velumuri
2021-11-02  4:40         ` Vidya Sagar Velumuri
2021-11-02 11:17           ` De Lara Guarch, Pablo
2021-11-03  6:55 ` [dpdk-dev] [PATCH v2] " Vidya Sagar Velumuri
2021-11-03  9:28   ` De Lara Guarch, Pablo [this message]
2021-11-03  9:31   ` [dpdk-dev] [PATCH v3] " Vidya Sagar Velumuri
2021-11-04 10:52     ` Akhil Goyal
2021-11-04 12:18       ` De Lara Guarch, Pablo
2021-11-04 18:38         ` Akhil Goyal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM8PR11MB55914266CDF9028881F53E7A848C9@DM8PR11MB5591.namprd11.prod.outlook.com \
    --to=pablo.de.lara.guarch@intel.com \
    --cc=adwivedi@marvell.com \
    --cc=anoobj@marvell.com \
    --cc=dev@dpdk.org \
    --cc=gakhil@marvell.com \
    --cc=ktejasree@marvell.com \
    --cc=ndabilpuram@marvell.com \
    --cc=roy.fan.zhang@intel.com \
    --cc=vvelumuri@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).