DPDK patches and discussions
 help / color / mirror / Atom feed
From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: "Dooley, Brian" <brian.dooley@intel.com>, "Ji, Kai" <kai.ji@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"gakhil@marvell.com" <gakhil@marvell.com>,
	 "Dooley, Brian" <brian.dooley@intel.com>
Subject: RE: [PATCH v4] crypto/qat: default to IPsec MB for computations
Date: Fri, 2 Jun 2023 11:24:57 +0000	[thread overview]
Message-ID: <DM8PR11MB559149C228F09A98751D9EBD844EA@DM8PR11MB5591.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20230526102650.774625-1-brian.dooley@intel.com>

Hi Brian,

> -----Original Message-----
> From: Brian Dooley <brian.dooley@intel.com>
> Sent: Friday, May 26, 2023 11:27 AM
> To: Ji, Kai <kai.ji@intel.com>
> Cc: dev@dpdk.org; gakhil@marvell.com; Dooley, Brian
> <brian.dooley@intel.com>
> Subject: [PATCH v4] crypto/qat: default to IPsec MB for computations
> 
> Pre and post computations currently use the OpenSSL library by default.
> This patch changes the default option to Intel IPsec MB library version
> 1.4 for the required computations. If this version of IPsec is not met
> it will fallback to use OpenSSL.
> 
> Added version checks for libipsecmb and libcrypto into meson build.
> Added directives for detecting IPsec MB or OpenSSL.
> 

..

> +++ b/drivers/crypto/qat/qat_sym_session.c
> @@ -9,7 +9,7 @@
>  #include <openssl/md5.h>	/* Needed to calculate pre-compute values */
>  #include <openssl/evp.h>	/* Needed for bpi runt block processing */
> 
> -#ifdef RTE_QAT_LIBIPSECMB
> +#ifndef RTE_QAT_OPENSSL
>  #define NO_COMPAT_IMB_API_053

We have removed this macro in IPSec MB 1.4, so no need to define it.

>  #if defined(RTE_ARCH_ARM)
>  #include <ipsec-mb.h>
> @@ -34,6 +34,7 @@
>  #include "qat_sym_session.h"
>  #include "qat_sym.h"

Apart from this:

Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>

  reply	other threads:[~2023-06-02 11:25 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-18 15:23 [PATCH v1] crypto/qat: add IPsec MB AES and DES Docsis support Brian Dooley
2023-05-19 10:50 ` [PATCH v2] crypto/qat: default to IPsec MB for pre and post computes Brian Dooley
2023-05-22 14:39   ` [PATCH v3] " Brian Dooley
2023-05-23 14:10     ` Ji, Kai
2023-05-25  7:28     ` [EXT] " Akhil Goyal
2023-05-26 10:26     ` [PATCH v4] crypto/qat: default to IPsec MB for computations Brian Dooley
2023-06-02 11:24       ` De Lara Guarch, Pablo [this message]
2023-06-06 10:28       ` [PATCH v5] " Brian Dooley
2023-06-08 12:25         ` Power, Ciara
2023-06-14 18:23         ` [EXT] " Akhil Goyal
2023-06-16 16:02         ` [PATCH v6] " Brian Dooley
2023-06-20 10:56           ` [PATCH v7] " Brian Dooley
2023-06-20 12:43             ` [EXT] " Akhil Goyal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM8PR11MB559149C228F09A98751D9EBD844EA@DM8PR11MB5591.namprd11.prod.outlook.com \
    --to=pablo.de.lara.guarch@intel.com \
    --cc=brian.dooley@intel.com \
    --cc=dev@dpdk.org \
    --cc=gakhil@marvell.com \
    --cc=kai.ji@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).