From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: "Sivaramakrishnan, VenkatX" <venkatx.sivaramakrishnan@intel.com>,
"Ji, Kai" <kai.ji@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: RE: [PATCH v1] crypto/ipsec_mb: upgrade IPsec Multi-buffer to 1.4
Date: Thu, 25 Jan 2024 20:10:35 +0000 [thread overview]
Message-ID: <DM8PR11MB55919486B68A2667E5239CFC847A2@DM8PR11MB5591.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20240119114026.1552305-1-venkatx.sivaramakrishnan@intel.com>
Hi Venkat,
> -----Original Message-----
> From: Sivaramakrishnan, VenkatX <venkatx.sivaramakrishnan@intel.com>
> Sent: Friday, January 19, 2024 11:40 AM
> To: Ji, Kai <kai.ji@intel.com>; De Lara Guarch, Pablo
> <pablo.de.lara.guarch@intel.com>
> Cc: dev@dpdk.org; Sivaramakrishnan, VenkatX
> <venkatx.sivaramakrishnan@intel.com>
> Subject: [PATCH v1] crypto/ipsec_mb: upgrade IPsec Multi-buffer to 1.4
Could you change the commit title to "bump minimum IPSec Multi-buffer version"
>
> SW PMDs do not support IPsec Multi-buffer version 1.3 and less.
I wouldn't say this is correct. The PMDs support these versions, but this patch is bumping the minimum
version to make the code more maintainable (it's simpler) and to force users to use a newer library
(which includes bugfixes and performance optimizations), with more algorithms enabled (win-win situation).
> A minimum IPsec Multi-buffer version of 1.4 or greater is now required.
>
> Signed-off-by: Sivaramakrishnan Venkat
> <venkatx.sivaramakrishnan@intel.com>
> ---
A couple of things more:
- Could you update the AESNI MB (aesni_mb.rst) documentation to show this change (the version compatibility table)?
- There is a macro not needed any longer in ipsec_mb_ops.c: IMB_MP_REQ_VER_STR.
Thanks!
Pablo
next prev parent reply other threads:[~2024-01-25 20:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-19 11:40 Sivaramakrishnan Venkat
2024-01-23 11:42 ` Power, Ciara
2024-01-25 20:10 ` De Lara Guarch, Pablo [this message]
2024-01-30 14:24 ` [PATCH v2] crypto/ipsec_mb: bump minimum IPSec Multi-buffer version Sivaramakrishnan Venkat
2024-02-02 14:04 ` [PATCH v3 1/2] crypto/ipsec_mb: bump minimum IPsec " Sivaramakrishnan Venkat
2024-02-02 14:04 ` [PATCH v3 2/2] doc: remove outdated version details Sivaramakrishnan Venkat
2024-02-02 15:56 ` De Lara Guarch, Pablo
2024-02-02 15:56 ` [PATCH v3 1/2] crypto/ipsec_mb: bump minimum IPsec Multi-buffer version De Lara Guarch, Pablo
2024-02-22 17:39 ` [EXT] " Akhil Goyal
2024-02-23 12:29 ` [PATCH v4 " Sivaramakrishnan Venkat
2024-02-23 12:29 ` [PATCH v4 2/2] doc: remove outdated version details Sivaramakrishnan Venkat
2024-03-05 15:10 ` Wathsala Wathawana Vithanage
2024-03-05 15:13 ` [PATCH v4 1/2] crypto/ipsec_mb: bump minimum IPsec Multi-buffer version Wathsala Wathawana Vithanage
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM8PR11MB55919486B68A2667E5239CFC847A2@DM8PR11MB5591.namprd11.prod.outlook.com \
--to=pablo.de.lara.guarch@intel.com \
--cc=dev@dpdk.org \
--cc=kai.ji@intel.com \
--cc=venkatx.sivaramakrishnan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).