From: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>
To: "Zhang, Qi Z" <qi.z.zhang@intel.com>,
"Singh, Aman Deep" <aman.deep.singh@intel.com>,
"Zhang, Yuying" <yuying.zhang@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"orika@nvidia.com" <orika@nvidia.com>,
"ferruh.yigit@amd.com" <ferruh.yigit@amd.com>
Subject: RE: [PATCH v3] app/testpmd: enable cli for programmable action
Date: Fri, 6 Oct 2023 12:35:48 +0000 [thread overview]
Message-ID: <DS0PR11MB74429917477E783FE150105CEBC9A@DS0PR11MB7442.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20231006110714.338910-1-qi.z.zhang@intel.com>
Hi Qi,
<snip>
>
> +#define ACTION_PROG_NAME_SIZE_MAX 32
> +#define ACTION_PROG_ARG_NUM_MAX 16
> +#define ACTION_PROG_ARG_VALUE_SIZE_MAX 32
Let's be a bit more generous with some of these sizes, please.
The action name might be hierarchical, i.e. include the control block and table path separated by dots, e.g. "dev5.ingress.forwarding.routing_table.set_next_hop", so:
#define ACTION_PROG_NAME_SIZE_MAX 256
Some parameters could be 128-bit IPv6 addresses, which may be specified in hex with additional characters such as '0x' or ':', so:
#define ACTION_PROG_ARG_VALUE_SIZE_MAX 64
<snip>
Regards,
Cristian
next prev parent reply other threads:[~2023-10-06 12:35 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-05 10:02 [PATCH 1/2] " Qi Zhang
2023-10-05 11:42 ` [PATCH v2] " Qi Zhang
2023-10-05 4:32 ` Stephen Hemminger
2023-10-06 2:37 ` Zhang, Qi Z
2023-10-06 11:07 ` [PATCH v3] " Qi Zhang
2023-10-06 12:35 ` Dumitrescu, Cristian [this message]
2023-10-07 1:50 ` Zhang, Qi Z
2023-10-07 10:47 ` [PATCH v4] " Qi Zhang
2023-10-08 0:06 ` Dumitrescu, Cristian
2023-10-10 10:49 ` Ferruh Yigit
2023-10-11 2:24 ` Zhang, Qi Z
2023-10-11 10:20 ` Ferruh Yigit
2023-10-11 13:19 ` Zhang, Qi Z
2023-10-12 0:04 ` Zhang, Qi Z
2023-10-12 1:32 ` Stephen Hemminger
2023-10-27 11:06 ` Zhang, Qi Z
2023-10-11 11:58 ` [PATCH v5] " Qi Zhang
2023-10-11 12:03 ` [PATCH v6] " Qi Zhang
2024-02-08 1:10 ` Ferruh Yigit
2024-04-18 15:39 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DS0PR11MB74429917477E783FE150105CEBC9A@DS0PR11MB7442.namprd11.prod.outlook.com \
--to=cristian.dumitrescu@intel.com \
--cc=aman.deep.singh@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=orika@nvidia.com \
--cc=qi.z.zhang@intel.com \
--cc=yuying.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).