From: Alan Elder <alan.elder@microsoft.com>
To: Long Li <longli@microsoft.com>, stephen <stephen@networkplumber.org>
Cc: Ferruh Yigit <ferruh.yigit@amd.com>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: RE: [PATCH] net/netvsc: fix number Tx queues > Rx queues
Date: Fri, 8 Mar 2024 18:21:56 +0000 [thread overview]
Message-ID: <DU0PR83MB053263D868E3B8D5A894DEED97272@DU0PR83MB0532.EURPRD83.prod.outlook.com> (raw)
In-Reply-To: <SJ1PR21MB34572B93500F6265A337B5A0CE5E2@SJ1PR21MB3457.namprd21.prod.outlook.com>
> Subject: RE: [PATCH] net/netvsc: fix number Tx queues > Rx queues
>
> > Subject: Re: [PATCH] net/netvsc: fix number Tx queues > Rx queues
> >
> > On Thu, 29 Feb 2024 19:29:11 +0000
> > Alan Elder <alan.elder@microsoft.com> wrote:
> >
> > > The previous code allowed the number of Tx queues to be set higher
> > > than the number of Rx queues. If a packet was sent on a Tx queue
> > > with index
> > > >= number Rx queues there was a segfault.
> > >
> > > This commit fixes the issue by creating an Rx queue for every Tx
> > > queue meaning that an event buffer is allocated to handle receiving
> > > Tx completion messages.
> > >
> > > mbuf pool and Rx ring are not allocated for these additional Rx
> > > queues and RSS configuration ensures that no packets are received on
> them.
> > >
> > > Fixes: 4e9c73e96e83 ("net/netvsc: add Hyper-V network device")
> > > Cc: sthemmin@microsoft.com
> > > Cc: stable@dpdk.org
> > >
> > > Signed-off-by: Alan Elder <alan.elder@microsoft.com>
> >
> > Don't have Azure account to test, but looks good to me.
> >
> > Acked-by: Stephen Hemminger <stephen@networkplumber.org>
>
> Please hold on while we are discussing this patch internally with its interaction
> with MANA.
>
> Long
Thanks for the feedback Long and Stephen. We've discussed the interaction with MANA and I think we're good to go ahead with this now. I've submitted v2 of the patch with a minor fix.
Cheers,
Alan
next prev parent reply other threads:[~2024-03-08 18:22 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-29 19:29 Alan Elder
2024-02-29 21:53 ` Stephen Hemminger
2024-03-01 2:03 ` Long Li
2024-03-08 18:21 ` Alan Elder [this message]
2024-03-08 18:09 ` [PATCH v2] " Alan Elder
2024-03-11 22:31 ` Ferruh Yigit
2024-03-12 19:08 ` Long Li
2024-03-19 14:16 ` [PATCH v3] " Alan Elder
2024-03-19 18:40 ` Long Li
2024-04-11 11:38 ` Ferruh Yigit
2024-04-11 20:45 ` [EXTERNAL] " Alan Elder
2024-04-12 10:23 ` Ferruh Yigit
2024-04-12 16:50 ` Alan Elder
2024-04-15 17:54 ` Ferruh Yigit
2024-04-15 14:40 ` [PATCH v4] " Alan Elder
2024-04-15 18:11 ` Ferruh Yigit
2024-04-17 23:45 ` Long Li
2024-05-01 7:43 ` Morten Brørup
2024-03-19 14:19 ` [PATCH v2] " Alan Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DU0PR83MB053263D868E3B8D5A894DEED97272@DU0PR83MB0532.EURPRD83.prod.outlook.com \
--to=alan.elder@microsoft.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=longli@microsoft.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).