From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>,
"Qiu, Michael" <michael.qiu@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] testpmd: Fix wrong message when no port started
Date: Wed, 25 Mar 2015 12:34:43 +0000 [thread overview]
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8972727C1A1@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <3096315.kVbCiLpmZB@xps13>
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Monday, March 23, 2015 1:53 PM
> To: Qiu, Michael; De Lara Guarch, Pablo
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] testpmd: Fix wrong message when no port
> started
>
> Pablo, what is your opinion on this patch?
Sorry for the delay, I missed this email.
>
> 2015-02-03 16:37, Michael Qiu:
> > The log message is wrong when no port started.
> >
> > Signed-off-by: Michael Qiu <michael.qiu@intel.com>
> > ---
> > app/test-pmd/testpmd.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
> > index 773b8af..ebf9448 100644
> > --- a/app/test-pmd/testpmd.c
> > +++ b/app/test-pmd/testpmd.c
> > @@ -1423,7 +1423,7 @@ start_port(portid_t pid)
> > if (need_check_link_status && !no_link_check)
> > check_all_ports_link_status(nb_ports, RTE_PORT_ALL);
> > else
> > - printf("Please stop the ports first\n");
> > + printf("Please start at least one port first\n");
>
> Why the word "first"?
> What could lead to this situation? Wrong pid?
> Shouldn't be an error returned?
I see no reason why we should change this.
Code has changed since, so now it only goes there if user is trying to start a port that has been already started.
If pid is wrong, it will show "Port invalid".
So, in a summary, NACK.
Thanks,
Pablo
>
> >
> > printf("Done\n");
> > return 0;
>
prev parent reply other threads:[~2015-03-25 12:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-03 8:37 Michael Qiu
2015-03-23 13:52 ` Thomas Monjalon
2015-03-25 12:34 ` De Lara Guarch, Pablo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E115CCD9D858EF4F90C690B0DCB4D8972727C1A1@IRSMSX108.ger.corp.intel.com \
--to=pablo.de.lara.guarch@intel.com \
--cc=dev@dpdk.org \
--cc=michael.qiu@intel.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).