From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: "Zhang, Helin" <helin.zhang@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 2/3] i40e: fix ICC compile issue
Date: Fri, 6 Nov 2015 08:11:29 +0000 [thread overview]
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8973C8458EE@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <1446796116-1219-3-git-send-email-helin.zhang@intel.com>
Hi Helin,
> -----Original Message-----
> From: Zhang, Helin
> Sent: Friday, November 06, 2015 7:49 AM
> To: dev@dpdk.org
> Cc: De Lara Guarch, Pablo; Zhang, Helin
> Subject: [PATCH 2/3] i40e: fix ICC compile issue
>
> It fixes compile issue on ICC 13.0.0.
>
> Error logs:
> i40e_ethdev.c(7943): error #188: enumerated type mixed with another type
> PMD_INIT_LOG(ERR,
>
> Signed-off-by: Helin Zhang <helin.zhang@intel.com>
> ---
> drivers/net/i40e/i40e_ethdev.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
> index ddf3d38..8c1809a 100644
> --- a/drivers/net/i40e/i40e_ethdev.c
> +++ b/drivers/net/i40e/i40e_ethdev.c
> @@ -7942,7 +7942,7 @@ i40e_vsi_get_bw_info(struct i40e_vsi *vsi)
> if (ret) {
> PMD_INIT_LOG(ERR,
> "couldn't get PF vsi bw config, err %s aq_err %s\n",
> - i40e_stat_str(hw, ret),
> + i40e_stat_str(hw, (enum i40e_status_code)ret),
> i40e_aq_str(hw, hw->aq.asq_last_status));
> return -EINVAL;
> }
> @@ -7953,7 +7953,7 @@ i40e_vsi_get_bw_info(struct i40e_vsi *vsi)
> if (ret) {
> PMD_INIT_LOG(ERR,
> "couldn't get PF vsi ets bw config, err %s aq_err
> %s\n",
> - i40e_stat_str(hw, ret),
> + i40e_stat_str(hw, (enum i40e_status_code)ret),
> i40e_aq_str(hw, hw->aq.asq_last_status));
> return -EINVAL;
> }
> @@ -8122,7 +8122,7 @@ i40e_vsi_config_tc(struct i40e_vsi *vsi, u8 tc_map)
> if (ret) {
> PMD_INIT_LOG(ERR,
> "Failed updating vsi bw info, err %s aq_err %s",
> - i40e_stat_str(hw, ret),
> + i40e_stat_str(hw, (enum i40e_status_code)ret),
> i40e_aq_str(hw, hw->aq.asq_last_status));
> goto out;
> }
> @@ -8173,9 +8173,9 @@ i40e_dcb_hw_configure(struct i40e_pf *pf,
> if (ret) {
> PMD_INIT_LOG(ERR,
> "Set DCB Config failed, err %s aq_err %s\n",
> - i40e_stat_str(hw, ret),
> + i40e_stat_str(hw, (enum i40e_status_code)ret),
> i40e_aq_str(hw, hw->aq.asq_last_status));
> - return ret;
> + return (enum i40e_status_code)ret;
> }
> /* set receive Arbiter to RR mode and ETS scheme by default */
> for (i = 0; i <= I40E_PRTDCB_RETSTCC_MAX_INDEX; i++) {
> --
> 1.8.1.4
I think it is best to change the variable type, instead of casting,
since i40e_aq_query_vsi_bw_config for instance is returning a enum i40e_status_code and not an int.
Thanks,
Pablo
next prev parent reply other threads:[~2015-11-06 8:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-06 7:48 [dpdk-dev] [PATCH 0/3] fix compile issues Helin Zhang
2015-11-06 7:48 ` [dpdk-dev] [PATCH 1/3] bonding: fix ICC compile issue Helin Zhang
2015-11-06 8:08 ` De Lara Guarch, Pablo
2015-11-06 7:48 ` [dpdk-dev] [PATCH 2/3] i40e: " Helin Zhang
2015-11-06 8:11 ` De Lara Guarch, Pablo [this message]
2015-11-06 7:48 ` [dpdk-dev] [PATCH 3/3] app/testpmd: " Helin Zhang
2015-11-09 2:45 ` [dpdk-dev] [PATCH v2 0/2] fix compile issues on ICC Helin Zhang
2015-11-09 2:45 ` [dpdk-dev] [PATCH v2 1/2] i40e: fix ICC compile issue Helin Zhang
2015-11-09 2:45 ` [dpdk-dev] [PATCH v2 2/2] app/testpmd: " Helin Zhang
2015-11-10 9:34 ` [dpdk-dev] [PATCH v2 0/2] fix compile issues on ICC De Lara Guarch, Pablo
2015-11-11 6:11 ` [dpdk-dev] [PATCH v3 " Helin Zhang
2015-11-11 6:11 ` [dpdk-dev] [PATCH v3 1/2] i40e: fix ICC compile issue Helin Zhang
2015-11-11 6:11 ` [dpdk-dev] [PATCH v3 2/2] app/testpmd: " Helin Zhang
[not found] ` <E115CCD9D858EF4F90C690B0DCB4D8973C856E99@IRSMSX108.ger.corp.intel.com>
2015-11-11 18:25 ` [dpdk-dev] [PATCH v3 0/2] fix compile issues on ICC Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E115CCD9D858EF4F90C690B0DCB4D8973C8458EE@IRSMSX108.ger.corp.intel.com \
--to=pablo.de.lara.guarch@intel.com \
--cc=dev@dpdk.org \
--cc=helin.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).