From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: David Marchand <david.marchand@6wind.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix icmp echo tx queues
Date: Tue, 10 Nov 2015 16:10:37 +0000 [thread overview]
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8973C856A3B@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <1446108423-14231-1-git-send-email-david.marchand@6wind.com>
Hi,
> -----Original Message-----
> From: David Marchand [mailto:david.marchand@6wind.com]
> Sent: Thursday, October 29, 2015 8:47 AM
> To: dev@dpdk.org
> Cc: De Lara Guarch, Pablo
> Subject: [PATCH] app/testpmd: fix icmp echo tx queues
>
> icmp echo forward engine relies on the core rank rather than the number of
> queues available.
> This fix is still wrong, because if we set a nb-rxq > nb-txq, then we will use
> an invalid txq, but with this, we are aligned on other fwd engines.
>
> Signed-off-by: David Marchand <david.marchand@6wind.com>
> ---
> app/test-pmd/config.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
> index cf2aa6e..314215c 100644
> --- a/app/test-pmd/config.c
> +++ b/app/test-pmd/config.c
> @@ -1278,7 +1278,7 @@ icmp_echo_config_setup(void)
> fs->rx_port = fwd_ports_ids[rxp];
> fs->rx_queue = rxq;
> fs->tx_port = fs->rx_port;
> - fs->tx_queue = lc_id;
> + fs->tx_queue = rxq;
> fs->peer_addr = fs->tx_port;
> if (verbose_level > 0)
> printf(" stream=%d port=%d rxq=%d
> txq=%d\n",
> --
> 1.9.1
Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
next prev parent reply other threads:[~2015-11-10 16:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-29 8:47 David Marchand
2015-11-10 15:27 ` Thomas Monjalon
2015-11-10 16:10 ` De Lara Guarch, Pablo [this message]
2015-11-10 16:23 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E115CCD9D858EF4F90C690B0DCB4D8973C856A3B@IRSMSX108.ger.corp.intel.com \
--to=pablo.de.lara.guarch@intel.com \
--cc=david.marchand@6wind.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).