From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: "Griffin, John" <john.griffin@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] qat pmd:Fixing build issue on 32-bit systems
Date: Tue, 16 Feb 2016 15:52:45 +0000 [thread overview]
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8973C8A63DE@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <1455615876-29879-1-git-send-email-john.griffin@intel.com>
Hi John,
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of John Griffin
> Sent: Tuesday, February 16, 2016 9:45 AM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] qat pmd:Fixing build issue on 32-bit systems
>
> Fixing build issue on 32-bit systems.
> Fixes: 1703e94ac5ce ("qat: add driver for QuickAssist devices")
>
> Signed-off-by: John Griffin <john.griffin@intel.com>
Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Could you include the error that you are fixing on this patch?
For example:
drivers/crypto/qat/qat_crypto.c:345:13:
error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast]
Also, as a general rule, patch titles start with lowercase and do not include the name "issue" if we use "fix".
e.g. (qat: fix build on 32-bit systems).
Apart from this, patch looks OK to me, so you can leave the acknowledgment in the v2.
Thanks!
Pablo
next prev parent reply other threads:[~2016-02-16 15:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-16 9:44 John Griffin
2016-02-16 15:52 ` De Lara Guarch, Pablo [this message]
2016-02-17 13:29 ` John Griffin
2016-02-18 10:57 ` [dpdk-dev] [PATCH v2] qat:fix build " John Griffin
2016-02-24 14:12 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E115CCD9D858EF4F90C690B0DCB4D8973C8A63DE@IRSMSX108.ger.corp.intel.com \
--to=pablo.de.lara.guarch@intel.com \
--cc=dev@dpdk.org \
--cc=john.griffin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).