From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: "Wang, Zhihong" <zhihong.wang@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
"Richardson, Bruce" <bruce.richardson@intel.com>,
"thomas.monjalon@6wind.com" <thomas.monjalon@6wind.com>
Subject: Re: [dpdk-dev] [PATCH v2 3/5] testpmd: show throughput in port stats
Date: Tue, 7 Jun 2016 10:02:58 +0000 [thread overview]
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8973C95A9E6@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <1464751663-135211-4-git-send-email-zhihong.wang@intel.com>
> -----Original Message-----
> From: Wang, Zhihong
> Sent: Wednesday, June 01, 2016 4:28 AM
> To: dev@dpdk.org
> Cc: Ananyev, Konstantin; Richardson, Bruce; De Lara Guarch, Pablo;
> thomas.monjalon@6wind.com; Wang, Zhihong
> Subject: [PATCH v2 3/5] testpmd: show throughput in port stats
>
> This patch adds throughput numbers (in the period since last use of this
> command) in port statistics display for "show port stats (port_id|all)".
>
>
> Signed-off-by: Zhihong Wang <zhihong.wang@intel.com>
> ---
> app/test-pmd/config.c | 20 ++++++++++++++++++++
> 1 file changed, 20 insertions(+)
>
> diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
> index c611649..f487b87 100644
> --- a/app/test-pmd/config.c
> +++ b/app/test-pmd/config.c
> @@ -92,6 +92,7 @@
> #include <rte_ether.h>
> #include <rte_ethdev.h>
> #include <rte_string_fns.h>
> +#include <rte_cycles.h>
>
> #include "testpmd.h"
>
> @@ -150,6 +151,10 @@ print_ethaddr(const char *name, struct ether_addr
> *eth_addr)
> void
> nic_stats_display(portid_t port_id)
> {
> + static uint64_t sum_rx[RTE_MAX_ETHPORTS];
> + static uint64_t sum_tx[RTE_MAX_ETHPORTS];
> + static uint64_t cycles[RTE_MAX_ETHPORTS];
> + uint64_t pkt_rx, pkt_tx, cycle;
Could you rename some of these variables to something more specific?
Like:
pkt_rx -> diff_rx_pkts
sum_rx -> prev_rx_pkts
cycle -> diff_cycles
cycles -> prev_cycles
> struct rte_eth_stats stats;
> struct rte_port *port = &ports[port_id];
> uint8_t i;
> @@ -209,6 +214,21 @@ nic_stats_display(portid_t port_id)
> }
> }
>
> + cycle = cycles[port_id];
> + cycles[port_id] = rte_rdtsc();
> + if (cycle > 0)
> + cycle = cycles[port_id] - cycle;
> +
> + pkt_rx = stats.ipackets - sum_rx[port_id];
> + pkt_tx = stats.opackets - sum_tx[port_id];
> + sum_rx[port_id] = stats.ipackets;
> + sum_tx[port_id] = stats.opackets;
> + printf("\n Throughput (since last show)\n");
> + printf(" RX-pps: %12"PRIu64"\n"
> + " TX-pps: %12"PRIu64"\n",
> + cycle > 0 ? pkt_rx * rte_get_tsc_hz() / cycle : 0,
> + cycle > 0 ? pkt_tx * rte_get_tsc_hz() / cycle : 0);
> +
> printf(" %s############################%s\n",
> nic_stats_border, nic_stats_border);
> }
> --
> 2.5.0
next prev parent reply other threads:[~2016-06-07 10:04 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-05 22:46 [dpdk-dev] [PATCH 0/6] vhost/virtio performance loopback utility Zhihong Wang
2016-05-05 22:46 ` [dpdk-dev] [PATCH 1/6] testpmd: add io_retry forwarding Zhihong Wang
2016-05-25 9:32 ` Thomas Monjalon
2016-05-26 2:40 ` Wang, Zhihong
2016-05-26 6:27 ` Thomas Monjalon
2016-05-26 9:24 ` Wang, Zhihong
2016-05-05 22:46 ` [dpdk-dev] [PATCH 2/6] testpmd: configurable tx_first burst number Zhihong Wang
2016-05-25 9:35 ` Thomas Monjalon
2016-05-26 2:53 ` Wang, Zhihong
2016-05-26 6:31 ` Thomas Monjalon
2016-05-26 9:31 ` Wang, Zhihong
2016-05-05 22:46 ` [dpdk-dev] [PATCH 3/6] testpmd: show throughput in port stats Zhihong Wang
2016-05-05 22:46 ` [dpdk-dev] [PATCH 4/6] testpmd: handle all rxqs in rss setup Zhihong Wang
2016-05-25 9:42 ` Thomas Monjalon
2016-05-26 2:55 ` Wang, Zhihong
2016-06-03 9:22 ` Wang, Zhihong
2016-05-05 22:47 ` [dpdk-dev] [PATCH 5/6] testpmd: show topology at forwarding start Zhihong Wang
2016-05-25 9:45 ` Thomas Monjalon
2016-05-26 2:56 ` Wang, Zhihong
2016-05-05 22:47 ` [dpdk-dev] [PATCH 6/6] testpmd: update documentation Zhihong Wang
2016-05-25 9:48 ` Thomas Monjalon
2016-05-26 2:54 ` Wang, Zhihong
2016-05-20 8:54 ` [dpdk-dev] [PATCH 0/6] vhost/virtio performance loopback utility Wang, Zhihong
2016-05-25 9:27 ` Thomas Monjalon
2016-06-01 3:27 ` [dpdk-dev] [PATCH v2 0/5] " Zhihong Wang
2016-06-01 3:27 ` [dpdk-dev] [PATCH v2 1/5] testpmd: add retry option Zhihong Wang
2016-06-07 9:28 ` De Lara Guarch, Pablo
2016-06-08 1:29 ` Wang, Zhihong
2016-06-01 3:27 ` [dpdk-dev] [PATCH v2 2/5] testpmd: configurable tx_first burst number Zhihong Wang
2016-06-07 9:43 ` De Lara Guarch, Pablo
2016-06-01 3:27 ` [dpdk-dev] [PATCH v2 3/5] testpmd: show throughput in port stats Zhihong Wang
2016-06-07 10:02 ` De Lara Guarch, Pablo [this message]
2016-06-08 1:31 ` Wang, Zhihong
2016-06-01 3:27 ` [dpdk-dev] [PATCH v2 4/5] testpmd: handle all rxqs in rss setup Zhihong Wang
2016-06-07 10:29 ` De Lara Guarch, Pablo
2016-06-08 1:28 ` Wang, Zhihong
2016-06-01 3:27 ` [dpdk-dev] [PATCH v2 5/5] testpmd: show topology at forwarding start Zhihong Wang
2016-06-07 10:56 ` De Lara Guarch, Pablo
2016-06-14 15:13 ` De Lara Guarch, Pablo
2016-06-15 7:05 ` Wang, Zhihong
2016-06-14 23:08 ` [dpdk-dev] [PATCH v3 0/5] vhost/virtio performance loopback utility Zhihong Wang
2016-06-14 23:08 ` [dpdk-dev] [PATCH v3 1/5] testpmd: add retry option Zhihong Wang
2016-06-14 23:08 ` [dpdk-dev] [PATCH v3 2/5] testpmd: configurable tx_first burst number Zhihong Wang
2016-06-14 23:08 ` [dpdk-dev] [PATCH v3 3/5] testpmd: show throughput in port stats Zhihong Wang
2016-06-14 23:08 ` [dpdk-dev] [PATCH v3 4/5] testpmd: handle all rxqs in rss setup Zhihong Wang
2016-06-27 14:23 ` Nélio Laranjeiro
2016-06-27 22:36 ` De Lara Guarch, Pablo
2016-06-28 8:34 ` Nélio Laranjeiro
2016-06-28 11:10 ` Wang, Zhihong
2016-06-14 23:08 ` [dpdk-dev] [PATCH v3 5/5] testpmd: show topology at forwarding start Zhihong Wang
2016-06-16 11:09 ` De Lara Guarch, Pablo
2016-06-16 13:33 ` Thomas Monjalon
2016-06-15 10:04 ` [dpdk-dev] [PATCH v3 0/5] vhost/virtio performance loopback utility De Lara Guarch, Pablo
2016-06-16 14:36 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E115CCD9D858EF4F90C690B0DCB4D8973C95A9E6@IRSMSX108.ger.corp.intel.com \
--to=pablo.de.lara.guarch@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@intel.com \
--cc=thomas.monjalon@6wind.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).