From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: "Shen, Wei1" <wei1.shen@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
"stephen@networkplumber.org" <stephen@networkplumber.org>,
"Tai, Charlie" <charlie.tai@intel.com>,
"Maciocco, Christian" <christian.maciocco@intel.com>,
"Gobriel, Sameh" <sameh.gobriel@intel.com>
Subject: Re: [dpdk-dev] [PATCH v3] rte_hash: add scalable multi-writer insertion w/ Intel TSX
Date: Thu, 16 Jun 2016 22:22:32 +0000 [thread overview]
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8973C9637DD@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <1466115254-114498-2-git-send-email-wei1.shen@intel.com>
> -----Original Message-----
> From: Shen, Wei1
> Sent: Thursday, June 16, 2016 11:14 PM
> To: dev@dpdk.org
> Cc: De Lara Guarch, Pablo; Ananyev, Konstantin;
> stephen@networkplumber.org; Tai, Charlie; Maciocco, Christian; Gobriel,
> Sameh; Shen, Wei1
> Subject: [PATCH v3] rte_hash: add scalable multi-writer insertion w/ Intel TSX
>
> This patch introduced scalable multi-writer Cuckoo Hash insertion
> based on a split Cuckoo Search and Move operation using Intel
> TSX. It can do scalable hash insertion with 22 cores with little
> performance loss and negligible TSX abortion rate.
>
> * Added an extra rte_hash flag definition to switch default single writer
> Cuckoo Hash behavior to multiwriter.
> - If HTM is available, it would use hardware feature for concurrency.
> - If HTM is not available, it would fall back to spinlock.
>
> * Created a rte_cuckoo_hash_x86.h file to hold all x86-arch related
> cuckoo_hash functions. And rte_cuckoo_hash.c uses compile time flag to
> select x86 file or other platform-specific implementations. While HTM check
> is still done at runtime (same idea with
> RTE_HASH_EXTRA_FLAGS_TRANS_MEM_SUPPORT)
>
> * Moved rte_hash private struct definitions to rte_cuckoo_hash.h, to allow
> rte_cuckoo_hash_x86.h or future platform dependent functions to include.
>
> * Following new functions are created for consistent names when new
> platform
> TM support are added.
> - rte_hash_cuckoo_move_insert_mw_tm: do insertion with bucket
> movement.
> - rte_hash_cuckoo_insert_mw_tm: do insertion without bucket movement.
>
> * One extra multi-writer test case is added.
>
> Signed-off-by: Shen Wei <wei1.shen@intel.com>
> Signed-off-by: Sameh Gobriel <sameh.gobriel@intel.com>
Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
next prev parent reply other threads:[~2016-06-16 22:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-06 20:05 [dpdk-dev] [PATCH v1] hash: add tsx support for cuckoo hash Shen Wei
2016-05-07 4:56 ` Stephen Hemminger
2016-05-09 16:51 ` Shen, Wei1
2016-06-10 11:09 ` De Lara Guarch, Pablo
2016-06-15 23:45 ` De Lara Guarch, Pablo
2016-06-16 4:58 ` Shen, Wei1
2016-06-16 4:52 ` [dpdk-dev] [PATCH v2] rte_hash: add scalable multi-writer insertion w/ Intel TSX Wei Shen
2016-06-16 12:14 ` Ananyev, Konstantin
2016-06-16 22:14 ` [dpdk-dev] [PATCH v3] " Wei Shen
2016-06-16 22:14 ` Wei Shen
2016-06-16 22:22 ` De Lara Guarch, Pablo [this message]
2016-06-24 14:09 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E115CCD9D858EF4F90C690B0DCB4D8973C9637DD@IRSMSX108.ger.corp.intel.com \
--to=pablo.de.lara.guarch@intel.com \
--cc=charlie.tai@intel.com \
--cc=christian.maciocco@intel.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@intel.com \
--cc=sameh.gobriel@intel.com \
--cc=stephen@networkplumber.org \
--cc=wei1.shen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).