From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: "Pattan, Reshma" <reshma.pattan@intel.com>
Cc: "Doherty, Declan" <declan.doherty@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] crypto: fix memory leak
Date: Mon, 18 Jul 2016 12:42:19 +0000 [thread overview]
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8973C9904EE@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <3AEA2BF9852C6F48A459DA490692831F0105A6D8@IRSMSX109.ger.corp.intel.com>
> -----Original Message-----
> From: Pattan, Reshma
> Sent: Monday, July 18, 2016 1:32 PM
> To: De Lara Guarch, Pablo
> Cc: Doherty, Declan; dev@dpdk.org
> Subject: RE: [dpdk-dev] [PATCH] crypto: fix memory leak
>
>
>
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Pablo de Lara
> > Sent: Monday, July 18, 2016 1:01 PM
> > To: dev@dpdk.org
> > Cc: Doherty, Declan <declan.doherty@intel.com>; De Lara Guarch, Pablo
> > <pablo.de.lara.guarch@intel.com>
> > Subject: [dpdk-dev] [PATCH] crypto: fix memory leak
> >
> > When parsing the parameters for virtual device initialization, rte_kvargs
> > structure was being freed only if there was an error, not when parsing was
> > successful.
> >
> > Coverity issue: 124568
> >
> > Fixes: f3e764fa2fb7 ("cryptodev: uninline parameter parsing")
> >
> > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> > ---
> > --- a/lib/librte_cryptodev/rte_cryptodev.c
> > +++ b/lib/librte_cryptodev/rte_cryptodev.c
> > @@ -148,7 +148,7 @@ int
> > int ret;
>
> You can initialize ret to 0 here instead of below.
True. Thanks for this, will send a v2 shortly.
>
> >
> > if (params == NULL)
> > @@ -187,10 +187,11 @@ rte_cryptodev_parse_vdev_init_params(struct
> > rte_crypto_vdev_init_params *params,
> > }
> > }
> >
> > - return 0;
> > + ret = 0;
next prev parent reply other threads:[~2016-07-18 12:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-18 12:00 Pablo de Lara
2016-07-18 12:32 ` Pattan, Reshma
2016-07-18 12:42 ` De Lara Guarch, Pablo [this message]
2016-07-18 12:47 ` [dpdk-dev] [PATCH v2] " Pablo de Lara
2016-07-18 12:59 ` Pattan, Reshma
2016-07-18 13:00 ` Mcnamara, John
2016-07-18 13:21 ` [dpdk-dev] [PATCH v3] " Pablo de Lara
2016-07-22 9:02 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E115CCD9D858EF4F90C690B0DCB4D8973C9904EE@IRSMSX108.ger.corp.intel.com \
--to=pablo.de.lara.guarch@intel.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=reshma.pattan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).