From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: David Marchand <david.marchand@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Mcnamara, John" <john.mcnamara@intel.com>
Subject: Re: [dpdk-dev] [PATCH] doc: announce API change for virtual device initialization
Date: Thu, 28 Jul 2016 15:47:22 +0000 [thread overview]
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8973C9A86C9@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <CALwxeUvJNvFqe=ecs3ksQQxMEyn3751Kb-Z3TrUHuFi=Kfh-Hw@mail.gmail.com>
> -----Original Message-----
> From: David Marchand [mailto:david.marchand@6wind.com]
> Sent: Thursday, July 28, 2016 5:18 AM
> To: De Lara Guarch, Pablo
> Cc: dev@dpdk.org; Mcnamara, John
> Subject: Re: [dpdk-dev] [PATCH] doc: announce API change for virtual device
> initialization
>
> Hello Pablo,
>
> On Mon, Jul 4, 2016 at 4:50 PM, Pablo de Lara
> <pablo.de.lara.guarch@intel.com> wrote:
> > In order to create a virtual device, user needs to call
> > rte_eal_vdev_init generally, but this function returns 0
> > on success or negative number if error. Instead, something
> > more useful would be to return the port or device id of the
> > device created, so the user can call rte_eal_vdev_init
> > function and use the device straight away, using the id returned
> > by the function.
> >
> > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> > ---
> > doc/guides/rel_notes/deprecation.rst | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/doc/guides/rel_notes/deprecation.rst
> b/doc/guides/rel_notes/deprecation.rst
> > index f502f86..60cc7c7 100644
> > --- a/doc/guides/rel_notes/deprecation.rst
> > +++ b/doc/guides/rel_notes/deprecation.rst
> > @@ -41,3 +41,8 @@ Deprecation Notices
> > * The mempool functions for single/multi producer/consumer are
> deprecated and
> > will be removed in 16.11.
> > It is replaced by rte_mempool_generic_get/put functions.
> > +
> > +* The rte_eal_vdev_init function will be changed in 16.11 to return
> > + the port/device id of the device created, instead of 0, when it has been
> > + initialized successfully, so user can use the returned value straight away
> > + to call all the device functions that require that parameter.
> > --
> > 2.5.0
> >
>
> This is a layer violation.
> EAL does not know a thing about "ports".
>
> This information should come from the crypto framework and so an api
> in crypto framework is the right place, not EAL.
>
> This is a NACK for me.
Fair enough. So you mean to use rte_eth_dev_attach in ethdev library and
a similar function in cryptodev library?
Thanks,
Pablo
>
>
> --
> David Marchand
next prev parent reply other threads:[~2016-07-28 15:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-04 14:50 Pablo de Lara
2016-07-05 10:44 ` Declan Doherty
2016-07-05 13:04 ` Ferruh Yigit
2016-07-05 13:38 ` Thomas Monjalon
2016-07-05 14:55 ` De Lara Guarch, Pablo
2016-07-06 10:59 ` De Lara Guarch, Pablo
2016-07-28 12:18 ` David Marchand
2016-07-28 15:47 ` De Lara Guarch, Pablo [this message]
2016-07-28 15:56 ` David Marchand
2016-07-29 17:35 ` Andriy Berestovskyy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E115CCD9D858EF4F90C690B0DCB4D8973C9A86C9@IRSMSX108.ger.corp.intel.com \
--to=pablo.de.lara.guarch@intel.com \
--cc=david.marchand@6wind.com \
--cc=dev@dpdk.org \
--cc=john.mcnamara@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).