From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: "Jain, Deepak K" <deepak.k.jain@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v3 1/2] crypto/qat: add NULL capability to Intel QAT driver
Date: Fri, 16 Sep 2016 01:43:45 +0000 [thread overview]
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8973C9E7D26@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <1473757155-29941-2-git-send-email-deepak.k.jain@intel.com>
Hi Deepak,
> -----Original Message-----
> From: Jain, Deepak K
> Sent: Tuesday, September 13, 2016 1:59 AM
> To: dev@dpdk.org
> Cc: De Lara Guarch, Pablo; Jain, Deepak K
> Subject: [PATCH v3 1/2] crypto/qat: add NULL capability to Intel QAT driver
>
> From: Deepak Kumar JAIN <deepak.k.jain@intel.com>
>
> enabled NULL crypto for Intel(R) QuickAssist Technology
>
> Signed-off-by: Deepak Kumar Jain <deepak.k.jain@intel.com>
> ---
> doc/guides/cryptodevs/qat.rst | 3 +-
> doc/guides/rel_notes/release_16_11.rst | 1 +
> drivers/crypto/qat/qat_adf/qat_algs_build_desc.c | 2 ++
> drivers/crypto/qat/qat_crypto.c | 45 ++++++++++++++++++++++++
> 4 files changed, 50 insertions(+), 1 deletion(-)
>
> diff --git a/doc/guides/cryptodevs/qat.rst b/doc/guides/cryptodevs/qat.rst
> index 78a734f..bb62f22 100644
> --- a/doc/guides/cryptodevs/qat.rst
> +++ b/doc/guides/cryptodevs/qat.rst
> @@ -49,6 +49,7 @@ Cipher algorithms:
> * ``RTE_CRYPTO_SYM_CIPHER_AES256_CTR``
> * ``RTE_CRYPTO_SYM_CIPHER_SNOW3G_UEA2``
> * ``RTE_CRYPTO_CIPHER_AES_GCM``
> +* ``RTE_CRYPTO_CIPHER_NULL``
>
> Hash algorithms:
>
> @@ -60,7 +61,7 @@ Hash algorithms:
> * ``RTE_CRYPTO_AUTH_AES_XCBC_MAC``
> * ``RTE_CRYPTO_AUTH_SNOW3G_UIA2``
> * ``RTE_CRYPTO_AUTH_MD5_HMAC``
> -
> +* ``RTE_CRYPTO_AUTH_NULL``
Extra blank line should remain here.
>
> Limitations
> -----------
...
> --- a/drivers/crypto/qat/qat_crypto.c
> +++ b/drivers/crypto/qat/qat_crypto.c
> @@ -346,6 +346,47 @@ static const struct rte_cryptodev_capabilities
> qat_pmd_capabilities[] = {
> }, }
> }, }
> },
> + { /* NULL (AUTH) */
> + .op = RTE_CRYPTO_OP_TYPE_SYMMETRIC,
> + {.sym = {
> + .xform_type = RTE_CRYPTO_SYM_XFORM_AUTH,
> + {.auth = {
> + .algo = RTE_CRYPTO_AUTH_NULL,
> + .block_size = 1,
> + .key_size = {
> + .min = 0,
> + .max = 0,
> + .increment = 0
> + },
> + .digest_size = {
> + .min = 0,
> + .max = 0,
> + .increment = 0
> + },
> + .aad_size = { 0 }
> + }, },
> + }, },
> + },
> + { /* NULL (CIPHER) */
> + .op = RTE_CRYPTO_OP_TYPE_SYMMETRIC,
> + {.sym = {
> + .xform_type = RTE_CRYPTO_SYM_XFORM_CIPHER,
> + {.cipher = {
> + .algo = RTE_CRYPTO_CIPHER_NULL,
> + .block_size = 1,
> + .key_size = {
> + .min = 0,
> + .max = 0,
> + .increment = 8
Increment should be 0, right?
> + },
> + .iv_size = {
> + .min = 0,
> + .max = 0,
> + .increment = 0
> + }
> + }, },
> + }, }
> + },
> RTE_CRYPTODEV_END_OF_CAPABILITIES_LIST()
> };
next prev parent reply other threads:[~2016-09-16 1:43 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-18 13:34 [dpdk-dev] [PATCH 0/2] add NULL crypto support in " Deepak Kumar Jain
2016-08-18 13:34 ` [dpdk-dev] [PATCH 1/2] crypto/qat: add NULL capability to " Deepak Kumar Jain
2016-08-18 13:34 ` [dpdk-dev] [PATCH 2/2] app/test: add test cases for NULL for " Deepak Kumar Jain
2016-09-07 18:05 ` [dpdk-dev] [PATCH 0/2] add NULL crypto support in " De Lara Guarch, Pablo
2016-09-07 19:33 ` Jain, Deepak K
2016-09-12 20:00 ` [dpdk-dev] [PATCH v2 " Deepak Kumar Jain
2016-09-12 20:00 ` [dpdk-dev] [PATCH v2 1/2] crypto/qat: add NULL capability to " Deepak Kumar Jain
2016-09-12 20:00 ` [dpdk-dev] [PATCH v2 2/2] app/test: add test cases for NULL for " Deepak Kumar Jain
2016-09-13 8:59 ` [dpdk-dev] [PATCH v3 0/2] add NULL crypto support in " Deepak Kumar Jain
2016-09-13 8:59 ` [dpdk-dev] [PATCH v3 1/2] crypto/qat: add NULL capability to " Deepak Kumar Jain
2016-09-15 13:34 ` Trahe, Fiona
2016-09-16 1:43 ` De Lara Guarch, Pablo [this message]
2016-09-13 8:59 ` [dpdk-dev] [PATCH v3 2/2] app/test: add test cases for NULL for " Deepak Kumar Jain
2016-09-15 13:48 ` Trahe, Fiona
2016-09-16 8:57 ` [dpdk-dev] [PATCH v4 0/2] add NULL crypto support in " Deepak Kumar Jain
2016-09-16 8:57 ` [dpdk-dev] [PATCH v4 1/2] crypto/qat: add NULL capability to " Deepak Kumar Jain
2016-09-16 8:57 ` [dpdk-dev] [PATCH v4 2/2] app/test: add test cases for NULL for " Deepak Kumar Jain
2016-09-16 21:54 ` [dpdk-dev] [PATCH v4 0/2] add NULL crypto support in " De Lara Guarch, Pablo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E115CCD9D858EF4F90C690B0DCB4D8973C9E7D26@IRSMSX108.ger.corp.intel.com \
--to=pablo.de.lara.guarch@intel.com \
--cc=deepak.k.jain@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).