From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: "Mrozowicz, SlawomirX" <slawomirx.mrozowicz@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "Mrozowicz, SlawomirX" <slawomirx.mrozowicz@intel.com>,
"Doherty, Declan" <declan.doherty@intel.com>,
"Kerlin, Marcin" <marcin.kerlin@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2 2/3] lib/librte_cryptodev: functions for new performance test application
Date: Fri, 6 Jan 2017 12:21:52 +0000 [thread overview]
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D897476BF528@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <1483635001-15473-3-git-send-email-slawomirx.mrozowicz@intel.com>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Slawomir
> Mrozowicz
> Sent: Thursday, January 05, 2017 4:50 PM
> To: dev@dpdk.org
> Cc: Mrozowicz, SlawomirX; Doherty, Declan; Kerlin, Marcin
> Subject: [dpdk-dev] [PATCH v2 2/3] lib/librte_cryptodev: functions for new
> performance test application
>
> This patch adds helper functions for new performance application.
> Application can be used to measute throughput and latency of
> cryptography operation performed by crypto device.
>
> Signed-off-by: Declan Doherty <declan.doherty@intel.com>
> Signed-off-by: Slawomir Mrozowicz <slawomirx.mrozowicz@intel.com>
> Signed-off-by: Marcin Kerlin <marcinx.kerlin@intel.com>
Hi Slawomir,
You should change the title of this patch to something like: "cryptodev: add functions for...".
Also, maybe it would be better to say "add functions to retrieve device info",
since you are not saying much with the current title.
I have seen also that this is based on the SGL code, so this patch didn't apply cleanly.
Next time, specify it in the email the dependencies of the patch.
Thanks,
Pablo
next prev parent reply other threads:[~2017-01-06 12:21 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-02 15:15 [dpdk-dev] [PATCH 0/2] Introduce " Michal Jastrzebski
2016-12-02 15:15 ` [dpdk-dev] [PATCH 1/2] lib/librte_cryptodev: functions for " Michal Jastrzebski
2016-12-02 15:15 ` [dpdk-dev] [PATCH 2/2] app/crypto-perf: Introduce " Michal Jastrzebski
2017-01-05 16:49 ` [dpdk-dev] [PATCH v2 0/4] " Slawomir Mrozowicz
2017-01-05 16:49 ` [dpdk-dev] [PATCH v2 1/3] eal: add quiet mode to suppress log output to stdout Slawomir Mrozowicz
2017-01-05 15:40 ` Thomas Monjalon
2017-01-10 10:41 ` Declan Doherty
2017-01-05 16:50 ` [dpdk-dev] [PATCH v2 2/3] lib/librte_cryptodev: functions for new performance test application Slawomir Mrozowicz
2017-01-06 12:21 ` De Lara Guarch, Pablo [this message]
2017-01-09 9:11 ` Mrozowicz, SlawomirX
2017-01-05 16:50 ` [dpdk-dev] [PATCH v2 3/3] app/crypto-perf: introduce " Slawomir Mrozowicz
2017-01-09 14:51 ` De Lara Guarch, Pablo
2017-01-10 7:28 ` Mrozowicz, SlawomirX
2017-01-09 15:24 ` Thomas Monjalon
2017-01-10 8:52 ` Mrozowicz, SlawomirX
2017-01-11 16:07 ` [dpdk-dev] [PATCH v3 0/2] Introduce " Slawomir Mrozowicz
2017-01-11 16:07 ` [dpdk-dev] [PATCH v3 1/2] cryptodev: add functions to retrieve device info Slawomir Mrozowicz
2017-01-11 15:21 ` Trahe, Fiona
2017-01-11 16:07 ` [dpdk-dev] [PATCH v3 2/2] app/crypto-perf: introduce new performance test application Slawomir Mrozowicz
2017-01-25 16:27 ` [dpdk-dev] [PATCH v4 0/4] Introduce " Slawomir Mrozowicz
2017-01-25 15:59 ` De Lara Guarch, Pablo
2017-01-26 9:43 ` De Lara Guarch, Pablo
2017-01-25 16:27 ` [dpdk-dev] [PATCH v4 1/4] cryptodev: add functions to retrieve device info Slawomir Mrozowicz
2017-01-25 16:27 ` [dpdk-dev] [PATCH v4 2/4] app/crypto-perf: introduce new performance test application Slawomir Mrozowicz
2017-01-25 16:27 ` [dpdk-dev] [PATCH v4 3/4] app/crypto-perf: add test vectors files Slawomir Mrozowicz
2017-01-25 16:27 ` [dpdk-dev] [PATCH v4 4/4] doc: describe new performance test application Slawomir Mrozowicz
2017-01-26 15:21 ` Ferruh Yigit
2017-01-26 15:23 ` Richardson, Bruce
2017-01-26 17:53 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E115CCD9D858EF4F90C690B0DCB4D897476BF528@IRSMSX108.ger.corp.intel.com \
--to=pablo.de.lara.guarch@intel.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=marcin.kerlin@intel.com \
--cc=slawomirx.mrozowicz@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).