From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: "Doherty, Declan" <declan.doherty@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] crypto/aesni_mb: add missing digest length
Date: Fri, 27 Jan 2017 13:15:39 +0000 [thread overview]
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D897476D08AB@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <1485522968-211005-1-git-send-email-pablo.de.lara.guarch@intel.com>
> -----Original Message-----
> From: De Lara Guarch, Pablo
> Sent: Friday, January 27, 2017 1:16 PM
> To: adrien.mazarguil@6wind.com; Wu, Jingjing
> Cc: dev@dpdk.org; De Lara Guarch, Pablo
> Subject: [PATCH] crypto/aesni_mb: add missing digest length
>
> AESNI MB now supports authentication only operations,
> but the array containing all the possible digest lengths
> was not updated to reflect the new algorithm NULL_HASH,
> causing an "Out-of-bounds access".
>
> Coverity issue: 140977
> Fixes: 8772c3f713e2 ("crypto/aesni_mb: add single operation
> functionality")
>
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> ---
> drivers/crypto/aesni_mb/rte_aesni_mb_pmd_private.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_private.h
> b/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_private.h
> index 5f125b2..eb4b2ad 100644
> --- a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_private.h
> +++ b/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_private.h
> @@ -88,6 +88,7 @@ static const unsigned
> auth_truncated_digest_byte_lengths[] = {
> [SHA_384] = 24,
> [SHA_512] = 32,
> [AES_XCBC] = 12,
> + [NULL_HASH] = 0
> };
>
> /**
> @@ -111,6 +112,7 @@ static const unsigned auth_digest_byte_lengths[] =
> {
> [SHA_384] = 48,
> [SHA_512] = 64,
> [AES_XCBC] = 16,
> + [NULL_HASH] = 0
> };
>
> /**
> --
> 2.7.4
Wrong maintainer, Sending to right one now. Sorry about that.
next prev parent reply other threads:[~2017-01-27 13:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-27 13:16 Pablo de Lara
2017-01-27 13:15 ` De Lara Guarch, Pablo [this message]
2017-01-31 16:44 ` Declan Doherty
2017-02-09 22:19 ` De Lara Guarch, Pablo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E115CCD9D858EF4F90C690B0DCB4D897476D08AB@IRSMSX108.ger.corp.intel.com \
--to=pablo.de.lara.guarch@intel.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).