From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: "Doherty, Declan" <declan.doherty@intel.com>,
"Gonzalez Monroy, Sergio" <sergio.gonzalez.monroy@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH] crypto/aesni_gcm: do crypto op in dequeue function
Date: Thu, 30 Mar 2017 11:54:25 +0000 [thread overview]
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D89747710ED1@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <7923ff78-ba53-4573-5c83-efc699ff53c1@intel.com>
> -----Original Message-----
> From: Doherty, Declan
> Sent: Thursday, March 30, 2017 12:45 PM
> To: Gonzalez Monroy, Sergio; dev@dpdk.org
> Cc: De Lara Guarch, Pablo; stable@dpdk.org
> Subject: Re: [PATCH] crypto/aesni_gcm: do crypto op in dequeue function
>
> On 29/03/17 14:42, Sergio Gonzalez Monroy wrote:
> > There is bug when more crypto ops are enqueued than dequeued.
> > The return value is not checked when trying to enqueue the
> > processed crypto op into the internal ring, which in the case of being
> > full will results in crypto ops and mbufs being leaked.
> > The issue is more obvious with different cores doing enqueue/dequeue.
> >
> > This patch moves the crypto operation to the dequeue function which
> > fixes the above issue without having to check for the number of free
> > entries in the ring.
> >
> > Fixes: eec136f3c54f ("aesni_gcm: add driver for AES-GCM crypto
> operations")
> >
> > Signed-off-by: Sergio Gonzalez Monroy
> <sergio.gonzalez.monroy@intel.com>
> > ---
> ...
> >
>
Hi Declan,
> Hey Sergio, this looks good but it needs to be rebased for the rte_ring
> API change. I also see a marginally performance increase with this
> change using the crypto-perf app which wasn't expected.
Unless there is other change necessary, I can make that change when merging.
Thanks,
Pablo
>
>
> Acked-by: Declan Doherty <declan.doherty@intel.com>
next prev parent reply other threads:[~2017-03-30 11:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-29 13:42 Sergio Gonzalez Monroy
2017-03-30 11:44 ` Declan Doherty
2017-03-30 11:54 ` De Lara Guarch, Pablo [this message]
2017-03-30 11:55 ` Doherty, Declan
2017-03-30 13:24 ` De Lara Guarch, Pablo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E115CCD9D858EF4F90C690B0DCB4D89747710ED1@IRSMSX108.ger.corp.intel.com \
--to=pablo.de.lara.guarch@intel.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=sergio.gonzalez.monroy@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).