From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: "Kusztal, ArkadiuszX" <arkadiuszx.kusztal@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "Trahe, Fiona" <fiona.trahe@intel.com>,
"Griffin, John" <john.griffin@intel.com>,
"Jain, Deepak K" <deepak.k.jain@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2 3/3] test: add ZUC test cases for QAT
Date: Thu, 30 Mar 2017 21:29:18 +0000 [thread overview]
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D89747711A49@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <1490792659-31544-4-git-send-email-arkadiuszx.kusztal@intel.com>
Hi Arek,
> -----Original Message-----
> From: Kusztal, ArkadiuszX
> Sent: Wednesday, March 29, 2017 2:04 PM
> To: dev@dpdk.org
> Cc: Trahe, Fiona; De Lara Guarch, Pablo; Griffin, John; Jain, Deepak K;
> Kusztal, ArkadiuszX
> Subject: [PATCH v2 3/3] test: add ZUC test cases for QAT
>
> This patch adds ZUC EEA3/EIA3 test cases for QAT crypto
> test suite and consolidate ZUC test vectors into one header file.
>
> Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
> diff --git a/test/test/test_cryptodev.c b/test/test/test_cryptodev.c
> index a8f3ae5..7507878 100644
> --- a/test/test/test_cryptodev.c
> +++ b/test/test/test_cryptodev.c
...
> static int
> +test_zuc_cipher_auth(const struct wireless_test_data *tdata)
> +{
> + struct crypto_testsuite_params *ts_params = &testsuite_params;
> + struct crypto_unittest_params *ut_params = &unittest_params;
> +
> + int retval;
> +
> + uint8_t *plaintext, *ciphertext;
> + unsigned int plaintext_pad_len;
> + unsigned int plaintext_len;
This test (and the encryption and auth only tests) will fail if using a QAT device
without ZUC support.
I suggest to check the capabilities of the device to see if it supports ZUC
and if it doesn't, return -ENOTSUP.
Also, I would move the vectors from one file to another in another patch.
Thanks,
Pablo
prev parent reply other threads:[~2017-03-30 21:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-29 13:04 [dpdk-dev] [PATCH v2 0/3] Add ZUC EEA3/EIA3 capability to Intel(R) QuickAssist Technology driver Arek Kusztal
2017-03-29 13:04 ` [dpdk-dev] [PATCH v2 1/3] crypto/qat: refactor capabilities infrastructure Arek Kusztal
2017-03-30 13:34 ` Trahe, Fiona
2017-03-30 21:50 ` De Lara Guarch, Pablo
2017-03-29 13:04 ` [dpdk-dev] [PATCH v2 2/3] crypto/qat: add ZUC EEA3/EIA3 capability Arek Kusztal
2017-03-30 13:35 ` Trahe, Fiona
2017-03-29 13:04 ` [dpdk-dev] [PATCH v2 3/3] test: add ZUC test cases for QAT Arek Kusztal
2017-03-30 13:36 ` Trahe, Fiona
2017-03-30 21:29 ` De Lara Guarch, Pablo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E115CCD9D858EF4F90C690B0DCB4D89747711A49@IRSMSX108.ger.corp.intel.com \
--to=pablo.de.lara.guarch@intel.com \
--cc=arkadiuszx.kusztal@intel.com \
--cc=deepak.k.jain@intel.com \
--cc=dev@dpdk.org \
--cc=fiona.trahe@intel.com \
--cc=john.griffin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).