From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: "Pattan, Reshma" <reshma.pattan@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Wu, Jingjing" <jingjing.wu@intel.com>
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: disable latency stats by default
Date: Tue, 2 May 2017 13:11:52 +0000 [thread overview]
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D89747814F02@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <1493730674-102633-1-git-send-email-pablo.de.lara.guarch@intel.com>
CC'ing Jingjing.
> -----Original Message-----
> From: De Lara Guarch, Pablo
> Sent: Tuesday, May 02, 2017 2:11 PM
> To: jingjing@intel.com; Pattan, Reshma
> Cc: dev@dpdk.org; De Lara Guarch, Pablo
> Subject: [PATCH] app/testpmd: disable latency stats by default
>
> Disable latency stats gathering by default,
> so there is not performance degradation if user
> is not interested in them.
>
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> ---
> app/test-pmd/testpmd.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
> index dfe6442..23dfdb0 100644
> --- a/app/test-pmd/testpmd.c
> +++ b/app/test-pmd/testpmd.c
> @@ -971,7 +971,8 @@ run_pkt_fwd_on_lcore(struct fwd_lcore *fc,
> packet_fwd_t pkt_fwd)
> }
> #endif
> #ifdef RTE_LIBRTE_LATENCY_STATS
> - if (latencystats_lcore_id == rte_lcore_id())
> + if (latencystats_enabled != 0 &&
> + latencystats_lcore_id == rte_lcore_id())
> rte_latencystats_update();
> #endif
>
> @@ -2238,8 +2239,9 @@ main(int argc, char** argv)
> rte_panic("Empty set of forwarding logical cores - check the
> "
> "core mask supplied in the command
> parameters\n");
>
> - /* Bitrate stats disabled by default */
> + /* Bitrate/latency stats disabled by default */
> bitrate_enabled = 0;
> + latencystats_enabled = 0;
>
> argc -= diag;
> argv += diag;
> --
> 2.7.4
next prev parent reply other threads:[~2017-05-02 13:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-02 13:11 Pablo de Lara
2017-05-02 13:11 ` De Lara Guarch, Pablo [this message]
2017-05-04 16:28 ` [dpdk-dev] [PATCH v2] " Pablo de Lara
2017-05-06 1:10 ` Wu, Jingjing
2017-05-06 7:38 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E115CCD9D858EF4F90C690B0DCB4D89747814F02@IRSMSX108.ger.corp.intel.com \
--to=pablo.de.lara.guarch@intel.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=reshma.pattan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).