From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: "Wu, Jingjing" <jingjing.wu@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: print statistics periodically
Date: Wed, 7 Jun 2017 13:13:39 +0000 [thread overview]
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8976CBBF737@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <9BB6961774997848B5B42BEC655768F810D9CBDA@SHSMSX103.ccr.corp.intel.com>
Hi Jingjing,
> -----Original Message-----
> From: Wu, Jingjing
> Sent: Wednesday, June 07, 2017 10:12 AM
> To: De Lara Guarch, Pablo
> Cc: dev@dpdk.org
> Subject: RE: [PATCH] app/testpmd: print statistics periodically
>
>
>
> > -----Original Message-----
> > From: De Lara Guarch, Pablo
> > Sent: Monday, May 29, 2017 5:39 AM
> > To: Wu, Jingjing <jingjing.wu@intel.com>
> > Cc: dev@dpdk.org; De Lara Guarch, Pablo
> <pablo.de.lara.guarch@intel.com>
> > Subject: [PATCH] app/testpmd: print statistics periodically
> >
> > Add parameter to print port statistics periodically
> > (disabled by default), if interactive mode is not enabled.
> >
> > This is useful to allow the user to see port statistics
> > without having to get into the internal command line.
> >
> > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> > ---
> > app/test-pmd/parameters.c | 15 ++++++++++++-
> > app/test-pmd/testpmd.c | 40
> > ++++++++++++++++++++++++++++++++++-
> > app/test-pmd/testpmd.h | 1 +
> > doc/guides/testpmd_app_ug/run_app.rst | 5 +++++
> > 4 files changed, 59 insertions(+), 2 deletions(-)
> >
> > diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c
> > index fbe6284..a758b25 100644
> > --- a/app/test-pmd/parameters.c
> > +++ b/app/test-pmd/parameters.c
> > @@ -89,6 +89,7 @@ usage(char* progname)
> > "[--cmdline-file=FILENAME] "
> > #endif
> > "[--help|-h] | [--auto-start|-a] | ["
> > + "-T PERIOD: statistics will be shown every PERIOD seconds (only
> if interactive is
> How about change it following format?
>
> "[--help|-h] | [--auto-start|-a] | [ -T PERIOD] | ["
> "-T PERIOD: statistics will be shown every PERIOD seconds (only if
> interactive is
> "--coremask=COREMASK --portmask=PORTMASK --numa "
>
>
> Add line after printf(" --help: ......
> printf("-T PERIOD: statistics will be shown every PERIOD seconds (only if
> interactive is disabled)\n");
>
Agreed. Will change this, thanks for the review.
Pablo
next prev parent reply other threads:[~2017-06-07 13:13 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-28 21:38 Pablo de Lara
2017-06-07 9:11 ` Wu, Jingjing
2017-06-07 13:13 ` De Lara Guarch, Pablo [this message]
2017-06-09 1:46 ` [dpdk-dev] [PATCH v2] " Pablo de Lara
2017-06-15 1:48 ` [dpdk-dev] [PATCH v3] " Pablo de Lara
2017-06-19 1:05 ` Wu, Jingjing
2017-06-19 21:22 ` Thomas Monjalon
2017-06-20 8:34 ` De Lara Guarch, Pablo
2017-07-05 23:51 ` Thomas Monjalon
2017-07-06 9:56 ` De Lara Guarch, Pablo
2017-07-06 1:52 ` [dpdk-dev] [PATCH v4] " Pablo de Lara
2017-07-06 3:05 ` [dpdk-dev] [PATCH v5] " Pablo de Lara
2017-07-06 14:20 ` Thomas Monjalon
2017-07-06 10:06 ` [dpdk-dev] [PATCH v4] " Jerin Jacob
2017-07-06 10:43 ` De Lara Guarch, Pablo
2017-07-06 10:16 ` Thomas Monjalon
2017-07-06 10:19 ` De Lara Guarch, Pablo
2017-06-19 0:54 ` [dpdk-dev] [PATCH v2] " Wu, Jingjing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E115CCD9D858EF4F90C690B0DCB4D8976CBBF737@IRSMSX108.ger.corp.intel.com \
--to=pablo.de.lara.guarch@intel.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).