From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: "Wu, Jingjing" <jingjing.wu@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: add parameter to start forwarding sending
Date: Wed, 7 Jun 2017 13:20:45 +0000 [thread overview]
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8976CBBF755@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <9BB6961774997848B5B42BEC655768F810D9CBF6@SHSMSX103.ccr.corp.intel.com>
Hi Jingjing,
> -----Original Message-----
> From: Wu, Jingjing
> Sent: Wednesday, June 07, 2017 10:18 AM
> To: De Lara Guarch, Pablo
> Cc: dev@dpdk.org
> Subject: RE: [PATCH] app/testpmd: add parameter to start forwarding
> sending
>
>
>
> > -----Original Message-----
> > From: De Lara Guarch, Pablo
> > Sent: Monday, May 29, 2017 5:37 AM
> > To: Wu, Jingjing <jingjing.wu@intel.com>
> > Cc: dev@dpdk.org; De Lara Guarch, Pablo
> <pablo.de.lara.guarch@intel.com>
> > Subject: [PATCH] app/testpmd: add parameter to start forwarding
> sending
> >
> > Add parameter to start forwarding sending first
> > a burst of packets, which is useful when testing
> > a loopback connection.
> >
> > This was already implemented as an internal command,
> > but adding it as a parameter is interesting, as it
> > allows the user to test a loopback connection without
> > entering in the internal command line.
> >
> > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> > ---
> > app/test-pmd/parameters.c | 5 +++++
> > app/test-pmd/testpmd.c | 5 +++--
> > app/test-pmd/testpmd.h | 1 +
> > doc/guides/testpmd_app_ug/run_app.rst | 4 ++++
> > 4 files changed, 13 insertions(+), 2 deletions(-)
> >
> > diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c
> > index fbe6284..0da4172 100644
> > --- a/app/test-pmd/parameters.c
> > +++ b/app/test-pmd/parameters.c
> > @@ -89,6 +89,7 @@ usage(char* progname)
> > "[--cmdline-file=FILENAME] "
> > #endif
> > "[--help|-h] | [--auto-start|-a] | ["
> > + "--tx-first"
>
> Just consider about the interactive mode.
> If using command start, will it still call start_packet_forwarding(0)?
> And if start tx_first, still call start_packet_forwarding(1)?
>
If using the commands "start" and "start tx_first", the behaviour will remain the same.
The only behaviour that will change is the non-interactive forwarding mode,
and when using auto-start in interactive mode.
Do you think it should modify the behaviour of "start", in the command line,
so if "--tx-first" is passed, then it sends a burst regardless using "start" or "start tx_first"?
Thanks for the review!
Pablo
> It may cause confused whether this argu "--tx-first" works.
> If it only works for non-interactive, you'd better to comment it.
>
>
> Thanks
> Jingjing
next prev parent reply other threads:[~2017-06-07 13:20 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-28 21:36 Pablo de Lara
2017-06-07 9:17 ` Wu, Jingjing
2017-06-07 13:20 ` De Lara Guarch, Pablo [this message]
2017-06-07 13:23 ` Bruce Richardson
2017-06-09 2:30 ` [dpdk-dev] [PATCH v2] " Pablo de Lara
2017-06-15 4:04 ` [dpdk-dev] [PATCH v3] app/testpmd: add parameter to start forwarding TX first Pablo de Lara
2017-06-15 12:05 ` De Lara Guarch, Pablo
2017-06-19 1:05 ` Wu, Jingjing
2017-07-05 23:48 ` Thomas Monjalon
2017-06-19 21:12 ` Thomas Monjalon
2017-06-20 8:03 ` De Lara Guarch, Pablo
2017-06-20 9:22 ` Bruce Richardson
2017-06-20 9:58 ` Thomas Monjalon
2017-06-20 10:19 ` Gaëtan Rivet
2017-06-20 10:27 ` Van Haaren, Harry
2017-06-20 11:20 ` Bruce Richardson
2017-06-20 12:30 ` Gaëtan Rivet
2017-06-19 0:53 ` [dpdk-dev] [PATCH v2] app/testpmd: add parameter to start forwarding sending Wu, Jingjing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E115CCD9D858EF4F90C690B0DCB4D8976CBBF755@IRSMSX108.ger.corp.intel.com \
--to=pablo.de.lara.guarch@intel.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).