From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: "Gonzalez Monroy, Sergio" <sergio.gonzalez.monroy@intel.com>,
"Doherty, Declan" <declan.doherty@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 1/2] crypto/aesni_mb: support IPSec Multi-buffer lib v0.46
Date: Sun, 2 Jul 2017 10:46:46 +0000 [thread overview]
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8976CBD26E6@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <43129740-703a-3577-f2db-8b969b3bc4dd@intel.com>
> -----Original Message-----
> From: Gonzalez Monroy, Sergio
> Sent: Friday, June 30, 2017 2:52 PM
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Doherty,
> Declan <declan.doherty@intel.com>
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH 1/2] crypto/aesni_mb: support IPSec Multi-
> buffer lib v0.46
>
> On 28/06/2017 12:48, Pablo de Lara wrote:
> > IPSec Multi-buffer library v0.46 has been released, which includes,
> > among othe features, support for 12-byte IV, for AES-CTR, keeping also
> > the previous 16-byte IV, for backward compatibility reasons.
> >
> > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> > ---
> > doc/guides/cryptodevs/aesni_mb.rst | 18 +++++++++++++++++-
> > doc/guides/rel_notes/release_17_08.rst | 6 ++++++
> > drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c | 4 ++--
> > 3 files changed, 25 insertions(+), 3 deletions(-)
> >
> > diff --git a/doc/guides/cryptodevs/aesni_mb.rst
> > b/doc/guides/cryptodevs/aesni_mb.rst
> > index ecb52a1..fafcd9f 100644
> > --- a/doc/guides/cryptodevs/aesni_mb.rst
> > +++ b/doc/guides/cryptodevs/aesni_mb.rst
> > @@ -69,6 +69,9 @@ Limitations
> > * Chained mbufs are not supported.
> > * Only in-place is currently supported (destination address is the same
> as source address).
> > * Only supports session-oriented API implementation (session-less APIs
> are not supported).
> > +* If IV is passed with 16 bytes, last 4 bytes will be ignored, as
> > +underlying library only
> > + requires 12 bytes and will append 4 bytes (counter) at the end.
> > + The library always set these 4 bytes to 1, as IPSec requires counter to
> be set to 1.
>
> I don't think the text above is correct.
Forgot to remove that, well spotted!
Will send a v2 shortly.
Thanks,
Pablo
next prev parent reply other threads:[~2017-07-02 10:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-28 11:48 [dpdk-dev] [PATCH 0/2] AES-NI MB PMD: support Multi-buffer library 0.46 Pablo de Lara
2017-06-28 11:48 ` [dpdk-dev] [PATCH 1/2] crypto/aesni_mb: support IPSec Multi-buffer lib v0.46 Pablo de Lara
2017-06-30 13:52 ` Sergio Gonzalez Monroy
2017-07-02 10:46 ` De Lara Guarch, Pablo [this message]
2017-06-28 11:48 ` [dpdk-dev] [PATCH 2/2] test/crypto: add 12-byte IV AES-CTR test cases Pablo de Lara
2017-07-02 2:55 ` [dpdk-dev] [PATCH v2 0/2] AES-NI MB PMD: support Multi-buffer library 0.46 Pablo de Lara
2017-07-02 2:55 ` [dpdk-dev] [PATCH v2 1/2] crypto/aesni_mb: support IPSec Multi-buffer lib v0.46 Pablo de Lara
2017-07-03 16:03 ` Declan Doherty
2017-07-02 2:55 ` [dpdk-dev] [PATCH v2 2/2] test/crypto: add 12-byte IV AES-CTR test cases Pablo de Lara
2017-07-03 16:03 ` Declan Doherty
2017-07-03 20:22 ` [dpdk-dev] [PATCH v2 0/2] AES-NI MB PMD: support Multi-buffer library 0.46 De Lara Guarch, Pablo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E115CCD9D858EF4F90C690B0DCB4D8976CBD26E6@IRSMSX108.ger.corp.intel.com \
--to=pablo.de.lara.guarch@intel.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=sergio.gonzalez.monroy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).