From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: "Trahe, Fiona" <fiona.trahe@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"Trahe, Fiona" <fiona.trahe@intel.com>
Cc: "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] crypto/qat: fix possible out-of-bounds error
Date: Thu, 6 Jul 2017 14:20:27 +0000 [thread overview]
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8976CBD75A9@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <1499095467-6516-1-git-send-email-fiona.trahe@intel.com>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Fiona Trahe
> Sent: Monday, July 3, 2017 4:24 PM
> To: dev@dpdk.org; De Lara Guarch, Pablo
> <pablo.de.lara.guarch@intel.com>; Trahe, Fiona <fiona.trahe@intel.com>
> Subject: [dpdk-dev] [PATCH] crypto/qat: fix possible out-of-bounds error
>
> Out-of-bounds access possible if ctx.qat_cipher_alg has invalid value.
> This should never happen at this point on data path, but fix for safety.
>
> Coverity issue: 143458
> Coverity issue: 143465
>
> Fixes: d18ab45f7654 ("crypto/qat: support DOCSIS BPI mode")
>
> Signed-off-by: Fiona Trahe <fiona.trahe@intel.com>
> ---
> drivers/crypto/qat/qat_crypto.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/crypto/qat/qat_crypto.c
> b/drivers/crypto/qat/qat_crypto.c index f8e1d01..33b6eb0 100644
> --- a/drivers/crypto/qat/qat_crypto.c
> +++ b/drivers/crypto/qat/qat_crypto.c
> @@ -618,7 +618,8 @@ qat_bpicipher_preprocess(struct qat_session *ctx,
> {
> uint8_t block_len = qat_cipher_get_block_size(ctx-
> >qat_cipher_alg);
> struct rte_crypto_sym_op *sym_op = op->sym;
> - uint8_t last_block_len = sym_op->cipher.data.length % block_len;
> + uint8_t last_block_len = block_len > 0 ?
> + sym_op->cipher.data.length % block_len : 0;
>
> if (last_block_len &&
> ctx->qat_dir == ICP_QAT_HW_CIPHER_DECRYPT) {
> @@ -671,7 +672,8 @@ qat_bpicipher_postprocess(struct qat_session
> *ctx, {
> uint8_t block_len = qat_cipher_get_block_size(ctx-
> >qat_cipher_alg);
> struct rte_crypto_sym_op *sym_op = op->sym;
> - uint8_t last_block_len = sym_op->cipher.data.length % block_len;
> + uint8_t last_block_len = block_len > 0 ?
> + sym_op->cipher.data.length % block_len : 0;
>
> if (last_block_len > 0 &&
> ctx->qat_dir == ICP_QAT_HW_CIPHER_ENCRYPT) {
> --
> 2.7.4
CC'ing stable.
Applied to dpdk-next-crypto.
Thanks,
Pablo
parent reply other threads:[~2017-07-06 14:20 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1499095467-6516-1-git-send-email-fiona.trahe@intel.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E115CCD9D858EF4F90C690B0DCB4D8976CBD75A9@IRSMSX108.ger.corp.intel.com \
--to=pablo.de.lara.guarch@intel.com \
--cc=dev@dpdk.org \
--cc=fiona.trahe@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).