From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>,
Jan Blunck <jblunck@infradead.org>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Doherty, Declan" <declan.doherty@intel.com>
Subject: Re: [dpdk-dev] [PATCH 2/2] cryptodev: rework cryptodev PMD init to not require rte_vdev.h
Date: Wed, 12 Jul 2017 13:07:26 +0000 [thread overview]
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8976CBDAD5F@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <E115CCD9D858EF4F90C690B0DCB4D8976CBDACD4@IRSMSX108.ger.corp.intel.com>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of De Lara Guarch,
> Pablo
> Sent: Wednesday, July 12, 2017 1:40 PM
> To: Jan Blunck <jblunck@infradead.org>; dev@dpdk.org
> Cc: Doherty, Declan <declan.doherty@intel.com>
> Subject: Re: [dpdk-dev] [PATCH 2/2] cryptodev: rework cryptodev PMD init
> to not require rte_vdev.h
>
>
>
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jan Blunck
> > Sent: Wednesday, July 12, 2017 9:00 AM
> > To: dev@dpdk.org
> > Cc: Doherty, Declan <declan.doherty@intel.com>
> > Subject: [dpdk-dev] [PATCH 2/2] cryptodev: rework cryptodev PMD init
> > to not require rte_vdev.h
> >
> > This reworks the library code so that it doesn't require to include
> > rte_vdev.h. This is a preparation to move the vdev bus into a
> > standalone library.
> >
> > Signed-off-by: Jan Blunck <jblunck@infradead.org>
>
> ...
>
> > diff --git a/lib/librte_cryptodev/rte_cryptodev_vdev.h
> > b/lib/librte_cryptodev/rte_cryptodev_vdev.h
> > index 94ab9d33d..a877eed74 100644
> > --- a/lib/librte_cryptodev/rte_cryptodev_vdev.h
> > +++ b/lib/librte_cryptodev/rte_cryptodev_vdev.h
> > @@ -33,7 +33,6 @@
> > #ifndef _RTE_CRYPTODEV_VDEV_H_
> > #define _RTE_CRYPTODEV_VDEV_H_
> >
> > -#include <rte_vdev.h>
> > #include <inttypes.h>
> >
> > #include "rte_cryptodev.h"
> > @@ -72,15 +71,15 @@ struct rte_crypto_vdev_init_params {
> > * @param name PMD type name
> > * @param dev_private_size Size of crypto PMDs private data
> > * @param socket_id Socket to allocate resources on.
> > - * @param vdev Pointer to virtual device structure.
> > + * @param dev Pointer to device structure.
> > *
> > * @return
> > * - Cryptodev pointer if device is successfully created.
> > * - NULL if device cannot be created.
> > */
> > struct rte_cryptodev *
> > -rte_cryptodev_vdev_pmd_init(const char *name, size_t
> dev_private_size,
> > - int socket_id, struct rte_vdev_device *vdev);
> > +rte_cryptodev_pmd_init(const char *name, size_t dev_private_size,
> > + int socket_id, struct rte_device *dev);
>
> Hi Jan,
>
> Even though now this function does not require the rte_vdev_device
> structure, I would still call it rte_cryptodev_vdev_pmd_init, as it is used for
> virtual crypto devices and not physical ones.
>
> The rest look ok to me.
Just another note. Check-git-log.sh complains about the title:
Wrong headline format:
cryptodev: rework cryptodev PMD init to not require rte_vdev.h
Headline too long:
cryptodev: rework cryptodev PMD init to not require rte_vdev.h
So this needs some rework (e.g. no need to use cryptodev word again).
Thanks,
Pablo
>
> Thanks,
> Pablo
next prev parent reply other threads:[~2017-07-12 13:07 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-12 7:59 [dpdk-dev] [PATCH 0/2] cryptodev vdev changes for -rc2 Jan Blunck
2017-07-12 7:59 ` [dpdk-dev] [PATCH 1/2] cryptodev: remove obsolete include Jan Blunck
2017-07-12 12:35 ` De Lara Guarch, Pablo
2017-07-12 7:59 ` [dpdk-dev] [PATCH 2/2] cryptodev: rework cryptodev PMD init to not require rte_vdev.h Jan Blunck
2017-07-12 12:39 ` De Lara Guarch, Pablo
2017-07-12 13:07 ` De Lara Guarch, Pablo [this message]
2017-07-12 19:58 ` [dpdk-dev] [PATCH v2 0/4] cryptodev vdev changes for -rc2 Jan Blunck
2017-07-12 19:58 ` [dpdk-dev] [PATCH v2 1/4] cryptodev: remove obsolete include Jan Blunck
2017-07-12 19:58 ` [dpdk-dev] [PATCH v2 2/4] cryptodev: move initialization Jan Blunck
2017-07-12 19:58 ` [dpdk-dev] [PATCH v2 3/4] cryptodev: rework PMD init to not require rte_vdev.h Jan Blunck
2017-07-15 11:04 ` De Lara Guarch, Pablo
2017-09-04 14:32 ` De Lara Guarch, Pablo
2017-10-05 14:52 ` Jan Blunck
2017-10-05 15:19 ` De Lara Guarch, Pablo
2017-07-12 19:58 ` [dpdk-dev] [PATCH v2 4/4] cryptodev: move parameter parsing to its own header Jan Blunck
2017-07-19 13:31 ` [dpdk-dev] [PATCH v2 0/4] cryptodev vdev changes for -rc2 De Lara Guarch, Pablo
2017-07-27 19:31 ` Jan Blunck
2017-08-01 10:39 ` De Lara Guarch, Pablo
2017-10-06 8:39 ` [dpdk-dev] [PATCH v3 0/4] cryptodev vdev changes for 17.11-rc1 Jan Blunck
2017-10-25 14:33 ` De Lara Guarch, Pablo
2017-10-25 16:05 ` De Lara Guarch, Pablo
2017-10-06 8:39 ` [dpdk-dev] [PATCH v3 1/4] cryptodev: remove obsolete include Jan Blunck
2017-10-06 8:39 ` [dpdk-dev] [PATCH v3 2/4] cryptodev: move initialization Jan Blunck
2017-10-10 8:45 ` De Lara Guarch, Pablo
2017-10-06 8:39 ` [dpdk-dev] [PATCH v3 3/4] cryptodev: rework dependency on vdev header Jan Blunck
2017-10-10 8:47 ` De Lara Guarch, Pablo
2017-10-10 11:29 ` Jan Blunck
2017-10-10 12:49 ` De Lara Guarch, Pablo
2017-10-11 14:45 ` De Lara Guarch, Pablo
2017-10-06 8:39 ` [dpdk-dev] [PATCH v3 4/4] cryptodev: move parameter parsing to its own header Jan Blunck
2017-10-10 8:48 ` De Lara Guarch, Pablo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E115CCD9D858EF4F90C690B0DCB4D8976CBDAD5F@IRSMSX108.ger.corp.intel.com \
--to=pablo.de.lara.guarch@intel.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=jblunck@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).