From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: Yuanhan Liu <yliu@fridaylinux.org>
Cc: Akhil Goyal <akhil.goyal@nxp.com>, "dev@dpdk.org" <dev@dpdk.org>,
"stable@dpdk.org" <stable@dpdk.org>,
"hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>
Subject: Re: [dpdk-stable] [PATCH v2] crypto/dpaa2_sec: fix the return of supported API
Date: Tue, 18 Jul 2017 16:21:08 +0000 [thread overview]
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8976CBDEDBD@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <20170718143907.GV11626@yliu-home>
HI Yuanhan,
> -----Original Message-----
> From: Yuanhan Liu [mailto:yliu@fridaylinux.org]
> Sent: Tuesday, July 18, 2017 3:39 PM
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> Cc: Akhil Goyal <akhil.goyal@nxp.com>; dev@dpdk.org; stable@dpdk.org;
> hemant.agrawal@nxp.com
> Subject: Re: [PATCH v2] crypto/dpaa2_sec: fix the return of supported API
>
> On Tue, Jul 18, 2017 at 10:26:39AM +0000, De Lara Guarch, Pablo wrote:
> > Hi Akhil,
> >
> > > -----Original Message-----
> > > From: Akhil Goyal [mailto:akhil.goyal@nxp.com]
> > > Sent: Tuesday, July 18, 2017 8:34 AM
> > > To: dev@dpdk.org; stable@dpdk.org
> > > Cc: hemant.agrawal@nxp.com; De Lara Guarch, Pablo
> > > <pablo.de.lara.guarch@intel.com>; yliu@fridaylinux.org; Akhil Goyal
> > > <akhil.goyal@nxp.com>
> > > Subject: [PATCH v2] crypto/dpaa2_sec: fix the return of supported
> > > API
> > >
> > > call to dpaa2_sec_dev_configure() is made mandatory, but
> > > dpaa2_sec_pmd returns a ENOTSUP which results in device not getting
> configured.
> > >
> > > dpaa2_sec PMD does not need any further configuration to be done in
> > > dpaa2_sec_dev_configure, hence returning 0
> > >
> > > Fixes: e5cbdfc53765 ("crypto/dpaa2_sec: add basic operations")
> > >
> > > Cc: stable@dpdk.org
> > >
> > > Signed-off-by: Akhil Goyal <akhil.goyal@nxp.com>
> >
> > Looks ok to me, but this is only applicable in the stable branch, so
> > no need to send it to dev@dpdk.org.
>
> Why? We already have such fix in upstream? Normally, we just pick
> upstream commits (but not patches: the emails) to stable release.
It looks like this fix was included in
13273250eec5 ("crypto/dpaa2_sec: support AES-GCM and CTR").
Unfortunately, this patch should have been split into two different patches.
Since this has already been merged, I think our only way to integrate this
In 17.05.1 is by getting it separately.
Pablo
>
> --yliu
next prev parent reply other threads:[~2017-07-18 16:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-18 7:33 Akhil Goyal
2017-07-18 10:26 ` De Lara Guarch, Pablo
2017-07-18 14:39 ` Yuanhan Liu
2017-07-18 16:21 ` De Lara Guarch, Pablo [this message]
2017-07-18 17:32 ` Hemant Agrawal
2017-07-19 12:12 ` Yuanhan Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E115CCD9D858EF4F90C690B0DCB4D8976CBDEDBD@IRSMSX108.ger.corp.intel.com \
--to=pablo.de.lara.guarch@intel.com \
--cc=akhil.goyal@nxp.com \
--cc=dev@dpdk.org \
--cc=hemant.agrawal@nxp.com \
--cc=stable@dpdk.org \
--cc=yliu@fridaylinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).